From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 56F1FAC10B6 for ; Sun, 31 Mar 2024 11:56:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5V1GaGW3a0xIsydZqhW7cj274ve4e/VZfmHiNyULZ4s=; c=relaxed/simple; d=groups.io; h=Received-SPF:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711886158; v=1; b=LdN2S246dXwNt1IHfnFwa0Zv5M5YQkW2ENEDqTu5AAKs6wpOlBWPfpzbXptkJBvNr4yB8LjY psio6Ez6JQX1/sGXcp1YFmTlmQOvOBDXytOlxgNSifu9WgEPhBohLWxG3VaMApNphGYaJKsgAYW Dv/R/gwJ0MOj0IK+SFNhEl/bbdVVuvPvZOoi5KfvC14hSf0ZLBQPAPHd4j0e9hhqEPl8oWjq+jX 2KIwWKxGCIn5AmgZvyQeOwdwU5KVQnpFrKu983Dco6X9Xuxf30I7z3j2yiSNrxDBZmYZNYX61d9 bhxSzvlB5ui5rkLZWKw9y9ZR+AEv1Pb9tQJAh7SrXaniw== X-Received: by 127.0.0.2 with SMTP id X8csYY7687511x9dI446nKzs; Sun, 31 Mar 2024 04:55:58 -0700 X-Received: from EUR02-AM0-obe.outbound.protection.outlook.com (EUR02-AM0-obe.outbound.protection.outlook.com [40.107.247.73]) by mx.groups.io with SMTP id smtpd.web10.15721.1711886157128429997 for ; Sun, 31 Mar 2024 04:55:57 -0700 X-Received: from DU2PR04CA0042.eurprd04.prod.outlook.com (2603:10a6:10:234::17) by AS4PR08MB7903.eurprd08.prod.outlook.com (2603:10a6:20b:51e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.45; Sun, 31 Mar 2024 11:55:54 +0000 X-Received: from DB1PEPF000509F6.eurprd02.prod.outlook.com (2603:10a6:10:234:cafe::46) by DU2PR04CA0042.outlook.office365.com (2603:10a6:10:234::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Sun, 31 Mar 2024 11:55:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF000509F6.mail.protection.outlook.com (10.167.242.152) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sun, 31 Mar 2024 11:55:53 +0000 X-Received: ("Tessian outbound 9d16f63426bd:v300"); Sun, 31 Mar 2024 11:55:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cde2feb81f159519 X-CR-MTA-TID: 64aa7808 X-Received: from e8230531ef64.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 40CB7229-E63D-4E86-80E9-0CD8AA18625B.1; Sun, 31 Mar 2024 11:55:47 +0000 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e8230531ef64.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 31 Mar 2024 11:55:46 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB4PR08MB9189.eurprd08.prod.outlook.com (2603:10a6:10:3fe::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.43; Sun, 31 Mar 2024 11:55:42 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c%5]) with mapi id 15.20.7409.042; Sun, 31 Mar 2024 11:55:39 +0000 Message-ID: <87903e06-e218-42ec-87d0-021601915436@arm.com> Date: Sun, 31 Mar 2024 12:55:36 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 7/9] Platform/Sgi: Extend SMBIOS support for RD-Fremont To: Prabin CA , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Thomas Abraham , "nd@arm.com" References: <20240311131416.823580-1-prabin.ca@arm.com> <20240311131416.823580-8-prabin.ca@arm.com> From: "Sami Mujawar" In-Reply-To: <20240311131416.823580-8-prabin.ca@arm.com> X-ClientProxiedBy: LO2P265CA0516.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB4PR08MB9189:EE_|DB1PEPF000509F6:EE_|AS4PR08MB7903:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Txd1oFHbtyeHdnJy/pcAu5d0OTjG9fZXt7nPkzAL2FoYorO6Mz/UjlJLNr7O5TOL/3O2ot5I+MDiiDuXq1Vp+U+988ztO/PKbLEhp2ZuLNvfKoAutLymtdelhVSGaHTcQ4n6VAly0RQFLFb70qs3R+Eh8JE0jOQUYyOtGVFB/04CWdBoLjn0qtPdPGuX3zsu2BbTcKdMns8daOYXhtNFxr7d/VpcYWmxomp92dOF1eyNPPySFdXagDp20qESaSyvDQhxqiF4zpZ4EB29SSgQqpF6MwtHw5qz5EDtDHwHPrJHP0A2j6AN7kGB3qKUbOPTJt6XlQuVT6/jBbvWaBi8mV7LtPpqQltVoQzT6LLQwHeWkkkeNgevCoM04RhjOwGlr+5AtNQs9C25fqsAI8BFZbx+BOBUfB4rTxq0Tqrm7CvkLFCZSkXW+S03l5rcgfdlaWoGiqIIXMfKKR/TErzA+r3WP+hK+eYd/ux7fEY170rqwqc2aJtUVMNqHUFNn13Rj100ebgy0Hk9Aev3BS89E9kMMIApxstA91+2JGxtIY7PwS8vYdKx6coQyAxttGe1VVYsXBf/d23n8eZpl/CpIMnuDAFdF1UoCteDRgFaDp6gSLVK2FN6//nvEo4UL3M/+Fi6dUT5WzHjB1XG//FKbWgnztt+L5mfzshRglBlY5g= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9189 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509F6.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff2a1409-22a2-43e5-2f63-08dc517984af X-Microsoft-Antispam-Message-Info: 7CPF/zxLC5Yd0UFzd8igGJiKSDSX52cR4wvVzNmISJEjn4WC64ntdQ/QHJK2lcNHlRyWQMurLnsDf6SLo2vkuQItCRQskwDUNMAPmsQSHAPQ/Q0tGpe9GihtF0CPi5ofMW/xlOOf5yMN2TXBU4YWUKb73D8cBHB+EAoTYSEeD5vIJiLV1L4oqo06r6vC1ZzGnSoc+AhgouQnWvIB79EPTsUp2+dV23iLPSnMiHqszmWtIbKkXIH7SCA9pbCgyJl4xs2PN28Uk4n5VhdKPk6W0W8qZxDOry2dbuJrVVEa7mvPKhzMbEshMvP2BSQ6C7nKkdd8yqQQdwhXvCxQDKvJbOfCZuqBY1iZDv7jtUyotgokHc+9KSkRnR+6xAUx/95E5/BiGfTd2GZLNrwHBFWiSlh5tzrTSNQCxiqgpWhqpArx3D9q8xqA2xvAncnYlnb+FXiRW07Z5ffTuxbvznergsSgD/6ZgU0NLpH0XHDC0rcqc5sjz4C+Ccm/XyKRNzU+MiVro9DZZQnejQJ1bUXgOjRuIiipmpWkhVXU0myPqQqq/z9/PNieShgbuhUFj1IWQeQhxHoLQjUY9lKIK+ktMKdHKGmDEEOoCqHi49VzdpXVIk17uAFKIhtutK0d4FblKOmr+i/zEugBspBO8tWKvLSu6pQskzKiGgysOj0HBYuNOLkEHV93XoEaujLI9hLO8KZSZ2pZU1vmkg01Bq5TGv6rYkKJydQ3+v//quauWPihsnIwvy5V1VK8T8YSD1el X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 11:55:53.8733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff2a1409-22a2-43e5-2f63-08dc517984af X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F6.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7903 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 31 Mar 2024 04:55:58 -0700 Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pkvM2s4Nmrv2Yv7sPXdzDcRux7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=LdN2S246; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Prabin, Thank you for this patch. This patch does not cleanly apply on the latest edk2-platforms master=20 branch. Can you check, please? Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: > Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a > 16 core platform with Poseidon CPU. Each of the CPUs include > 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache. > The platform also includes system level cache of 32MB and 8GB of RAM. > > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/Include/SgiPlatform.h = | 5 +++++ > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c = | 5 ++++- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation= .c | 5 ++++- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c = | 1 + > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c = | 6 ++++++ > 5 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/Sgi= Pkg/Include/SgiPlatform.h > index 6fa39d407bc9..acfa45910aed 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -51,6 +51,10 @@ > #define RD_V2_PART_NUM 0x7F2 > #define RD_V2_CONF_ID 0x1 > =20 > +// RD-Fremont Platform Identification values > +#define RD_Fremont_PART_NUM 0x7EE > +#define RD_Fremont_CONF_ID 0x1 > + > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > #define SGI_PART_NUM_MASK 0xFFF > @@ -90,6 +94,7 @@ typedef enum { > RdN2Cfg1, > RdN2Cfg2, > RdV2, > + RdFremont, > } ARM_RD_PRODUCT_ID; > =20 > // Arm ProductId look-up table > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInf= ormation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInfor= mation.c > index edf2a5f63c63..9c28b051ebc2 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformatio= n.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformatio= n.c > @@ -34,7 +34,8 @@ > "RdN2\0" \ > "RdN2Cfg1\0" \ > "RdN2Cfg2\0" \ > - "RdV2\0" > + "RdV2\0" \ > + "RdFremont\0" > =20 > typedef enum { > ManufacturerName =3D 1, > @@ -74,6 +75,8 @@ STATIC GUID mSmbiosUid[] =3D { > {0xd2946d07, 0x8057, 0x4c26, {0xbf, 0x53, 0x78, 0xa6, 0x5b, 0xe1, 0xc= 1, 0x60}}, > /* Rd-V2 */ > {0x3b1180a3, 0x0744, 0x4194, {0xae, 0x2e, 0xed, 0xa5, 0xbc, 0x2e, 0x4= 3, 0x45}}, > + /* Rd-Fremont */ > + {0x904b28d6, 0x0662, 0x11ed, {0xb9, 0x39, 0x02, 0x42, 0xac, 0x12, 0x00= , 0x02}}, > }; > =20 > /* System information */ > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4Processor= Information.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4Processo= rInformation.c > index ee269f707714..c39c1553f6aa 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInforma= tion.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInforma= tion.c > @@ -44,6 +44,7 @@ > "Neoverse-N2\0" \ > "Neoverse-N2\0" \ > "Neoverse-V2\0" \ > + "Neoverse-Poseidon\0" \ > "000-0\0" /* Serial number */ \ > "783-3\0" \ > "786-1\0" \ > @@ -54,7 +55,8 @@ > "7B7-1\0" \ > "7B6-1\0" \ > "7B7-1\0" \ > - "7F2-1\0" > + "7F2-1\0" \ > + "7EE-1\0" > =20 > typedef enum { > PartNumber =3D 1, > @@ -181,6 +183,7 @@ InstallType4ProcessorInformation ( > case RdN2: > case RdN2Cfg1: > case RdV2: > + case RdFremont: > mArmRdSmbiosType4.Base.CoreCount =3D CoreCount; > mArmRdSmbiosType4.Base.EnabledCoreCount =3D CoreCount; > mArmRdSmbiosType4.Base.ThreadCount =3D CoreCount; > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInfo= rmation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInforma= tion.c > index 4af72919a3f1..4cdea5b3b763 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation= .c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation= .c > @@ -335,6 +335,7 @@ InstallType7CacheInformation ( > mArmRdSmbiosType7[4].Base.Associativity =3D CacheAssociativity16Way= ; > break; > case RdV2: > + case RdFremont: > /* L1 instruction cache */ > mArmRdSmbiosType7[0].Base.MaximumCacheSize2 =3D 64; // 64KB > mArmRdSmbiosType7[0].Base.InstalledSize2 =3D 64; // 64KB > diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c b/Plat= form/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c > index 14b06796ae9c..ae31be142d12 100644 > --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c > +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c > @@ -85,6 +85,12 @@ STATIC CONST SGI_PRODUCT_ID_LOOKUP SgiProductIdLookup[= ] =3D { > RD_V2_CONF_ID, > 0 > }, > + { > + RdFremont, > + RD_Fremont_PART_NUM, > + RD_Fremont_CONF_ID, > + 0 > + }, > }; > =20 > EFI_BOOT_MODE -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117258): https://edk2.groups.io/g/devel/message/117258 Mute This Topic: https://groups.io/mt/104862636/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-