From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF3A48213A for ; Fri, 24 Feb 2017 15:18:59 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8948B8553D; Fri, 24 Feb 2017 23:19:00 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-15.phx2.redhat.com [10.3.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id BAE2C15847; Fri, 24 Feb 2017 23:18:57 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@ml01.01.org, leif.lindholm@linaro.org References: <1487961625-16786-1-git-send-email-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <8796a9c6-303f-6a00-9d3a-f844d9f80c23@redhat.com> Date: Sat, 25 Feb 2017 00:18:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1487961625-16786-1-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 24 Feb 2017 23:19:00 +0000 (UTC) Subject: Re: [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 23:19:00 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/24/17 19:40, Ard Biesheuvel wrote: > This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with > any remaining references to it in various platform .DSC files. It is > no longer used now that we removed the virtual uncached pages protocol > and the associated DebugUncachedMemoryAllocationLib library instance. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/ArmPkg.dec | 1 - > ArmVirtPkg/ArmVirtQemu.dsc | 5 ----- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > BeagleBoardPkg/BeagleBoardPkg.dsc | 5 ----- > Omap35xxPkg/Omap35xxPkg.dsc | 5 ----- > 5 files changed, 21 deletions(-) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index 4fd7a5be5158..c4b4da2f95bb 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -84,7 +84,6 @@ [PcdsFixedAtBuild.common] > # Using a FeaturePcd make a '(BOOLEAN) casting for its value which is not understood by the preprocessor. > gArmTokenSpaceGuid.PcdVFPEnabled|0|UINT32|0x00000024 > > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000080000000|UINT64|0x00000002 > # This PCD will free the unallocated buffers if their size reach this threshold. > # We set the default value to 512MB. > gArmTokenSpaceGuid.PcdArmFreeUncachedMemorySizeThreshold|0x20000000|UINT64|0x00000003 > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 8fe3c3816961..00cdd7c20201 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common] > # Size of the region used by UEFI in permanent memory (Reserved 64MB) > gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec) > gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index aa40374745af..8354b13ddb1a 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common] > # Size of the region used by UEFI in permanent memory (Reserved 64MB) > gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec) > gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index a71a01ac7723..87879c33fcd9 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -368,11 +368,6 @@ [PcdsFixedAtBuild.common] > # Shell. > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10 > > # GUID of the UEFI Shell > diff --git a/Omap35xxPkg/Omap35xxPkg.dsc b/Omap35xxPkg/Omap35xxPkg.dsc > index ad7d9898c330..fc94ca7ed129 100644 > --- a/Omap35xxPkg/Omap35xxPkg.dsc > +++ b/Omap35xxPkg/Omap35xxPkg.dsc > @@ -162,11 +162,6 @@ [PcdsFixedAtBuild.common] > # OMAP Interrupt Controller > gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x48200000 > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > Reviewed-by: Laszlo Ersek