Re: [edk2-platforms][PATCH v2 3/7] Platform/RPi: Replace Bcm283x SoC base register address with a PCD

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 11/19/19 12:57 PM, Pete Batard wrote:
> On 2019.11.19 11:43, Philippe Mathieu-Daudé wrote:
>> On 11/19/19 12:38 PM, Pete Batard wrote:
>>> From: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
>>>
>>> Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is
>>> needed in preparation for adding Raspberry Pi 4 support, since the two
>>> Pi's have a different base addresses for the Bcm283x specific registers.
>>>
>>
>> Shouldn't this patch also include Samer's S-o-b tag?
> 
> I think we went over this already (but I can't seem to find that e-mail 
> from the list).
> 
> As per Leif's comments in 
> https://www.mail-archive.com/devel@edk2.groups.io/msg05292.html:
> 
> "I don't want patches submitted with anyone other than the
> contributor's Signed-off-by"

I missed this thread, now I'm slightly confused.

Checking the Wiki:

https://github.com/tianocore/edk2/blob/master/Readme.md#code-contributions

and:

https://github.com/tianocore/tianocore.github.io/wiki/Commit-Signature-Format#signed-off-by

Signed-off-by

     Authors should use Signed-off-by (See example below)
     If you've received the code from a trusted source, and are
     forwarding it along, please add a Signed-off-by line for
     yourself to indicate that you know this code to be usable
     by our community.

The guideline is simply "add a S-o-b", but Leif says "[only?] If patches 
are modified after contribution, but before being pushed, then then 
additional contributions can be reflected with additional 
Signed-off-bys." and then "I don't want patches submitted with anyone 
other than the contributor's Signed-off-by:".

Leif, can we clarify and update the documentation accordingly?

Sorry to be picky, but that would clear any confusion.

Thanks,

Phil.