From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.10534.1574165798455946777 for ; Tue, 19 Nov 2019 04:16:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Nn+JQwWl; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574165797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9AYGmpS/tNzkXu/eckedyR5lBjJPa47hb5n6ruGPBhY=; b=Nn+JQwWlVnYn42epbaym+VQ0wlMqG9KZqycPOMHpxBOAkdh4JW48qGkLXsMT7Ukq5v6MF2 DAIBLTdH/t0HXtL9hcax2UvgjB4ArDos547oExP+zgoAD8umqL/De3EQIXU1T8g8gdQzwh 5a1cy3kIjqgwkATOZsHhlyx638rV3UE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-7MlpMBnPMnKr6zKb3JmPtA-1; Tue, 19 Nov 2019 07:16:31 -0500 Received: by mail-wm1-f69.google.com with SMTP id b10so2148784wmh.6 for ; Tue, 19 Nov 2019 04:16:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W7dGvjunquVx5oiVsw7xpdYUkVSuwqKi3w5zQR0Zy/g=; b=cn/FGCC/OBGD6aMSyGzHZZUwDfY1p10yMHjEhkNhGeunWyNVpAlssVPFRVe5puwWat 4hkNEaRgEpd+gdePA37yNDpJgdc/fCxRJXGL+oTiXsMlmx9XD7qlW2VBSc68U82ZOkO1 fJwQh9ibCOvzZVl3KFa8jbOqS9qaYEdLjhbkPpu0xGaEbhaZ5EkNwg1hnLZjZ2IZcLFk HTVg2r2z5G4NQ6iy1YHtO9V8JkKetMNL/i1WqLZekBXQoH2VWstnTdDGtp7lT/icZEsy 6Zp6HAvxfIXG37gZeCLGZe3Y+fEKt7mFD5/yDJxAfO5oukv9PypI1dFQHFEyse1QWxGj lVQw== X-Gm-Message-State: APjAAAWGmRAt8sS66Lve8vK+EpVBbx51Uc6njniEj1xISHrS4p09qj5M xvyihnv16L+CvavSCa0z2VzCyZyP+snzomT53SxxxTIOdIcMEg9EzCl37dPy+bRE+H6gR2LVMEX 8pt4PfNVDs8ZaJg== X-Received: by 2002:a5d:538d:: with SMTP id d13mr39098225wrv.304.1574165790423; Tue, 19 Nov 2019 04:16:30 -0800 (PST) X-Google-Smtp-Source: APXvYqzONX+5X4degclWnIqIUFvNl/jPc1BRfVu9v2oAeNeQprk8kbuiEh4/TiaRGRNz/zZFeTdnNw== X-Received: by 2002:a5d:538d:: with SMTP id d13mr39098194wrv.304.1574165790212; Tue, 19 Nov 2019 04:16:30 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id b2sm1456047wrr.76.2019.11.19.04.16.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2019 04:16:29 -0800 (PST) Subject: Re: [edk2-platforms][PATCH v2 3/7] Platform/RPi: Replace Bcm283x SoC base register address with a PCD To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: Pete Batard , ard.biesheuvel@linaro.org, samer.el-haj-mahmoud@arm.com, Laszlo Ersek References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-4-pete@akeo.ie> <092d22cc-cd21-61ad-0317-3b2a3fc6c2cf@redhat.com> <1ae9ef75-aecb-e71c-c1b5-ce9f5d99c5a0@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <87a12ccb-0441-72dd-875f-840b0a2a2861@redhat.com> Date: Tue, 19 Nov 2019 13:16:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1ae9ef75-aecb-e71c-c1b5-ce9f5d99c5a0@akeo.ie> X-MC-Unique: 7MlpMBnPMnKr6zKb3JmPtA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/19/19 12:57 PM, Pete Batard wrote: > On 2019.11.19 11:43, Philippe Mathieu-Daud=C3=A9 wrote: >> On 11/19/19 12:38 PM, Pete Batard wrote: >>> From: Samer El-Haj-Mahmoud >>> >>> Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is >>> needed in preparation for adding Raspberry Pi 4 support, since the two >>> Pi's have a different base addresses for the Bcm283x specific registers= . >>> >> >> Shouldn't this patch also include Samer's S-o-b tag? >=20 > I think we went over this already (but I can't seem to find that e-mail= =20 > from the list). >=20 > As per Leif's comments in=20 > https://www.mail-archive.com/devel@edk2.groups.io/msg05292.html: >=20 > "I don't want patches submitted with anyone other than the > contributor's Signed-off-by" I missed this thread, now I'm slightly confused. Checking the Wiki: https://github.com/tianocore/edk2/blob/master/Readme.md#code-contributions and: https://github.com/tianocore/tianocore.github.io/wiki/Commit-Signature-Form= at#signed-off-by Signed-off-by Authors should use Signed-off-by (See example below) If you've received the code from a trusted source, and are forwarding it along, please add a Signed-off-by line for yourself to indicate that you know this code to be usable by our community. The guideline is simply "add a S-o-b", but Leif says "[only?] If patches=20 are modified after contribution, but before being pushed, then then=20 additional contributions can be reflected with additional=20 Signed-off-bys." and then "I don't want patches submitted with anyone=20 other than the contributor's Signed-off-by:". Leif, can we clarify and update the documentation accordingly? Sorry to be picky, but that would clear any confusion. Thanks, Phil.