From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [patch] MdeModulePkg/HiiDB: Fix incorrect structure convention for checkbox
Date: Tue, 9 Oct 2018 10:06:34 +0800 [thread overview]
Message-ID: <87eb8805-b849-4573-e0b1-81fd41f06745@Intel.com> (raw)
In-Reply-To: <8e30eaaa-e794-8019-0c4a-87b96547f11a@redhat.com>
On 10/8/2018 11:15 PM, Laszlo Ersek wrote:
> On 10/08/18 16:32, Bi, Dandan wrote:
>>>
>>> what were the practical consequences (symptoms) of this issue? Did some
>>> checkboxes not work? (I'm asking because SecureBootConfigDxe uses some
>>> checkboxes.)
>>
>> 1. The bug is in function "UpdateDefaultSettingInFormPackage()" which is to update the default setting of some HII Questions in the IFR binary data. So it only has impact when platform overrides default setting in HII VarStore through DynamicHii PCD setting in Platform DSC file. If platform doesn't override default setting, it has no impact.
>>
>> 2. The implementation updates the "Flags" filed in the EFI_IFR_CHECKBOX structure to update the default setting of checkbox.
>> If using "IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);" when wants to update the " Flags" filed in checkbox, but in fact it will update the opcode binary data(opcode binary length) behind checkbox binary.
>> And then it will cause Browser can't parse the IFR binary data correctly. And then the possible symptom is that some HII Question and forms may be not parsed and then cannot be shown.
>
> Thanks! I've copied this into the BZ.
Has this patch been pushed? If not, maybe you could also copy the above
description in the commit message.
A commit message that describes what to be fixed is more meaningful.
>
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
--
Thanks,
Ray
next prev parent reply other threads:[~2018-10-09 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 1:29 [patch] MdeModulePkg/HiiDB: Fix incorrect structure convention for checkbox Dandan Bi
2018-10-08 3:08 ` Gao, Liming
2018-10-08 12:18 ` Laszlo Ersek
2018-10-08 14:32 ` Bi, Dandan
2018-10-08 15:15 ` Laszlo Ersek
2018-10-09 2:06 ` Ni, Ruiyu [this message]
2018-10-09 2:13 ` Bi, Dandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eb8805-b849-4573-e0b1-81fd41f06745@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox