From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web12.11344.1608741316406620987 for ; Wed, 23 Dec 2020 08:35:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=zkcBeMI8; spf=pass (domain: akeo.ie, ip: 209.85.221.46, mailfrom: pete@akeo.ie) Received: by mail-wr1-f46.google.com with SMTP id 91so19195184wrj.7 for ; Wed, 23 Dec 2020 08:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UEAKJCchBgpGhmBV/vfcsSo8LMzAFdFhEsBs3pQ6E/8=; b=zkcBeMI8C81vvxzH5cRU5HmfuOn1EJI84nCe/EpKWyujKZd3YxhdgBiC+44Lo2DAb6 x7giytDLTZSrP6KDqjXmctDyp8tABNoTH1pqOiPc8Am1lUAB6d8C0lolHaQiiT+IxtTg /ntWb9dnp4hgjJrK/F3xtyd25iO4xaxFfznmQhzJER2xoZNFkUqLzuTOYJKRXCmHXNtH q0AGm3Ytk3RPH1qTAxG/v+K3ON3CzV5DjesnmFhTbmJhiBpnTFCM89AtQWYpjaAnarYm lB7VmBaLbEbOB81JgfGmESR/4hd98pIu0IZmI3fpKKNEelODCAsAd9pBGBNAnnnekRKp Gteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UEAKJCchBgpGhmBV/vfcsSo8LMzAFdFhEsBs3pQ6E/8=; b=k32L4MOW3/wKiykwkjCCEQ+SUWJamy5qQXPJadN1lewZLvJIWt33fDKWUZ2UvnNHEk 5+q5BVLwltW1+sKcrsiMFJ0UPN+LFc0SrZ7OQ+lahOSF5shOw2UUqCMfJ0fj0/xPb+sD tQey74ptIqBQt4lngOOB6WMKdYWMD/g8Dxbkd/XeyA9LhuNc2MgXTOSu5uhJ0Wj5YAZt KLJFYqcrKruaGo5lDVmduL7Tsfwsq6dgnncWCz5qxNo3FstD56AmUJv46sMsRlPVvU5M S/vow/Yg5Vyk1kTm6cHWYRbbGauxWMuERbXXd+7OJAD1h5/BjPg7HjMx654gihpPf1Qx biaQ== X-Gm-Message-State: AOAM5300nRvDIHgdPd7lBCmPqQDymaWbxPjc910DkTC31gkW6qtwI3Nc qWwAciT4tl2IMKRKToaNUXGkNg== X-Google-Smtp-Source: ABdhPJyNfydsijHFgR6knz4YOJ398Pre77Zt6A7GijDprXipiTGbJuhVytB+S17D5y7ul4M7PyuRHw== X-Received: by 2002:adf:902a:: with SMTP id h39mr8515255wrh.147.1608741314936; Wed, 23 Dec 2020 08:35:14 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.84.133]) by smtp.googlemail.com with ESMTPSA id n11sm18609076wra.9.2020.12.23.08.35.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 08:35:14 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY To: devel@edk2.groups.io, samer.el-haj-mahmoud@arm.com Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel References: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> <20201220135355.12814-4-Samer.El-Haj-Mahmoud@arm.com> From: "Pete Batard" Message-ID: <87f526a4-1328-7af3-e540-e3cf6f36cab0@akeo.ie> Date: Wed, 23 Dec 2020 16:35:13 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201220135355.12814-4-Samer.El-Haj-Mahmoud@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.12.20 13:53, Samer El-Haj-Mahmoud wrote: > ConSplitter is using EFI_LIGHTGRAY foreground color for ConOut > and EFI_MAGENTA for StdErr consoles. This is impacting the DebugLib > output on that same serial console (e.g. DebugLibSerialPort) after > gEfiStandardErrorDeviceGuid is installed on that port. The impact > also extends to Linux serial console output in OVMF because it inherits > the color setting from the firmware. > > This is inconsistent and annoying, with MAGENTA being barely legible on > a black background. > > Let's change StdErr default color to LIGHTGRAY for consistency and > readability. This results in the same color being used for all consoles > sharing the same serial port (ConOut, StdErr, DebugLib, OS console). > Platforms wishing to distinguish the colors of consoles can do so in > their own Platform BDS initialization. > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Ard Biesheuvel > Signed-off-by: Samer El-Haj-Mahmoud > --- > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index b090de288517..e8cd4ce120a0 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart ( > // their MaxMode and QueryData should be the intersection of both. > > // > > Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL); > > - ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK)); > > + ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIGHTGRAY, EFI_BLACK)); > > > > return Status; > > } > Reviewed-by: Pete Batard Tested-by: Pete Batard (On an RPi 4 platform where this was another annoyance)