From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=18.228.144.36; helo=mail.paulo.ac; envelope-from=paulo@paulo.ac; receiver=edk2-devel@lists.01.org Received: from mail.paulo.ac (mail.paulo.ac [18.228.144.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2F6BD21163DEA for ; Mon, 15 Oct 2018 04:39:33 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.paulo.ac (Postfix) with ESMTP id 54C6C484CF1A; Mon, 15 Oct 2018 11:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=paulo.ac; s=default; t=1539603571; bh=BfTMLG4pxYFEwhrNJkKifaSVdZltXXQgwQwys853F8k=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=F9shR9YITACTEw5sgj14bfG507Y/ggLE+M/TlG4nMpWpVUmbSe95ou1vZnXkjeVjc BgA4fBYwkfwGFBnveuOyuE3Y1nrz9eoZdPTXBPe1P3Z61y5txWMjgeQGGRkgXgWbSy QTrzdaWH7KQ4d372VoIXNW3gkxxh9gaRzcSyzQsY= Received: from mail.paulo.ac ([127.0.0.1]) by localhost (ip-172-31-5-70.sa-east-1.compute.internal [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t0UawzRLTZnT; Mon, 15 Oct 2018 11:39:30 +0000 (UTC) Received: from localhost (unknown [177.97.93.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.paulo.ac (Postfix) with ESMTPSA id 17556484CF19; Mon, 15 Oct 2018 11:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=paulo.ac; s=default; t=1539603570; bh=BfTMLG4pxYFEwhrNJkKifaSVdZltXXQgwQwys853F8k=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=mAM23Kc9CbyPYBkYnr1nvBa2mnvYc0I68ppUu6zkB1up0Lktd6b7U0U3owJyd8C0e h8t3ZjrpWYAUG+eDFnXnhxxge1k8FsUQOheddAPnIdaFzlc4MSlFYS9MtaJ+aw3KgP YdHnXWvxGOTghnLkPxV5vfJ/AH/sDS0ngzSvYOg8= From: Paulo Alcantara To: Hao Wu , edk2-devel@lists.01.org Cc: Hao Wu , Ruiyu Ni , Star Zeng In-Reply-To: <20181015045522.18732-1-hao.a.wu@intel.com> References: <20181015045522.18732-1-hao.a.wu@intel.com> Date: Mon, 15 Oct 2018 08:39:21 -0300 Message-ID: <87sh17moba.fsf@paulo.ac> MIME-Version: 1.0 Subject: Re: [PATCH v1 0/7] Code refinements in UdfDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 11:39:34 -0000 Content-Type: text/plain Hi, Hao Wu writes: > This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe > for: > > A. Refine asserts used for memory allocation failure and error cases that > are possible to happen. Will use error handling logic for them; > > B. Address some dead codes within this module. > > Cc: Paulo Alcantara > Cc: Ruiyu Ni > Cc: Star Zeng > > Hao Wu (7): > MdeModulePkg/UdfDxe: Use error handling for memory allocation failure > MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref > MdeModulePkg/UdfDxe: Use error handling when fail to return LSN > MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen() > MdeModulePkg/UdfDxe: Handle dead codes in File.c > MdeModulePkg/UdfDxe: Remove dead codes in FileName.c > MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c > > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 19 ++- > MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 15 -- > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 162 +++++++++++++++----- > 3 files changed, 142 insertions(+), 54 deletions(-) Looks good to me. Thanks! For the series: Reviewed-by: Paulo Alcantara Paulo