From: "Arun K" <arunk@ami.com>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 3/3] IpmiFeaturePkg: refine GetSelfTest function
Date: Thu, 09 Mar 2023 04:01:31 -0800 [thread overview]
Message-ID: <8800.1678363291792293164@groups.io> (raw)
In-Reply-To: <20230308231845.10895-4-mike.maslenkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
We are not updating the BMC status in the switch()( *default case* ), which may lead to installing the IPMI protocol for the failure case too. Could you please initialize the BMC status in the default case also?
switch ( SelfTestResult->Result ) {
case IPMI_APP_SELFTEST_NO_ERROR:
case IPMI_APP_SELFTEST_NOT_IMPLEMENTED:
.......
.....
...
case IPMI_APP_SELFTEST_ERROR:
.......
.....
...
case IPMI_APP_SELFTEST_FATAL_HW_ERROR:
.......
.....
...
*default:*
IpmiInstance->BmcStatus = BMC_HARDFAIL;
//
// Call routine to check device specific failures.
//
GetDeviceSpecificTestResults (IpmiInstance);
}
Thanks,
Arun
[-- Attachment #2: Type: text/html, Size: 2453 bytes --]
next prev parent reply other threads:[~2023-03-09 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 23:18 [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response Mike Maslenkin
2023-03-08 23:18 ` [PATCH edk2-platforms v2 1/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response parsing Mike Maslenkin
2023-03-08 23:18 ` [PATCH edk2-platforms v2 2/3] IpmiFeaturePkg: remove buffer temporary buffer from BMC instance structure Mike Maslenkin
2023-03-08 23:18 ` [PATCH edk2-platforms v2 3/3] IpmiFeaturePkg: refine GetSelfTest function Mike Maslenkin
2023-03-09 12:01 ` Arun K [this message]
2023-03-09 2:43 ` [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response Isaac Oram
2023-03-09 3:00 ` Isaac Oram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8800.1678363291792293164@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox