From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 3/3] IpmiFeaturePkg: refine GetSelfTest function
To: Mike Maslenkin <mike.maslenkin@gmail.com>,devel@edk2.groups.io
From: "Arun K" <arunk@ami.com>
X-Originating-Location: Chennai, Tamil Nadu, IN (157.49.243.247)
X-Originating-Platform: Windows Chrome 110
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Thu, 09 Mar 2023 04:01:31 -0800
References: <20230308231845.10895-4-mike.maslenkin@gmail.com>
In-Reply-To: <20230308231845.10895-4-mike.maslenkin@gmail.com>
Message-ID: <8800.1678363291792293164@groups.io>
Content-Type: multipart/alternative; boundary="oZBTSfiGMWa7ggNbnok5"

--oZBTSfiGMWa7ggNbnok5
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

We are not updating the BMC status in the switch()( *default case* ), which=
 may lead to installing the IPMI protocol for the failure case too. Could y=
ou please initialize the BMC status in the default case also?

switch ( SelfTestResult->Result ) {

case IPMI_APP_SELFTEST_NO_ERROR:

case IPMI_APP_SELFTEST_NOT_IMPLEMENTED:

.......
.....
...

case IPMI_APP_SELFTEST_ERROR:

.......
.....
...

case IPMI_APP_SELFTEST_FATAL_HW_ERROR:

.......
.....
...

*default:*

IpmiInstance->BmcStatus =3D BMC_HARDFAIL;

//

// Call routine to check device specific failures.

//

GetDeviceSpecificTestResults (IpmiInstance);

}

Thanks,
Arun

--oZBTSfiGMWa7ggNbnok5
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<span style=3D"font-size: 12.0pt; mso-fareast-font-family: &#39;Times New R=
oman&#39;;">We are not updating the BMC status in the switch()(</span><stro=
ng><span style=3D"font-size: 12.0pt; mso-fareast-font-family: &#39;Times Ne=
w Roman&#39;; color: #0d0d0d;">default case</span></strong><span style=3D"f=
ont-size: 12.0pt; mso-fareast-font-family: &#39;Times New Roman&#39;;">), w=
hich may lead to installing the IPMI protocol for the failure case too. Cou=
ld you please initialize the BMC status in the default case also?<br/><br/>=
</span><br/>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0switch (</em><span style=3D"white-space: pre-wrap;">SelfTestResult-&g=
t;Result</span><em>) {</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 case IPMI_APP_SELFTEST_NO_ERROR:</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 case IPMI_APP_SELFTEST_NOT_IMPLEMENTED:</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;">=C2=A0 =C2=A0 =C2=A0 .=
......<br/>=C2=A0 =C2=A0 =C2=A0 .....<br/>=C2=A0 =C2=A0 =C2=A0 ...</p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 case IPMI_APP_SELFTEST_ERROR:</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;">=C2=A0 =C2=A0 =C2=A0 .=
......<br/>=C2=A0 =C2=A0 =C2=A0 .....<br/>=C2=A0 =C2=A0 =C2=A0 ...</p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 case IPMI_APP_SELFTEST_FATAL_HW_ERROR:</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;">=C2=A0 =C2=A0 =C2=A0 .=
......<br/>=C2=A0 =C2=A0 =C2=A0 .....<br/>=C2=A0 =C2=A0 =C2=A0 ...</p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 <strong>default:</strong></em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0<span style=3D"background: yellow; mso-=
highlight: yellow;">IpmiInstance-&gt;BmcStatus =3D BMC_HARDFAIL;=C2=A0</spa=
n></em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 //</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 // Call routine to check device specific failures.=
</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 //</em></p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 GetDeviceSpecificTestResults (IpmiInstance);</em><=
/p>
<p class=3D"DefangedMsoNormal" style=3D"margin:0px;"><em>=C2=A0=C2=A0=C2=A0=
 }<br/><br/>Thanks,<br/>Arun</em></p>

--oZBTSfiGMWa7ggNbnok5--