From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.75]) by mx.groups.io with SMTP id smtpd.web12.29556.1658161606891570240 for ; Mon, 18 Jul 2022 09:26:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=h4s/PnTb; spf=pass (domain: arm.com, ip: 40.107.1.75, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ggDJiGNhDJ9K2QBR2bHTx4qSjVkRMtYQDsNr8FgOkPvbuANkN8/SkBo0sAQb7S3QYpfY4tXyjStSg91D2Y3pJiLK+XDpRSUSMtroLbEDi269yf77mEzPcQg+NZCaTUm6EHNdCL9IpvZEGCPveuDWT1qWsYJsd30sX88uFt9QJ4bAMoi/zgCUpTKjzAsoueIAU47bpwkRRyLhwvDVo6ObnTiOPMWAocCCuvlUrI0qU5IWeDI9db0L45L4BntfgB0lHJRYfK1UG/e3uxh6Vfq/3I+iufyfdUAjAuaE0ihns9Oppv1kdSc6NVO1AY+sBlbpar970jJjqUZzwxsO3XSEbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kb98JTEAIQ61VwXHUvF7DULe6Rg6LFJqWtkS04s5+5g=; b=O9OZaAptO7+K9Dluy9bltaLWpruthoHj7/9LHvwNKYTXNmjCgYaItYTN97xC2tqtUUpKPxfcUOQezkQs2J4N1T9q0lhMNRJvYBbAV5QdNI1/rkowqh3hRKTU1bgi8b7jR+mgR0gi0955EcNMLQwoCxIWzDQ5pBznbgF4uv8fPAggxuBq1VgauYuvoG7ufS1FTJxhVXiMg3taDWzaPamfsAZhhntLDYmd1ef/6uA5lpRD/EPAUuVPHkHf33JMuM4x+CBz6Wx0qTgIdmXaSdUxKxnGAAhkmLa/Yp8KYL0gLWZ0lVmZhaIVjlJymoSGe3kD+2cWZph7LwxygxK1N8qtAw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kb98JTEAIQ61VwXHUvF7DULe6Rg6LFJqWtkS04s5+5g=; b=h4s/PnTbWCjjyVlwNPHooy3PPipjhCjq6Iug+WcHCNbvMaOcxda1ucVwdNq+fFiVSr4XhgnetfVw5LCRk0OxO6tbkDKfIL/nRmYVUCna555/S/gjlguPPtkPG3Lul2WZ/2MbxFTy7zdOmaaaRkzm5z+0f7N4/qqgO+64g21ycGU= Received: from AS4P189CA0007.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::18) by AM0PR08MB5281.eurprd08.prod.outlook.com (2603:10a6:208:124::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 16:26:43 +0000 Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d7:cafe::79) by AS4P189CA0007.outlook.office365.com (2603:10a6:20b:5d7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17 via Frontend Transport; Mon, 18 Jul 2022 16:26:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 16:26:43 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Mon, 18 Jul 2022 16:26:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8a568b43703e1929 X-CR-MTA-TID: 64aa7808 Received: from e55ac8fb621c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F0A3C7F-57B3-4195-B22A-49817C7F4F3A.1; Mon, 18 Jul 2022 16:26:36 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e55ac8fb621c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 16:26:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=joVy5sgYrd2uk/aKWeQZNIiMF+pImoRRgse7mB0HlPyLzJ6yURqbBnETJOm7NMqzvNTK5sklgXmWQbt6eAgkHmNNOCqRli+OMsd8SR7M8ckspfdHk49NE8DWL/HmY90M1fUlhHyl91ILgX8RbmkF30ANViqQYtS4gYjbx5l7G/VTTwHUsKLzJGsup7rpWxqVtuVFjeTjCN+ja4zbBHVBNLjvMV/1SGnqn6ZFo+qtVEPTRpXAAkpa1uMhlX8HS+rsReOxOfXgEStQ7SH1wt1o6WKDl3OuNodbeh14YUjLWuOmzBv9qMpWTaVoeQD+JC9jDV+yeuNxE6M4d5REdAJSyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kb98JTEAIQ61VwXHUvF7DULe6Rg6LFJqWtkS04s5+5g=; b=AnGAIBsTmIbbsyxzBlz+fgq/lNcdNCtob3ivYTQH+ZFMs20fKVt/9swBvZLoAeKwym13MR00JT7THIhicKrcT4fjEZ4WE2hUrS89c199CIIkG2ZGCoFZGv5PMR1RQiawj1dC1hiL4GGg3msEw7AL0SbB9b0qaBp5Hu0O8ryFTzVHsyHKVKwMFHvHEc6iBBA4cMZjL92i4Vz7Gwl1Oq2ptA8KHYCUECss/+H/6rJ5W4l2xopIzGyB8EMfUdDjDBERMabSQ5e8ldfnG9kL/Y6fVGYgMdX9MlD8E5+GwiJy3wBdix5YRXgugGfOJvAKFs3QbRLuzpEmRs1DqknkzpIvCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kb98JTEAIQ61VwXHUvF7DULe6Rg6LFJqWtkS04s5+5g=; b=h4s/PnTbWCjjyVlwNPHooy3PPipjhCjq6Iug+WcHCNbvMaOcxda1ucVwdNq+fFiVSr4XhgnetfVw5LCRk0OxO6tbkDKfIL/nRmYVUCna555/S/gjlguPPtkPG3Lul2WZ/2MbxFTy7zdOmaaaRkzm5z+0f7N4/qqgO+64g21ycGU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by VE1PR08MB4735.eurprd08.prod.outlook.com (2603:10a6:802:a2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 16:26:30 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 16:26:30 +0000 Message-ID: <881e23ea-b452-b90c-0ec6-9cac0235b44b@arm.com> Date: Mon, 18 Jul 2022 17:26:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 1/1] DynamicTables: Fix DT PCI interrupt flags parsing To: Pierre.Gondois@arm.com, devel@edk2.groups.io, nd@arm.com References: <20220427144931.400413-1-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20220427144931.400413-1-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0680.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 2589806e-b078-45e2-67a3-08da68da4d0b X-MS-TrafficTypeDiagnostic: VE1PR08MB4735:EE_|VE1EUR03FT004:EE_|AM0PR08MB5281:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SJIsa5YlmdqbEApCbpZURQB3Vd46n5yjzFfdrMPRn9KeBFV+m91mNKq9ytYCwZ8NKqHgwvi/5ihbeAh2tFbHS6SHfcQkVMZkr+Y5Qsa5xiD9SgX58uSDmd/FkUk2Fbl9k5Fv7cE+n/M4hR8AVpWH6sCi3COIQcnUBMQi+ku/nMGRo+7O1q6cl9GjUDYpp1iXVoOk2WnN2AFLUHQ5pv1TCXh598ZiBaFaa98AML7wKuIPC0AI3s2KgNyvbNA88+4W4O4LcLzYseM2n2oaYyAiEJicQuMWwBTPtOfreRxaQUtGIawlk5p6uAxdXfSeDCEfYddXbLik0O6/L2Gy+s+ScgGkmmMylzAXSNHrXO8r2vLkLPmdrwBZ1p8npWSSDAXzJbcJT+ed5U9PJxrCjg6QSxGoA8WbCJ/mWU4M1ofqjKhs2s1iDAMo0LfgXYp9BjMFn/WKaQ/RZ/aK3CAj895kZjNppyyP6Qc30DLkY3rEjiGLcwqzUGbcs02Wag3/t+sM8QztuMZr7VtOxJNZUlHs2lttDvJpee+qwqbRA1Yir3mN9y8Snj9Wrl4rueYW2z4VBqNPCELzhPcqFhFsUeyXPwfjw9VGGm9iP6AAxaNzq5SbZIt36qZ71+A3I4W/8bQ34eIG4fh+PzR9nt0TGMdwd2pbU4KakiaotxOmrJy1RuNKwc5qnTrII6y+8ph/2DiRzC6HR7HXmKDpPrCZtwzygCgROWZiuZQAydt1ommtG7ay+P4mu6JeBtlkHqynS/DU3ipSzOknF/ewJWaxeceaTaf82w46IxxJiZhJ8E78tE3x2yZg09kfeQ8zr1V6euhtno1ZHpUNXLWJqRxdr8k1zTiGNEz2Gsy8mn7uctedEmU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(366004)(39860400002)(376002)(136003)(41300700001)(26005)(6512007)(6506007)(38100700002)(2906002)(53546011)(83380400001)(5660300002)(186003)(6666004)(66556008)(6486002)(316002)(8936002)(478600001)(31686004)(86362001)(8676002)(66946007)(66476007)(36756003)(31696002)(44832011)(2616005)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4735 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 05623d66-1e89-42ec-7e0c-08da68da4551 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tyds8lWrqR47FFRITk+6somBroNzhE+8WYCoTMT5uqSf/MhfpschJr7SskANNnDZvs7W4FuO+EPSq/0NRmoo8iAs+XsTRcmzM62dOULaBoQZ/8W4HufGE1mr8Bzvbu0MvRKSyaBn7B1z+JfV41NWHFQ7sHfZJsYF7U1wyPlE3oTRaUv88eRdxrX40CTPAX+xRcxam8UOP6Gcabr+u+lWfIO3piXxrdgd01u7AqzuGegbXe5pnnOuuZsAb8JCsdLIRxU+e0szujwUNlcmA3lrrCkSOdnVnZtiDcUmSyMeG81EfgJj/SibL4fGuvsQ1kHJADDVdVGdDA7BISeDadMR4PqZL0tH3CDb/RY7XDfUToSfUybno+Ye7hIqtNZjNNjh5A3u9Z9Hzo16FmS/+Z3XCvyGc2xOpjmiyptxctdfECnVR4UibqPSFrt4Zq6y2sR538ZxrvnhwJR3TjmkjmVXs5UxottRrSHhaAn8dBwEqhiLF+po17Q20E8Yb19FvWjgS1opEubYFnfoN1AdRVoNgyQ8jS0/8BuQH98H4gGtDByiZVSPHIrRHuzmbVWaGULfUaeIm87CcR84YF4RPu7u7UIIAfebH+Xsd42j0DVOU++0OA8EbhIwPAIuQrhwjyCUKhGDe28OImkkQLTaWK9jyT1DuOGmxWbyF2qPfT+/W3wJNhMVWOhb/UhDBLjO6dRMqkHwuewzT5IgKnquTGUBfJl3dAA20gVw3T2dEeYxjCshUjtrF5w7LtwIBcd5JsIrEt5/9DeOiNcmyznkzuP5HvnS7PdgbLAX34UJaKxX7tiZ+DeFWVcKrEiuJ+bchrzmQq3XodOmNQzPhkkak4Xu/7Pri0Zzjmj+byW1AxE/gjc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(376002)(39860400002)(40470700004)(46966006)(36840700001)(6666004)(2616005)(186003)(31686004)(26005)(83380400001)(41300700001)(44832011)(6486002)(5660300002)(336012)(2906002)(86362001)(40480700001)(36860700001)(478600001)(6512007)(47076005)(82310400005)(81166007)(31696002)(70586007)(70206006)(8676002)(8936002)(6636002)(356005)(82740400003)(40460700003)(36756003)(6506007)(316002)(53546011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 16:26:43.0007 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2589806e-b078-45e2-67a3-08da68da4d0b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5281 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Pushed as 039bdb4d3e96..fc4a132c0e9d Regards, Sami Mujawar On 27/04/2022 03:49 pm, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Device Tree PCI interrupt flags use the convention described at > linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml > > The 3rd cell is the flags, encoded as follows: > bits[3:0] trigger type and level flags. > 1 =3D low-to-high edge triggered > 2 =3D high-to-low edge triggered (invalid for SPIs) > 4 =3D active high level-sensitive > 8 =3D active low level-sensitive (invalid for SPIs). > > Fix the incorrect code. > > Signed-off-by: Pierre Gondois > --- > .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 2 +- > DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= eGenerator.c > index a34018151f2d..d5b1c153e98f 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= tor.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= tor.c > @@ -449,7 +449,7 @@ GeneratePrt ( > if ((Index > 0) && > (IrqMapInfo->IntcInterrupt.Interrupt >=3D 32) && > (IrqMapInfo->IntcInterrupt.Interrupt < 1020) && > - ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D BIT0)) > + ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D 0)) > { > Status =3D EFI_INVALID_PARAMETER; > ASSERT_EFI_ERROR (Status); > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h b/D= ynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h > index f2f425632b10..3f5d131d9ae5 100644 > --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h > +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h > @@ -60,7 +60,7 @@ > #define SPI_OFFSET (32U) > #define DT_PPI_IRQ (1U) > #define DT_SPI_IRQ (0U) > -#define DT_IRQ_IS_EDGE_TRIGGERED(x) ((((x) & (BIT0 | BIT2)) !=3D 0)) > +#define DT_IRQ_IS_EDGE_TRIGGERED(x) ((((x) & (BIT0 | BIT1)) !=3D 0)) > #define DT_IRQ_IS_ACTIVE_LOW(x) ((((x) & (BIT1 | BIT3)) !=3D 0)) > #define IRQ_TYPE_OFFSET (0U) > #define IRQ_NUMBER_OFFSET (1U) IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.