From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D032481EB1 for ; Thu, 24 Nov 2016 00:51:31 -0800 (PST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D71A8E24B; Thu, 24 Nov 2016 08:51:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-81.phx2.redhat.com [10.3.116.81]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAO8pTvt020464; Thu, 24 Nov 2016 03:51:30 -0500 To: Konrad Rzeszutek Wilk , edk2-devel@ml01.01.org References: <0846b3b6-ef4b-df3a-d516-28995215e1af@redhat.com> <20161124011523.18281-1-konrad@kernel.org> <20161124011523.18281-2-konrad@kernel.org> Cc: xen-devel@lists.xenproject.org From: Laszlo Ersek Message-ID: <88418d23-0b21-1411-8a26-aa1b5e4164e3@redhat.com> Date: Thu, 24 Nov 2016 09:51:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161124011523.18281-2-konrad@kernel.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 24 Nov 2016 08:51:31 +0000 (UTC) Subject: Re: [PATCH v3] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 08:51:31 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/24/16 02:15, Konrad Rzeszutek Wilk wrote: > v2: > * Changes suggested by Laszlo: > - change the catch-all (*) to GCC5, from GCC44 > - remove the (5.*.*) pattern from GCC49 > - generate error for GCC < 4.4 > > In v3, also generate error for really GCC < 4.4, like GCC 1. > > Reviewed-by: Laszlo Ersek > Reviewed-by: Jordan Justen > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Konrad Rzeszutek Wilk > --- > v1: Initial > v2: Redo it per Laszlo suggestions > v3: Fix up commit message per Jordan > Also generate error for prehistoric versions of GCC, like 1. > --- > OvmfPkg/build.sh | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index eb5eb73..95fe8fb 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -83,6 +83,13 @@ case `uname` in > Linux*) > gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') > case $gcc_version in > + [1-3].*|4.[0-3].*) > + echo OvmfPkg requires GCC4.4 or later > + exit 1 > + ;; > + 4.4.*) > + TARGET_TOOLS=GCC44 > + ;; > 4.5.*) > TARGET_TOOLS=GCC45 > ;; > @@ -95,11 +102,11 @@ case `uname` in > 4.8.*) > TARGET_TOOLS=GCC48 > ;; > - 4.9.*|4.1[0-9].*|5.*.*) > + 4.9.*) > TARGET_TOOLS=GCC49 > ;; > *) > - TARGET_TOOLS=GCC44 > + TARGET_TOOLS=GCC5 > ;; > esac > esac > Tested-by: Laszlo Ersek (With gcc-4.8.) Pushed as commit 2667ad40919a. Thank you! Laszlo