From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web11.1675.1580857385855360254 for ; Tue, 04 Feb 2020 15:03:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=EZJObT04; spf=none, err=SPF record not found (domain: amd.com, ip: , mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jvUMO5+h3BH153NaZquq6f8igYA48oeXOUMNgIbgGmr9DixYVCgT3moJWxokg7CfhCYAAVvcflZjr0+sSkFyNAYMId7gWYl5ofzWatb0IIi66VY9854wMSPY7qPbXsi5yHNBA7EMkk6AFpmAvFtdvwZQbZKTY+PcsRlarbu5hrwWWeNvcVshUViSZVtp1S04SmKfsLUT+6YYoNpiscnHWNSYhZxmKrF8LmuRtT3ZNtM4RhUlHIdSlBke+O+ziMAOWLs4t+5dHSWehHMqoI9RE/ZUh0r1JvN8Wd3TbrZrIgrq1CpXB8VrjTvrm+jEEo0wWQxoSttG9Q+s7xBTXz6Z2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGS8EU+cWS2ozHJvHVfFgMED5b6m7aBtoRsPGIbY+A4=; b=lFVDdYUvpdek1SYkBz0oix4jI0m6xChpT1OYwZ5tD3VleYOeR8zB9pilztM/6/vYFK47GjIFko7H4rM1XEm9uHKuBTCPt2JUnp2PfgToKnjOE+Q8n3B9fixBmHLl0MXdYxNhI95NU0RsKwTiBuixgtZghBBcEo7kefnciZaY7zBO1+TIN0DX9c15hMWI5572/5RWaiiiQaltkH+3roTvUdoWjEI4x+QqH2lsmLqMchtO50MK6acTAnXpYJPSjBokYTw4bsUw5c4nr5UJVBv7z+osTdRJqGm3VWK37w667OPETGEnbcq5AEx5LbgJjUyJ2F4LmNRDGnrqQLVbUx0j4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGS8EU+cWS2ozHJvHVfFgMED5b6m7aBtoRsPGIbY+A4=; b=EZJObT04y/GAf74oGreYgluq3Hi6EVJjwcFqN7IGLiFeLwJVYL5BrHDLNcHQ4Rffkg5NqHQh7/QiEVnx5ruz9YP7WWkvT44lnjQn+gtEx/tzBzOfyYAVuZzrln98K7Lg7DIh/gEoQHz1nkbXLfnTToBjeNI+ehikRqxux04j5ro= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from DM6PR12MB3163.namprd12.prod.outlook.com (20.179.71.154) by DM6PR12MB3930.namprd12.prod.outlook.com (10.255.174.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Tue, 4 Feb 2020 23:03:07 +0000 Received: from DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::a0cd:463:f444:c270]) by DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::a0cd:463:f444:c270%7]) with mapi id 15.20.2707.020; Tue, 4 Feb 2020 23:03:07 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh Subject: [PATCH v4 35/40] UefiCpuPkg: Add a 16-bit protected mode code segment descriptor Date: Tue, 4 Feb 2020 17:01:39 -0600 Message-Id: <88431f5fc55a0083acddf8e6936c7d2ba4c9e3d8.1580857303.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-ClientProxiedBy: SN6PR16CA0062.namprd16.prod.outlook.com (2603:10b6:805:ca::39) To DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 Received: from tlendack-t1.amd.com (165.204.77.1) by SN6PR16CA0062.namprd16.prod.outlook.com (2603:10b6:805:ca::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.32 via Frontend Transport; Tue, 4 Feb 2020 23:02:39 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 389e4810-9240-413c-3a46-08d7a9c65561 X-MS-TrafficTypeDiagnostic: DM6PR12MB3930:|DM6PR12MB3930: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-Forefront-PRVS: 03030B9493 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(366004)(376002)(136003)(396003)(346002)(199004)(189003)(4326008)(478600001)(6916009)(81156014)(2616005)(956004)(81166006)(8676002)(966005)(316002)(54906003)(2906002)(6486002)(66476007)(66556008)(52116002)(7696005)(186003)(26005)(16526019)(5660300002)(86362001)(36756003)(66946007)(8936002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB3930;H:DM6PR12MB3163.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nWY/awviqtWBSKznjTsPLqoT/ac0nNcjPLPI9xUmpp0gjHr1kUSO0XW6TY8hH4GW8nEN2w3sf5eFCMhNrdLyTq6zVpGqNpZOvGR8n+gU+D1NmUMDtyMHfK3cS5SA8xSSEotTfFAk/sVNcLyW2L5wtQ2kbVIFlMzTcg0Cv34Hbj5ABMYSxXDsHqxLDY+4P+uoXgB2VvKCH+RBqxaXZ8y6R/LWINpE1T+6yu+v9WrMDBDjgc0O7+Zg2S5fKzCsGGcrlWbZnjgmWy2ZoyQjZ2xK/tDlexVOkpuNd8LwlsF/sh3KU1yn2a/3YK09+lEF3smF1LVuJ2Uceuixj/sz5efM7pPXrvDssWcVDjqnRQr6giUAaxE6wnoltAG6pqjdfLIQ9RuzGZVrviNblSy3hxXdwTtUXS33YCN9wAy/nZbC4K8HGKRvXVxftGo5rZu6+0kCCTRXazIsQTYnWdu+LDaucis3D/OPUYflCJ5BLLcnhBgCV6zq99i2Q2DfSYsQtF5W7kUd4fuxxn1sk10t4zjNPw== X-MS-Exchange-AntiSpam-MessageData: 58iKq27ESR5INULITb0bhzlmxD+D1kkpEapeMiK9B+6ZPu8/56YUK16aHtDkcLwdpzVw6IdWyL6mEBE3Mt+nD/fpXfKUez6GgJMwVfe+L6ejkm/Tn2nDhLlgXXeCs5HiOttDLqAYpEIMHfLZpwhU1w== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 389e4810-9240-413c-3a46-08d7a9c65561 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2020 23:02:39.9797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: igUZ4fIdvvS2KkcakhTJbkCgT8zUYo5iLPIOXPa1nDGHDaWLHXIO2sXM9ZHio3f2vn1vm1yRauA6i/+0L2I+kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3930 Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A hypervisor is not allowed to update an SEV-ES guests register state, so when booting an SEV-ES guest AP, the hypervisor is not allowed to set the RIP to the guest requested value. Instead, an SEV-ES AP must be transition from 64-bit long mode to 16-bit real mode in response to an INIT-SIPI-SIPI sequence. This requires a 16-bit code segment descriptor. For PEI, create this descriptor in the reset vector GDT table. For DXE, create this descriptor from the newly reserved entry at location 0x28. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- UefiCpuPkg/CpuDxe/CpuGdt.h | 4 ++-- UefiCpuPkg/CpuDxe/CpuGdt.c | 8 ++++---- UefiCpuPkg/ResetVector/Vtf0/Ia16/Real16ToFlat32.asm | 9 +++++++++ 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.h b/UefiCpuPkg/CpuDxe/CpuGdt.h index e5c36f37b96a..80e224b47fcd 100644 --- a/UefiCpuPkg/CpuDxe/CpuGdt.h +++ b/UefiCpuPkg/CpuDxe/CpuGdt.h @@ -36,7 +36,7 @@ struct _GDT_ENTRIES { GDT_ENTRY LinearCode; GDT_ENTRY SysData; GDT_ENTRY SysCode; - GDT_ENTRY Spare4; + GDT_ENTRY SysCode16; GDT_ENTRY LinearData64; GDT_ENTRY LinearCode64; GDT_ENTRY Spare5; @@ -49,7 +49,7 @@ struct _GDT_ENTRIES { #define LINEAR_CODE_SEL OFFSET_OF (GDT_ENTRIES, LinearCode) #define SYS_DATA_SEL OFFSET_OF (GDT_ENTRIES, SysData) #define SYS_CODE_SEL OFFSET_OF (GDT_ENTRIES, SysCode) -#define SPARE4_SEL OFFSET_OF (GDT_ENTRIES, Spare4) +#define SYS_CODE16_SEL OFFSET_OF (GDT_ENTRIES, SysCode16) #define LINEAR_DATA64_SEL OFFSET_OF (GDT_ENTRIES, LinearData64) #define LINEAR_CODE64_SEL OFFSET_OF (GDT_ENTRIES, LinearCode64) #define SPARE5_SEL OFFSET_OF (GDT_ENTRIES, Spare5) diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c b/UefiCpuPkg/CpuDxe/CpuGdt.c index 87fd6955f24b..6a80829be884 100644 --- a/UefiCpuPkg/CpuDxe/CpuGdt.c +++ b/UefiCpuPkg/CpuDxe/CpuGdt.c @@ -70,14 +70,14 @@ STATIC GDT_ENTRIES GdtTemplate = { 0x0, }, // - // SPARE4_SEL + // SYS_CODE16_SEL // { - 0x0, // limit 15:0 + 0x0FFFF, // limit 15:0 0x0, // base 15:0 0x0, // base 23:16 - 0x0, // type - 0x0, // limit 19:16, flags + 0x09A, // present, ring 0, code, execute/read + 0x08F, // page-granular, 16-bit 0x0, // base 31:24 }, // diff --git a/UefiCpuPkg/ResetVector/Vtf0/Ia16/Real16ToFlat32.asm b/UefiCpuPkg/ResetVector/Vtf0/Ia16/Real16ToFlat32.asm index ce4ebfffb688..0e79a3984b16 100644 --- a/UefiCpuPkg/ResetVector/Vtf0/Ia16/Real16ToFlat32.asm +++ b/UefiCpuPkg/ResetVector/Vtf0/Ia16/Real16ToFlat32.asm @@ -129,5 +129,14 @@ LINEAR_CODE64_SEL equ $-GDT_BASE DB 0 ; base 31:24 %endif +; linear code segment descriptor +LINEAR_CODE16_SEL equ $-GDT_BASE + DW 0xffff ; limit 15:0 + DW 0 ; base 15:0 + DB 0 ; base 23:16 + DB PRESENT_FLAG(1)|DPL(0)|SYSTEM_FLAG(1)|DESC_TYPE(CODE32_TYPE) + DB GRANULARITY_FLAG(1)|DEFAULT_SIZE32(0)|CODE64_FLAG(0)|UPPER_LIMIT(0xf) + DB 0 ; base 31:24 + GDT_END: -- 2.17.1