From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 48624AC182F for ; Thu, 26 Oct 2023 15:45:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UNP7WzdCDArlMfLWj4gm7+/cCXnfnpx2TKIFT2gcmNw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698335126; v=1; b=HIaIIBmBM74qDkYjV7Vgp+jgWEM+ugHVZx3gcGCaikEjVqQBojBB5erld4dvNJLfEAc2QFys CXIF/TYK42eqG1tHfynnnXK5++N7MyNME7+tdRRm+AxrBNEpQ21Rm4rcX/8eg6QMQAa/NExDUpn I2yH0ruupa+15E441c8KOBws= X-Received: by 127.0.0.2 with SMTP id qm5XYY7687511xfs0i0v8wWq; Thu, 26 Oct 2023 08:45:26 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.74297.1698335125330559447 for ; Thu, 26 Oct 2023 08:45:25 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-170-EWa5RmFONTC_hyUP9Mgr1g-1; Thu, 26 Oct 2023 11:45:22 -0400 X-MC-Unique: EWa5RmFONTC_hyUP9Mgr1g-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 747B0185A780; Thu, 26 Oct 2023 15:45:21 +0000 (UTC) X-Received: from [10.39.192.119] (unknown [10.39.192.119]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95B36C1596D; Thu, 26 Oct 2023 15:45:20 +0000 (UTC) Message-ID: <88608560-f626-521a-f7b3-62035d6e728a@redhat.com> Date: Thu, 26 Oct 2023 17:45:19 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard To: devel@edk2.groups.io, n.jayaprakash@intel.com Cc: Rebecca Cran , Michael D Kinney , Kloper Dimitry References: <20231026141716.823-1-n.jayaprakash@intel.com> <20231026141716.823-2-n.jayaprakash@intel.com> From: "Laszlo Ersek" In-Reply-To: <20231026141716.823-2-n.jayaprakash@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cqEgtKMKdsgS1bl6dp5exZsQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HIaIIBmB; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/26/23 16:17, Jayaprakash, N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4574 >=20 > This commit is for processing the below PR on edk2-libc repo > https://github.com/tianocore/edk2-libc/pull/10 > The realpath function signature in stdlib of edk2-libc doesn't match > signature as per the standard definition of this function given below > https://pubs.opengroup.org/onlinepubs/009695399/functions/realpath.html > This patch extracted from the above pull request fixes this issue. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Kloper Dimitry > --- > StdLib/Include/stdlib.h | 4 ++-- > StdLib/LibC/StdLib/realpath.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h > index 0b9dfd3..022ddbd 100644 > --- a/StdLib/Include/stdlib.h > +++ b/StdLib/Include/stdlib.h > @@ -74,7 +74,7 @@ > const wchar_t * __restrict src, size_t limit)= ; > =20 > ################ Miscelaneous functions for *nix compatibility > - char *realpath (char *file_name, char *resolved_name); > + char *realpath (const char *file_name, char *resolved_name)= ; > const char *getprogname (void); > void setprogname (const char *progname); > =20 > @@ -875,7 +875,7 @@ size_t wcstombs(char * __restrict Dest, const wchar_= t * __restrict Src, size_t > @retval NULL An error occured. > @retval resolved_name. > **/ > -char * realpath(char *file_name, char *resolved_name); > +char * realpath(const char *file_name, char *resolved_name); > =20 > /** The getprogname() function returns the name of the program. If the = name > has not been set yet, it will return NULL. > diff --git a/StdLib/LibC/StdLib/realpath.c b/StdLib/LibC/StdLib/realpath.= c > index 3d4118d..29abe9a 100644 > --- a/StdLib/LibC/StdLib/realpath.c > +++ b/StdLib/LibC/StdLib/realpath.c > @@ -34,7 +34,7 @@ > **/ > char * > realpath( > - char *file_name, > + const char *file_name, > char *resolved_name > ) > { Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110124): https://edk2.groups.io/g/devel/message/110124 Mute This Topic: https://groups.io/mt/102200532/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-