public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 0/1] BaseTools: remove unused variable
@ 2018-03-08  0:45 Jaben Carsey
  2018-03-08  0:45 ` [PATCH v1 1/1] BaseTools: GlobalData " Jaben Carsey
  0 siblings, 1 reply; 3+ messages in thread
From: Jaben Carsey @ 2018-03-08  0:45 UTC (permalink / raw)
  To: edk2-devel; +Cc: Yonghong Zhu, Liming Gao

delete a variable never uised and the comment

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>

Jaben Carsey (1):
  BaseTools: GlobalData remove unused variable

 BaseTools/Source/Python/Common/GlobalData.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.14.1.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v1 1/1] BaseTools: GlobalData remove unused variable
  2018-03-08  0:45 [PATCH v1 0/1] BaseTools: remove unused variable Jaben Carsey
@ 2018-03-08  0:45 ` Jaben Carsey
  2018-03-09  9:38   ` Zhu, Yonghong
  0 siblings, 1 reply; 3+ messages in thread
From: Jaben Carsey @ 2018-03-08  0:45 UTC (permalink / raw)
  To: edk2-devel; +Cc: Yonghong Zhu, Liming Gao

gWideStringPattern is not used.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Common/GlobalData.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/Common/GlobalData.py b/BaseTools/Source/Python/Common/GlobalData.py
index f7d4d577f994..8b36a1b77366 100644
--- a/BaseTools/Source/Python/Common/GlobalData.py
+++ b/BaseTools/Source/Python/Common/GlobalData.py
@@ -47,8 +47,7 @@ gDefaultStores = []
 gMacroRefPattern = re.compile("\$\(([A-Z][_A-Z0-9]*)\)", re.UNICODE)
 gMacroDefPattern = re.compile("^(DEFINE|EDK_GLOBAL)[ \t]+")
 gMacroNamePattern = re.compile("^[A-Z][A-Z0-9_]*$")
-# C-style wide string pattern
-gWideStringPattern = re.compile('(\W|\A)L"')
+
 #
 # A global variable for whether current build in AutoGen phase or not.
 #
-- 
2.14.1.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] BaseTools: GlobalData remove unused variable
  2018-03-08  0:45 ` [PATCH v1 1/1] BaseTools: GlobalData " Jaben Carsey
@ 2018-03-09  9:38   ` Zhu, Yonghong
  0 siblings, 0 replies; 3+ messages in thread
From: Zhu, Yonghong @ 2018-03-09  9:38 UTC (permalink / raw)
  To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Gao, Liming, Zhu, Yonghong

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: Carsey, Jaben 
Sent: Thursday, March 08, 2018 8:45 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH v1 1/1] BaseTools: GlobalData remove unused variable

gWideStringPattern is not used.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Common/GlobalData.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/Common/GlobalData.py b/BaseTools/Source/Python/Common/GlobalData.py
index f7d4d577f994..8b36a1b77366 100644
--- a/BaseTools/Source/Python/Common/GlobalData.py
+++ b/BaseTools/Source/Python/Common/GlobalData.py
@@ -47,8 +47,7 @@ gDefaultStores = []
 gMacroRefPattern = re.compile("\$\(([A-Z][_A-Z0-9]*)\)", re.UNICODE)  gMacroDefPattern = re.compile("^(DEFINE|EDK_GLOBAL)[ \t]+")  gMacroNamePattern = re.compile("^[A-Z][A-Z0-9_]*$") -# C-style wide string pattern -gWideStringPattern = re.compile('(\W|\A)L"')
+
 #
 # A global variable for whether current build in AutoGen phase or not.
 #
--
2.14.1.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-09  9:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-08  0:45 [PATCH v1 0/1] BaseTools: remove unused variable Jaben Carsey
2018-03-08  0:45 ` [PATCH v1 1/1] BaseTools: GlobalData " Jaben Carsey
2018-03-09  9:38   ` Zhu, Yonghong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox