From: "James Bottomley" <jejb@linux.ibm.com>
To: devel@edk2.groups.io, lersek@redhat.com, Guo Dong <guo.dong@intel.com>
Cc: eric.dong@intel.com, ray.ni@intel.com, rahul1.kumar@intel.com,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH V2] UefiCpuPkg/CpuDxe: Fix boot error
Date: Thu, 07 Jan 2021 14:25:17 -0800 [thread overview]
Message-ID: <88732d221e94954a910ed9e8c501b2a0e5d5338f.camel@linux.ibm.com> (raw)
In-Reply-To: <045e12bb-f4d8-1d7a-ea3a-fa7b8d09ce12@redhat.com>
On Thu, 2021-01-07 at 12:56 +0100, Laszlo Ersek wrote:
> Adding James, Mike, and Tom:
>
> On 01/07/21 04:10, Guo Dong wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3084
> >
> > When DXE drivers are dispatched above 4GB memory in 64bit
> > mode, the address setCodeSelectorLongJump in stack will
> > be override by parameter. Jump to Qword is not supported
> > by some processors. So use "o64 retf" instead.
> >
> > Signed-off-by: Guo Dong <guo.dong@intel.com>
> > ---
> > UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm
> > b/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm
> > index c3489bcc3e..a8216cd56f 100644
> > --- a/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm
> > +++ b/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm
> > @@ -20,13 +20,11 @@
> > ;-----------------------------------------------------------------
> > -------------
> > global ASM_PFX(SetCodeSelector)
> > ASM_PFX(SetCodeSelector):
> > - sub rsp, 0x10
> > + push rcx,
> > lea rax, [setCodeSelectorLongJump]
> > - mov [rsp], rax
> > - mov [rsp+4], cx
> > - jmp dword far [rsp]
> > + push rax
> > + o64 retf
> > setCodeSelectorLongJump:
> > - add rsp, 0x10
> > ret
> >
> > ;-----------------------------------------------------------------
> > -------------
> >
>
> I'm asking for:
> James Bottomley <jejb@linux.ibm.com>
> - a Reviewed-by or Tested-by from James please, and
Tested-by: James Bottomley <jejb@linux.ibm.com>
James
next prev parent reply other threads:[~2021-01-07 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 3:10 [edk2-devel] [PATCH V2] UefiCpuPkg/CpuDxe: Fix boot error Guo Dong
2021-01-07 11:56 ` Laszlo Ersek
2021-01-07 22:25 ` James Bottomley [this message]
2021-01-09 2:30 ` Ni, Ray
2021-01-07 15:01 ` Lendacky, Thomas
2021-01-07 16:14 ` Guo Dong
2021-01-07 17:32 ` Laszlo Ersek
2021-01-07 18:22 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88732d221e94954a910ed9e8c501b2a0e5d5338f.camel@linux.ibm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox