From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DFC7E7803CD for ; Wed, 15 Nov 2023 03:12:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jwF3lJLUGi4KHN7Svj5uw6aq7ZgEK4B1TPaofWPtvlk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:In-Reply-To:References:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1700017959; v=1; b=etkZAOng01lwC3fjAY5j73QSnVblwdOOGxqdhdc3SAe9iFZ/+ohaDQ95/AvuDSmDKH+1wkL0 z5dYxKCz7UICFZL8Rc6EYueNPg/4QMIteu+Q2L6dDrS1Wd5q1qNIgC8Jlzo9OPtg8Ranx/sdECE 1RMLuR2YQuZDpRO4fApyOlU8= X-Received: by 127.0.0.2 with SMTP id opzmYY7687511xZxFtvyeTtK; Tue, 14 Nov 2023 19:12:39 -0800 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.89]) by mx.groups.io with SMTP id smtpd.web10.4783.1700017958696356480 for ; Tue, 14 Nov 2023 19:12:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egaGpPTupXK6V/LQwdoo6SsGaLMU+cOxyQs+x2cQbgaNIou73+Ux2hlK90RUTp1Aqbk6m5/i0aCWk/v9bf/bCYL3eqbMDzKIkd9IPNLpb70nEji2NrxiFTorY75r/uQWkbs/RxxFBiCKrjERF5/daMDGiOqe6p/mLWwLIuK8Tk+wSfdwi+X7JJ4dSG/Oz9YNaISj5dlySFmDjgtlSXrPJ5Mp681ZqgGF/mUVywsBnBUo6K0KIxFgZi6IsLLhaAEB+H3WuGpD6MGFFhpRVu8Gl5tsWcKxZ/VjqQMK1ZKqDqkBwSu25TyEbUIwpGZkXNAk9Sz4ofJTGZM8112yGEOQow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QuXMYwxeJ3ZwvVWnm3MnO0aNCOBxMFcIy5ug9fYwfMk=; b=FoujtAILlCdHbIEON/jWoF5cb6llnREHJYYCH1jh768AV760XC74uYuKPNb/FtOMMkUL933gi2/UDoAqMlgOfGQfaf4dJ8SXh59SHjEwbMBs2+n1p7tSEUoMDbs+AZUu3MkoNXLVPG1IHgBMQI1aVFJn15X/chol8LwIlS9WAqJ4x9JPwq4EKnusfGN2fQgVuHYIVbsurCCC90OuES/vyBM91nsYs5uENugwBSQgUdPKNhCF9avuy8VYxIGfI1osNvHCbr4ghTk4Pod7ACCTvmT1XmZJ5aifCKxaZrKRRYGi4sExSA0o2R6WeLZaZZjI+EQYgefHZQJ8eXzAwqo/dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from CH0PR03CA0085.namprd03.prod.outlook.com (2603:10b6:610:cc::30) by DS0PR12MB9324.namprd12.prod.outlook.com (2603:10b6:8:1b6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 03:12:35 +0000 X-Received: from DS2PEPF0000343B.namprd02.prod.outlook.com (2603:10b6:610:cc:cafe::a6) by CH0PR03CA0085.outlook.office365.com (2603:10b6:610:cc::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17 via Frontend Transport; Wed, 15 Nov 2023 03:12:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by DS2PEPF0000343B.mail.protection.outlook.com (10.167.18.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.19 via Frontend Transport; Wed, 15 Nov 2023 03:12:35 +0000 X-Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 14 Nov 2023 19:12:26 -0800 X-Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 14 Nov 2023 19:12:25 -0800 X-Received: from ashishsingha-lnx.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Tue, 14 Nov 2023 19:12:25 -0800 From: "Ashish Singhal via groups.io" To: , , , , , CC: Ashish Singhal Subject: [edk2-devel] [PATCH v2 2/2] EmbeddedPkg: Allow longer android kernel command line Date: Tue, 14 Nov 2023 20:12:22 -0700 Message-ID: <888db180ae77070619a13ec4e6d6356a97a03176.1700008662.git.ashishsingha@nvidia.com> MIME-Version: 1.0 In-Reply-To: <3ab879ada6d9f2b01496ecc05102510564888044.1700008662.git.ashishsingha@nvidia.com> References: <3ab879ada6d9f2b01496ecc05102510564888044.1700008662.git.ashishsingha@nvidia.com> X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343B:EE_|DS0PR12MB9324:EE_ X-MS-Office365-Filtering-Correlation-Id: d7e8cf1c-1512-4ccf-9e28-08dbe588b722 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: pkCc4PZPoa5H/UnEg3VxPxwwCZpfkGreDO1iJmlOtaex31e6ETRiuS7LGtWqcq5QR/qlqj9Ku38bVRNrpxr4C2vbWyu1pzCFspCWrhSWlJR8U4u4kf5PSXIKPYJqE0GXjo2IntowvC8C1BNqj5ji4L2WyS/TleQnZ5j8Qqy9RzJkJcW9fVWWuiN6bJIkzLfHxBLXcMch4djBcjnZceETifxJa+Kx4N4UkOYxqKrFJLmaSQkGichn2zrUbCpDhl2p1c8R9z8BHUjw+YSBd7V90YcY6qnWGxim1nG6mQVD2vGAVM7uQ9CiK9bFX4KqwDSwQjoYrs6tJescvpBRRl3kNUFkd8x4cPYpvBvm2eyu+XbipSyRsJa00/8FMS9LD8Up0Wq/vZdIjfhDuGAe55a4e/NgYn76Dv86+ZJlsPvhVjh3IXT2rp8hppAgFKKbpWCVAOjKxBEUS/0JaWHXLcVUY+XX+1EgZxBnHWRzUK0usx2Ia9nG9BI9gg5UBO/PK9Tnw3YNiNWp6s6bo33fyycYm4Ud8Enb6iDM7p6+hHJ0ZjTMkkBbwVr8745xsam79yMbRsjl29w1AP3n9V3FG/ZiGgNj+u01+j69rn2c37wO2ALj9GUDajOmefhyIKL7Skc7d1PKrN02sShqW19xGA9hLPCAtSGG8MTsT2qrJ745VbbK+sEylpvztPxqr48vFixj62I7Z3hUCnWJjbvduyAaD6YGbr8xLa2Agsy3djVJkHB7L7WvOu8f9wGXX8w+8XA0eZs7+z3mEUmJXS5Rww4Z4YzkQ/gO5XSHDr9l2a8uJEg= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:12:35.2463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7e8cf1c-1512-4ccf-9e28-08dbe588b722 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9324 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mMaOnbyFmsoF4rNKOEfzIvZBx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=etkZAOng; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io AndroidBootImgLib allows for platforms to append to kernel command line but does not allow for the overall kernel command line to go beyond the limit set by the image header. Address this limitation by adding a pcd where platform can tell how many extra characters they expect on their platform in addition to what the image header specifies. Signed-off-by: Ashish Singhal --- EmbeddedPkg/EmbeddedPkg.dec | 5 +++++ EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 2 +- EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf | 3 ++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec index 341ef5e6a6..94dc3c9b76 100644 --- a/EmbeddedPkg/EmbeddedPkg.dec +++ b/EmbeddedPkg/EmbeddedPkg.dec @@ -183,3 +183,8 @@ # Selection between DT and ACPI as a default # gEmbeddedTokenSpaceGuid.PcdDefaultDtPref|TRUE|BOOLEAN|0x0000059 + + # + # Expected Overflow Android Kernel Command Line Characters + # + gEmbeddedTokenSpaceGuid.PcdAndroidKernelCommandLineOverflow|0|UINT32|0x0= 00005C diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c b/Em= beddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c index f63648e60d..d16929f2bb 100644 --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c @@ -335,7 +335,7 @@ AndroidBootImgUpdateArgs ( return Status; } =20 - NewKernelArgSize =3D ANDROID_BOOTIMG_KERNEL_ARGS_SIZE; + NewKernelArgSize =3D ANDROID_BOOTIMG_KERNEL_ARGS_SIZE + PcdGet32 (PcdAnd= roidKernelCommandLineOverflow); *KernelArgs =3D AllocateZeroPool (sizeof (CHAR16) * NewKernelArgSiz= e); if (*KernelArgs =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "Fail to allocate memory\n")); diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf b/= EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf index 8eefeef4f9..9754664df5 100644 --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf @@ -45,5 +45,6 @@ gEfiAcpiTableGuid gFdtTableGuid =20 -[FeaturePcd] +[Pcd] gEmbeddedTokenSpaceGuid.PcdAndroidBootLoadFile2 + gEmbeddedTokenSpaceGuid.PcdAndroidKernelCommandLineOverflow --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111228): https://edk2.groups.io/g/devel/message/111228 Mute This Topic: https://groups.io/mt/102598723/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-