From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 49823222630B7 for ; Thu, 22 Feb 2018 10:20:33 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3B0338182D2F; Thu, 22 Feb 2018 18:26:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-138.rdu2.redhat.com [10.10.120.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2F462026987; Thu, 22 Feb 2018 18:26:31 +0000 (UTC) To: Ard Biesheuvel , "Kinney, Michael D" Cc: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "afish@apple.com" , "Gao, Liming" , "leif.lindholm@linaro.org" , "Zeng, Star" References: <20180222162822.22703-1-ard.biesheuvel@linaro.org> <20180222162822.22703-2-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <8890e4c2-f4a8-2c93-e9b9-ac86cffec36e@redhat.com> Date: Thu, 22 Feb 2018 19:26:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 22 Feb 2018 18:26:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 22 Feb 2018 18:26:33 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH edk2-platforms v2 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 18:20:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/22/18 18:50, Ard Biesheuvel wrote: > On 22 February 2018 at 17:46, Kinney, Michael D > wrote: >> Ard, >> >> The check for the runtime flag seems inconsistent. >> >> Since the issue being addressed is use of SerialPortLib, >> can't the mEfiAtRuntime flag be use around SerialPortLib >> calls only. >> > > I take it you mean the checks around ASSERT()s? I agree that those are > redundant, since the check will occur in the ASSERT() implementation > as well. > > Will fix. I noticed that as well, comparing the C file against its counterpart in BaseDebugLibSerialPort. I thought it was harmless: DebugClearMemory() should only be called via DEBUG_CLEAR_MEMORY(), and that only occurs from MdeModulePkg/Core/Dxe/Mem, typically when memory (pool/pages) is freed, or the memmap is changed similarly (IIUC when entries are "converted"). None of those should happen at runtime; so I didn't think we'd get a call to DebugClearMemory() with mEfiAtRuntime==TRUE. Anyway I agree it's cleaner to fix that up. Thanks Laszlo