Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: use a proper PCI IO range

["Corvin Köhne" <corvink@FreeBSD.org>]

[-- Attachment #1: Type: text/plain, Size: 2619 bytes --]

On Fri, 2023-11-17 at 17:09 +0100, Laszlo Ersek wrote:
> On 11/17/23 13:43, Corvin Köhne wrote:
> > Bhyve uses an io port range of [ 0x2000, 0x10000 ] [1]. At the
> > moment,
> > EDKII is using a subset of this range [ 0xC000, 0x10000 ] [2]. Even
> > though the EDKII range doesn't exeed the bhyve range, it's causing
> 
> s/exeed/exceed/
> 
> > issues on some guests like OpenBSD. We don't know why it's causing
> > issues yet. However, using the same IO port range in EDKII fixes
> > the
> > issue and is a good idea anyway.
> > 
> > [1]
> > https://github.com/freebsd/freebsd-src/blob/82ea0132c8b17a7a6067c8a36c6434e587ede6de/usr.sbin/bhyve/pci_emul.c#L133-L134
> > [2]
> > https://github.com/tianocore/edk2/blob/fb044b7fe893a4545995bfe2701fd38e593355d9/OvmfPkg/Bhyve/PlatformPei/Platform.c#L156-L157
> > 
> > Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > ---
> >  OvmfPkg/Bhyve/PlatformPei/Platform.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c
> > b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> > index f6d9a9038e12..bd1b22a9476e 100644
> > --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c
> > +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> > @@ -153,8 +153,8 @@ MemMapInitialization (
> >    UINT64         PciIoSize;
> >    RETURN_STATUS  PcdStatus;
> >  
> > -  PciIoBase = 0xC000;
> > -  PciIoSize = 0x4000;
> > +  PciIoBase = 0x2000;
> > +  PciIoSize = 0xE000;
> >  
> >    //
> >    // Create Memory Type Information HOB
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Can you create a BZ for this issue? With that, I think this should be
> possible to merge during the hard feature freeze. Adding Liming.
> 

I've never created a BZ yet. I can't find a button to create a new
account at https://bugzilla.tianocore.org/.

> (For the typo fix in the commit message, either post v2, or ask
> Liming
> to fix it up upon merge.)
> 
> Thanks
> Laszlo
> 
> 
> 
> 
> 
> 

-- 
Kind regards,
Corvin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111460): https://edk2.groups.io/g/devel/message/111460
Mute This Topic: https://groups.io/mt/102646333/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]