From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, sam.kaynor@arm.com
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Eric Jin <eric.jin@intel.com>, Arvin Chen <arvinx.chen@intel.com>,
Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL
Date: Mon, 30 Jan 2023 05:16:26 -0700 [thread overview]
Message-ID: <88bba06a-14dd-48bf-1da6-1123dfeec0e6@bsdio.com> (raw)
In-Reply-To: <20221011175443.1869922-2-sam.kaynor@arm.com>
[-- Attachment #1: Type: text/plain, Size: 4149 bytes --]
It looks like the cc list wasn't populated correctly.
I've cc'd the people mentioned in the commit message.
On 10/11/22 11:54, Sam Kaynor wrote:
> Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in
> RandomNumberBBTestConformance and RandomNumberBBTestFunction
> to "RANDOM_NUMBER_PROTOCOL".
>
> Cc: G Edhaya Chandran<Edhaya.Chandran@arm.com>
> Cc: Barton Gao<gaojie@byosoft.com.cn>
> Cc: Carolyn Gjertsen<Carolyn.Gjertsen@amd.com>
> Cc: Samer El-Haj-Mahmoud<Samer.El-Haj-Mahmoud@arm.com>
> Cc: Eric Jin<eric.jin@intel.com>
> Cc: Arvin Chen<arvinx.chen@intel.com>
> Cc: Supreeth Venkatesh<Supreeth.Venkatesh@amd.com>
> Signed-off-by: Sam Kaynor<sam.kaynor@arm.com>
> ---
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++--
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
> index 2738a4899457..364aaca925e0 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
> @@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (
> StandardLib,
> EFI_TEST_ASSERTION_WARNING,
> gConformanceTestAssertionGuid001,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> @@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gConformanceTestAssertionGuid001,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",
> L"%a:%d: Status - %r, RNGAlgorithmListSize - %d",
> __FILE__,
> (UINTN)__LINE__,
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
> index 3d41085d2243..0ba003449dc6 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
> @@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
> StandardLib,
> EFI_TEST_ASSERTION_FAILED,
> gTestGenericFailureGuid,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> @@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
> StandardLib,
> EFI_TEST_ASSERTION_FAILED,
> gTestGenericFailureGuid,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
[-- Attachment #2: Type: text/html, Size: 4997 bytes --]
next prev parent reply other threads:[~2023-01-30 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 17:54 [PATCH v1 0/1] Correct spelling error in SctPkg Sam Kaynor
2022-10-11 17:54 ` [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL Sam Kaynor
2022-10-11 22:30 ` [edk2-devel] " Samer El-Haj-Mahmoud
2022-11-07 7:55 ` G Edhaya Chandran
2023-01-30 12:16 ` Rebecca Cran [this message]
2023-01-31 11:55 ` Sunny Wang
2023-01-31 15:24 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88bba06a-14dd-48bf-1da6-1123dfeec0e6@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox