From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mx.groups.io with SMTP id smtpd.web10.39422.1675080992421496153 for ; Mon, 30 Jan 2023 04:16:32 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=FiJ4sb1A; spf=pass (domain: bsdio.com, ip: 64.147.123.21, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 29D873200A50; Mon, 30 Jan 2023 07:16:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 30 Jan 2023 07:16:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1675080988; x=1675167388; bh=Sg/io6I9N1 9nHHyX5d2tCTLALiLY5KdE5dewwkZ1Ll4=; b=FiJ4sb1AaQXzLviOV9jZ3IZicy x/l9jFC9TiXFBmJpYBk750vbvRKR75oLW6npDCRVxexNc/ODwbbH2iAcDYdeSotD demGvc+AVVK5lXy23Ez+sgfv5edeyaCtAAtEmsiNwMB1uMEcqFOGqg4AewrTuCd7 n3y8uhCJutn1CYqeyH0yT+1aZYKDHD5sZcuOxVETddcXTz7JxnSzPddL9WnVZo22 TTtxNWbEFmmoa3mZ8+vtsR8b20Ro48Hzax30EYIPTV3Tc+8lP3NZbEldFWKrj10a w/ZE4tpSyvSNxr8cWePOExMqpmUjVhBIuo17Arljvpa/itPZF+6o/fF8RhLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675080988; x=1675167388; bh=Sg/io6I9N19nHHyX5d2tCTLALiLY 5KdE5dewwkZ1Ll4=; b=ffY7+9SMvUaHXBoKco1OKsL2IMirMtbpcj3KvzhSGtSb LmIFpCVP8T2nCT815D4zbqEAi57u7hQ/Va6j7e/cK7CmNO20zFE6Y2fjPTLzqNR6 iryYLUYVZ+Hmfnq4G3TrMlU3LK2h7WZNTros6oJz2c9+fqbcsl5EOs9puR1uDLRb YNRSAuBt37AkW11mat926p75fZLgXffQRTHFQlUx6oV6+sFd+R2TFSe0jpXHSIIx OU6GB5BCC6Z5BY6R/5JHgTgTFea/emoM7cegma0GKBJQVDwhdQBM0mDOZ/VFSb0Z ROh91ETYtsBGV2PV0OOrTTTdhHFlgQM/AaPF+MoDjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefvddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfhfvefhjgesrgdtreertdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepgeekteeiteeiveeffedvudfgfefgfffhveevteetvdefleffhfelkedvveel gffhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 Jan 2023 07:16:26 -0500 (EST) Message-ID: <88bba06a-14dd-48bf-1da6-1123dfeec0e6@bsdio.com> Date: Mon, 30 Jan 2023 05:16:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL To: devel@edk2.groups.io, sam.kaynor@arm.com References: <20221011175443.1869922-1-sam.kaynor@arm.com> <20221011175443.1869922-2-sam.kaynor@arm.com> Cc: G Edhaya Chandran , Barton Gao , Carolyn Gjertsen , Samer El-Haj-Mahmoud , Eric Jin , Arvin Chen , Supreeth Venkatesh From: "Rebecca Cran" In-Reply-To: <20221011175443.1869922-2-sam.kaynor@arm.com> Content-Type: multipart/alternative; boundary="------------NA4nKIYLdhhynhgahbwLrBUf" Content-Language: en-US --------------NA4nKIYLdhhynhgahbwLrBUf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit It looks like the cc list wasn't populated correctly. I've cc'd the people mentioned in the commit message. On 10/11/22 11:54, Sam Kaynor wrote: > Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in > RandomNumberBBTestConformance and RandomNumberBBTestFunction > to "RANDOM_NUMBER_PROTOCOL". > > Cc: G Edhaya Chandran > Cc: Barton Gao > Cc: Carolyn Gjertsen > Cc: Samer El-Haj-Mahmoud > Cc: Eric Jin > Cc: Arvin Chen > Cc: Supreeth Venkatesh > Signed-off-by: Sam Kaynor > --- > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++-- > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c > index 2738a4899457..364aaca925e0 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c > @@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( > StandardLib, > EFI_TEST_ASSERTION_WARNING, > gConformanceTestAssertionGuid001, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > L"%a:%d: Status - %r", > __FILE__, > (UINTN)__LINE__, > @@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( > StandardLib, > AssertionType, > gConformanceTestAssertionGuid001, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", > L"%a:%d: Status - %r, RNGAlgorithmListSize - %d", > __FILE__, > (UINTN)__LINE__, > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c > index 3d41085d2243..0ba003449dc6 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c > @@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( > StandardLib, > EFI_TEST_ASSERTION_FAILED, > gTestGenericFailureGuid, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > L"%a:%d: Status - %r", > __FILE__, > (UINTN)__LINE__, > @@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( > StandardLib, > EFI_TEST_ASSERTION_FAILED, > gTestGenericFailureGuid, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", > L"%a:%d: Status - %r", > __FILE__, > (UINTN)__LINE__, --------------NA4nKIYLdhhynhgahbwLrBUf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit 
It looks like the cc list wasn't populated correctly.
I've cc'd the people mentioned in the commit message.
On 10/11/22 11:54, Sam Kaynor wrote:
Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in
RandomNumberBBTestConformance and RandomNumberBBTestFunction
to "RANDOM_NUMBER_PROTOCOL".

Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Cc: Arvin Chen <arvinx.chen@intel.com>
Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Signed-off-by: Sam Kaynor <sam.kaynor@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++--
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c    | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
index 2738a4899457..364aaca925e0 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
@@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (
                    StandardLib,
                    EFI_TEST_ASSERTION_WARNING,
                    gConformanceTestAssertionGuid001,
-                   L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
+                   L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
                    L"%a:%d: Status - %r",
                    __FILE__,
                    (UINTN)__LINE__,
@@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (
                  StandardLib,
                  AssertionType,
                  gConformanceTestAssertionGuid001,
-                 L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",
+                 L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",
                  L"%a:%d: Status - %r, RNGAlgorithmListSize - %d",
                  __FILE__,
                  (UINTN)__LINE__,
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
index 3d41085d2243..0ba003449dc6 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
@@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
                    StandardLib,
                    EFI_TEST_ASSERTION_FAILED,
                    gTestGenericFailureGuid,
-                   L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
+                   L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
                    L"%a:%d: Status - %r",
                    __FILE__,
                    (UINTN)__LINE__,
@@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
                    StandardLib,
                    EFI_TEST_ASSERTION_FAILED,
                    gTestGenericFailureGuid,
-                   L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",
+                   L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",
                    L"%a:%d: Status - %r",
                    __FILE__,
                    (UINTN)__LINE__,
--------------NA4nKIYLdhhynhgahbwLrBUf--