From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.21627.1669836562579058006 for ; Wed, 30 Nov 2022 11:29:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=lCndNkpm; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0333e21c67=brian.johnson@hpe.com) Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AUH3SSF002426; Wed, 30 Nov 2022 19:29:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=HMkbvu1z/sXqJXzb8yU2we+OgU9XFyLdAOF5QsfciZI=; b=lCndNkpmUvv3y2DGrUuONx7UcJXyOZvO+hKubyBFFu/8UvQZH+zPB2crwD0fFfAcnl3y AebTL+l9BBBDq4OaKI/ma0dJIT04UWEFQR8F+rjQCpndO3qaJYjdVrOpFLP3vigzpRpR vb3OcJbSXooTapCjoYeYp99dgRS0Vz2gmHh8GPNlEne78rA1L6SgYmycEqPXKYaC/f+3 /51YAqHsPAFcFjSEzVQ/QbhNbZ9++ELYm3Enx2hipFX5GF4d7TuUuR/APA7v4+wefugn fHWujbloH4bqOmZwODk21B1vP3X7GsanPxHYltnylJXwL4tmqE4cYmDtIW6638LDcClv +Q== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3m69fxa7vx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Nov 2022 19:29:03 +0000 Received: from p1wg14926.americas.hpqcorp.net (unknown [10.119.18.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id 917DC801AE0; Wed, 30 Nov 2022 19:28:50 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Wed, 30 Nov 2022 07:28:50 -1200 Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Wed, 30 Nov 2022 07:28:49 -1200 Received: from p1wg14921.americas.hpqcorp.net (16.230.19.124) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15 via Frontend Transport; Wed, 30 Nov 2022 07:28:49 -1200 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Wed, 30 Nov 2022 07:28:49 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FLTgyvO8Cxf5pe7CUC+XSumvlbFc6w+quE0UJiTQFa+XP+/FHT5+VyJ8LWe2AqJj4s+sFe/uhSZeLsQzOgE33caI+TyIzz13QLHTWUmP3TESM1BKpVgeAdnMohNHtFFcd+VTlUPRDWEZk94vUz0WiSDyfGEooeJTUmtsea6/TEztyrU0CZZgLpa+9TnnW4fQ2FGZBITGgdgVoquIDq7uq3lMbs4GVZcwz6Hs4yXNaN7VVFZaqFNdYlpR8TS9t/3HLNERBR0DyG0jGyZyXZzdyEmzLPSpfoGWwbfmAwTYIVl1UnrCxSs+iDsRb5S7ykXJabFo42Vbmwdr4wx4so4kPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HMkbvu1z/sXqJXzb8yU2we+OgU9XFyLdAOF5QsfciZI=; b=n1laSZT3jONtcx/GB9fUmVp6jIMFll0QkGbSODNnT84WQx2I//MKbnUA3Bp/ZwZW2zyornGj/yIigfPEZSbsGjMVwovwOrGD25K0YHgzaSHUPONik7QdhG8K00qPldrma6s6Kq4SmxektVvISQTVigYTHT8W7hr2g2A6j9oVoZcxFJE/QCTZAdzdmcsk5p+YUjWaYMVNPk4Ec9DhhL/aEEwsDfgUI8qhDJfnQY0JTFsH3y/LsWGehx/hZGoCWw57xHq3/UR9E4/m0szmcVil/zdWnGHh/VA88DGAUph6fGc9OFl/S4wMB4zR2k/k8rG4RA1uBiN5QWFXJR1Joj+uow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from MW5PR84MB1354.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1c0::21) by DM4PR84MB1686.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:8:49::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 19:28:47 +0000 Received: from MW5PR84MB1354.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4e56:9d21:919:8ef8]) by MW5PR84MB1354.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4e56:9d21:919:8ef8%8]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 19:28:47 +0000 Message-ID: <88bbd6a4-1e6c-7916-91be-76cae167aa74@hpe.com> Date: Wed, 30 Nov 2022 13:28:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS To: , CC: Alexey Kardashevskiy , Liming Gao , Erdem Aktas , "Pawel Polawski" , Jordan Justen , Ard Biesheuvel , Yuwei Chen , Tom Lendacky , "James Bottomley" , Oliver Steffen , Jiewen Yao , Min Xu , "Brijesh Singh" , Bob Feng References: <20221130094414.1983787-1-kraxel@redhat.com> <20221130094414.1983787-3-kraxel@redhat.com> From: "Brian J. Johnson" Organization: HPE In-Reply-To: <20221130094414.1983787-3-kraxel@redhat.com> X-ClientProxiedBy: CH2PR17CA0027.namprd17.prod.outlook.com (2603:10b6:610:53::37) To MW5PR84MB1354.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1c0::21) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW5PR84MB1354:EE_|DM4PR84MB1686:EE_ X-MS-Office365-Filtering-Correlation-Id: 208ab752-2135-4c0f-231f-08dad309191f X-LD-Processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I2ZYyQ3d++GzrpJaSh62D2zKuyEHE9y7bBdv2wZZTi/oes5tfAFFRGzidaVUdf7IxGLCf7N0G/Fvi1ijqlL0EWEgseJNpv3KDt0l5mWDe0OSmGFF/vkkrPIs4rcHwY4uxH5O1QIWrMYQbdaAaV8aA/17ndkgcSZ3A/YYFcJzcKtkV1FPxCxaG26ZMRVxy9JhOUvgDMv5cGhEDjfVLCgHelMcPVuKALsnZYmaRS4ek8zSurZ7xh+JNZHHQh7wZu0uoWZmencpILqlS9ca5Bt4wVRo7mZrhqkkSlI4gpQKjrLCFK2bdIPrpu7F8hTDCdOlp8ptmCE/sJASrFY7O8IEmD2G4FIWnxrnFxSV7dLi181G0dGD+3kQZ4ZOKbOnR6XOo3Zsh9rPkqQIm7XDozxX3LgmsTCx4ewvO8sAHyrYOp8OCdJg/76HAmfx8CMs/Hwq73PnPyuWo3bvTOKpv6dAiRKNrUGsLpYsEI7LeD7uVpchSYtE3JFwW4rWk/TSRY+BmG/jcqZvqDBQrUG9NwMj1GmsVgdAevtrqAbPx9iwVwBuNLWM6b3YA+fY/obostyqIUvXsFdK2lj8uOriBtNp41WBbaVq0ll4gy0LkV0dX6c+y4Gb0iBCscqEZoZ2tPrY2sRTLHyK5GBqtyUBL6QNDVDCFV1LN8Jqql9Ph97nNnrazdRrSek7nCmJFi/aEy3AcMDaZredAr33xSnwnP6wTzLMdHkRZPUAVJObseBdmBs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR84MB1354.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199015)(5660300002)(7416002)(31686004)(4326008)(66476007)(66556008)(41300700001)(8676002)(8936002)(6486002)(36916002)(54906003)(316002)(2906002)(478600001)(36756003)(6512007)(31696002)(86362001)(6506007)(2616005)(66946007)(186003)(83380400001)(26005)(6666004)(53546011)(82960400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUxTUEFRWG0zMDNodjNXVHUzcEIraW5wS20veEJkTk1IV1FmYTlTYUJuZ3pN?= =?utf-8?B?c3UvcC9zbTRyOFBjWTE4ZEo0S0xRSFZrV0orQWVGWGxnamVXRkVnWDFZSldE?= =?utf-8?B?cEIydVNleHd3bFQwK2xPa3pVdHgyZWZ4cXZEekw1QkNLc3IzQ2tQWkltaUJu?= =?utf-8?B?WHVDcHppT0hrR1FjeGRmNjFVOEI5RGtBNmUvemlCbXUxNnFCaW9aUUdCdVZX?= =?utf-8?B?czFHcUE1dDJwTXNxTW9qMER3aEpURElVVTRTUnpKMFdDWGFPZEM3Vkw0YWNI?= =?utf-8?B?cDNCUytLTVNlT3dVRWlUSTgwL2IzamY4cXo0ZWFkcU5IQTlZZnZPTXBvM0dm?= =?utf-8?B?WDNpaDlIUXVOK0gwVHRHL2hkUXdocXdrZXJLRkFjNjBpOXhqbXk4MHRnZ1BL?= =?utf-8?B?TW9xZlFXcC9xWnNLL0dCeVNQSE5ORVN1TWtZejBpM3dKNERuOWNxd1dIbFg3?= =?utf-8?B?eERwaHJwV3NSdWxQQ21YUlpCTnBYOXJrWnhFME9WbUJUMGtaeXIwdnl3cUZr?= =?utf-8?B?YTA5QS8yaGZNVGo4UTB0b01CWHZva1lzaDc2eG1tZU5WVG1XQldKeDFzK3Nu?= =?utf-8?B?QzhobHMwYkl5TWcyL3Zmd3J0SGVyUlNRdVorVzQxRzdBNmh1M2Z5anRQRW53?= =?utf-8?B?emVydEJSSkRxWG9sTTZVejhYVTVnQmxhYWxpak1SOFk3SVVMVjhIZnMva1RV?= =?utf-8?B?RHdiYWk4eU1tK2t2MC8zaXgvUVUwMGQrOEdmcGVicEJGQ25YZ2l2bHdoZE00?= =?utf-8?B?d29XZlpiSkZVSmRLRlA2bFdCRmZsSlhSckxtbjJqOFgzcFIxYTEwcjFHZTky?= =?utf-8?B?N0FSTE9ZVUhBa2lETzBvTWZDbE5DYUxoQjFneTZZSWpMbHg3WVRvVW9sOHRa?= =?utf-8?B?UU1LaFFIck5GYUp5M01mbmJCeGlKK2dVSXpjQUNXREZvNTU5SXZ3cE81dUk5?= =?utf-8?B?YVRuUjAzckc3bzFscklOL0xRZmovb0JTSGF6d0lUblRHRWVwMTJxM3B3bkhE?= =?utf-8?B?L1I1VzZYSGdST25hZFJUT2ZFY2g3ZVpFeGJWdGpMcityaXdid205VUVtdGZE?= =?utf-8?B?Q3BuUEFreTFNN0pEUDFWaEtrWUhRQXE4a0xPVmgwZVAwM0l6Wm5ZbWNOditx?= =?utf-8?B?YUUrem40NFpzQ1dUVWl2RUJ5Ri9qU2ZXdHJDaFJJYW9lN2FnYmJzQUpyNnBu?= =?utf-8?B?WXkxaUduUTVPbUNQQ1pPNmRncWxMam9ibkdoMmJaODZOUlU2a3hvc3NVT01Z?= =?utf-8?B?SnBEMjhDNEpzY1hCb21pcDRESmROS2ZNZmRhYXZPdCt1VmEvK2NsTk9CcFBJ?= =?utf-8?B?TVplOHBYV1pUTElwVFVnY2xWdEFSY2svR0R0bEtyR0ZYTVAxd0xxVFYzdE5z?= =?utf-8?B?cCtPRW42OERMOCtSTnZYNlQvbEd6WW9mQnBxNEtidGpnSFk1VjlaQVBHdVZu?= =?utf-8?B?eG9qV1FpSGo2cEhadlJmMkNxZkllWElJS2ZTRUpYTmRuN2lDank5VHZCeXo1?= =?utf-8?B?RlZPK2hIbWVXSXJMVlhDOGk3bEV5WWVEWFkxSHdGZ2VKaDBMY0JLQUJMMGoy?= =?utf-8?B?QzFIUjdrc0dxTFM2M3FrNkk5b2l4OGk2dnFwaHB0WUMxU2QxUCtTN1p2WTdn?= =?utf-8?B?cGJ4cUJqQkFXWjZ0NkhacTRMVmNSSWRHcXFKbExodFQwL1N4SmFwNmZzVitH?= =?utf-8?B?ZUJReGhvcndGR01MZ0d6Q25kR0IyV0RMY0JUTG1seDkvNEU1L1JOWjZSNmhZ?= =?utf-8?B?Vnp4Sk1OYUc5VHB3b2hPVzJLaDFINVdBck80dUZHSkw5WDhOaUplVkVSbVY5?= =?utf-8?B?K1dOTjJpcXpFT3UyUkQybGYzVEFscnBvYXdLbGZvdmZ3SENLc2lYUUFwNnQw?= =?utf-8?B?akhBZmpWcVpQMWthaVhaMnBwUmdTWHUvbFk4R3lmQ2syNWlIODVuakovQ21o?= =?utf-8?B?VndPeGgvaGRCdnRFZVVqcEhMZFhLdktoQU5UTSs5ZnJFQXZ1cEJaNGplcC9B?= =?utf-8?B?N3N3eGs3cCtpSU4wZFhIUjVwREdqMEV2a08wQXBjMkIva0phWGhtRHUyS1Qz?= =?utf-8?B?bHVULzFnRGo0cy9jTUZyMitxTkZOZmJ3dms5ZHZDS3FwSHpoMkhadmpKNzlS?= =?utf-8?Q?uP5+YDnZvtzLXrfpBY51yHCI8?= X-MS-Exchange-CrossTenant-Network-Message-Id: 208ab752-2135-4c0f-231f-08dad309191f X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1354.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 19:28:47.1450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aYs9CZBDO0CX9Pl9N7HveCMCJT0+wTRbtY0zsoXzhe1X069xRc8YaTJliDt8d8T8camq7assHhcCRPCxWZdDGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1686 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: xi0wteUSEv90CRxBawP_oaBOJOUN-fJC X-Proofpoint-GUID: xi0wteUSEv90CRxBawP_oaBOJOUN-fJC X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-30_04,2022-11-30_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 mlxlogscore=999 impostorscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211300137 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Gerd, Sorry, gotta ask: does this make much difference in the size of the compiled code? That's a constraint on many real-hardware X64 platforms, especially for 32-bit code. Brian J. Johnson -------- Original Message -------- From: Gerd Hoffmann [mailto:kraxel@redhat.com] Sent: Wednesday, November 30, 2022 at 3:44 AM To: devel@edk2.groups.io Cc: Alexey Kardashevskiy , Liming Gao , Erdem Aktas , Pawel Polawski , Jordan Justen , Ard Biesheuvel , Yuwei Chen , Tom Lendacky , James Bottomley , Gerd Hoffmann , Oliver Steffen , Jiewen Yao , Min Xu , Brijesh Singh , Bob Feng Subject: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS Fixes problems due to code assuming it runs with frame pointers and thus updates rbp / ebp registers when switching stacks. Signed-off-by: Gerd Hoffmann --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index 73f95b2a3a9f..f1fd6a003062 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1888,8 +1888,8 @@ DEFINE GCC_DEPS_FLAGS = -MMD -MF $@.deps DEFINE GCC48_ALL_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -ffunction-sections -fdata-sections -DSTRING_ARRAY_NAME=$(BASE_NAME)Strings DEFINE GCC48_IA32_X64_DLINK_COMMON = -nostdlib -Wl,-n,-q,--gc-sections -z common-page-size=0x20 -DEFINE GCC48_IA32_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) -m32 -march=i586 -malign-double -fno-stack-protector -D EFI32 -fno-asynchronous-unwind-tables -Wno-address -DEFINE GCC48_X64_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) -m64 -fno-stack-protector "-DEFIAPI=__attribute__((ms_abi))" -maccumulate-outgoing-args -mno-red-zone -Wno-address -mcmodel=small -fpie -fno-asynchronous-unwind-tables -Wno-address +DEFINE GCC48_IA32_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) -m32 -march=i586 -malign-double -fno-stack-protector -D EFI32 -fno-asynchronous-unwind-tables -Wno-address -fno-omit-frame-pointer +DEFINE GCC48_X64_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) -m64 -fno-stack-protector "-DEFIAPI=__attribute__((ms_abi))" -maccumulate-outgoing-args -mno-red-zone -Wno-address -mcmodel=small -fpie -fno-asynchronous-unwind-tables -Wno-address -fno-omit-frame-pointer DEFINE GCC48_IA32_X64_ASLDLINK_FLAGS = DEF(GCC48_IA32_X64_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u ReferenceAcpiTable DEFINE GCC48_IA32_X64_DLINK_FLAGS = DEF(GCC48_IA32_X64_DLINK_COMMON) -Wl,--entry,$(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) -Wl,-Map,$(DEST_DIR_DEBUG)/$(BASE_NAME).map,--whole-archive DEFINE GCC48_IA32_DLINK2_FLAGS = -Wl,--defsym=PECOFF_HEADER_SIZE=0x220 DEF(GCC_DLINK2_FLAGS_COMMON) -- Brian -------------------------------------------------------------------- "I love deadlines. I like the whooshing sound they make as they fly by." -- Douglas Adams