From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, bob.c.feng@intel.com
Cc: Liming Gao <gaoliming@byosoft.com.cn>, Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [Patch] BaseTools: use shutil.copyfile instead shutil.copy2
Date: Mon, 9 Aug 2021 10:15:40 +0200 [thread overview]
Message-ID: <88d28a54-bd16-086e-1d79-5fccba40cd3c@redhat.com> (raw)
In-Reply-To: <20210728114523.687-1-bob.c.feng@intel.com>
On 7/28/21 1:45 PM, Bob Feng wrote:
> In Split tool, the copy file actions only need to
> copy file content but not need to copy file metadata.
>
> copy2() copies the file metadata that causes split
> unit test failed under edk2-basetools CI environment.
>
> So this patch changes the call of copy2() to copyfile().
>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/Split/Split.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
prev parent reply other threads:[~2021-08-09 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 11:45 [Patch] BaseTools: use shutil.copyfile instead shutil.copy2 Bob Feng
2021-08-02 0:56 ` Yuwei Chen
2021-08-09 8:15 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d28a54-bd16-086e-1d79-5fccba40cd3c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox