From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.20027.1628496944937268908 for ; Mon, 09 Aug 2021 01:15:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XxukeK+p; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628496944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6jawXTmMhk0HevBV8IWS9Xyfn7nBrb9GdRR30voVTOM=; b=XxukeK+pEZmR4MRN8hYi2oJ7saJJ2BCrep5/joiVy7DzxlqKoKDv+8P1ijPkZVBMgM9j09 qNm+pGJXakOS+kNvzhXJUoTdy8QTTA9L/ZoEOptT+tCIen+FH3S/z6bkaV/SjRV8tP3qjs Th1wESjivdbRyoo12iONSLkyMrXCL8g= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-nK4htIGzMM2gce7Sscl_mQ-1; Mon, 09 Aug 2021 04:15:42 -0400 X-MC-Unique: nK4htIGzMM2gce7Sscl_mQ-1 Received: by mail-wm1-f71.google.com with SMTP id k13-20020a05600c1c8db029025018ac4f7dso4354945wms.2 for ; Mon, 09 Aug 2021 01:15:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6jawXTmMhk0HevBV8IWS9Xyfn7nBrb9GdRR30voVTOM=; b=MHn7d6x70+a0XGuNw1FchIOIVSdm3/ucDLnnTonpBgZ2uKsmZ07rfrcyxvajxaDXMa eIseTKiYNxpyM34Vp0v8QNBdTr4KuZs/C0rglNCJ/PoBktyrYLqQ1Z84JiRk190Mm3mq S9IoVys3UISQnx5SXQNyhh/lB65H/Lt2k0Y+Bu1gsWEUs93nWH9+h4EM6nTmxNUgegKg 3/Q6Oe/ll/XH+Dp4We8dvoW/1fqkkjgomYOIJhgk1TbtrEAARaJuEFUUbIIdrpjMSVZV lGqXe8FvJpqcH2L8J5gcEXhAaOxnycn4JFgyNYzgo+bPeh/GPereP0NpjLNSPdUbbars V+uw== X-Gm-Message-State: AOAM533o5Ojn3JyJ+zK4IjnBwq5LhmQo4RwB+8Sp26H9tZ7pDcMF3ujG R2CA6HvRlWsVUQLWOsHkoF1W5LQsd626zdLDl4Url7I8j/xvhIk3dwJCHjgvUDVV9hoixEKFwD9 HMoPRMDmemJkQmQ== X-Received: by 2002:adf:dd8b:: with SMTP id x11mr23337505wrl.357.1628496941725; Mon, 09 Aug 2021 01:15:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxa0uZybE7IZUY+pJODKHH5kvIPPD3YEjZR6n7IE8rQk/kHbEkR9T+TR+6c03JtsYKkO78osg== X-Received: by 2002:adf:dd8b:: with SMTP id x11mr23337488wrl.357.1628496941517; Mon, 09 Aug 2021 01:15:41 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id n10sm1397731wmq.3.2021.08.09.01.15.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 01:15:41 -0700 (PDT) Subject: Re: [edk2-devel] [Patch] BaseTools: use shutil.copyfile instead shutil.copy2 To: devel@edk2.groups.io, bob.c.feng@intel.com Cc: Liming Gao , Yuwei Chen References: <20210728114523.687-1-bob.c.feng@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <88d28a54-bd16-086e-1d79-5fccba40cd3c@redhat.com> Date: Mon, 9 Aug 2021 10:15:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210728114523.687-1-bob.c.feng@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/28/21 1:45 PM, Bob Feng wrote: > In Split tool, the copy file actions only need to > copy file content but not need to copy file metadata. > > copy2() copies the file metadata that causes split > unit test failed under edk2-basetools CI environment. > > So this patch changes the call of copy2() to copyfile(). > > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > --- > BaseTools/Source/Python/Split/Split.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daude