From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C3D15740038 for ; Fri, 4 Aug 2023 18:08:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7GtTZEVfiEJvLe7E0ewXAhwogRpOZOvY6QZzjVJ7+8w=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1691172487; v=1; b=LP/0MW+PIi9pojRCSK2ozaay3ctI90K7DEvby2e0fQbetXd3IDsse3Al1sbAZxYAc2AVARUd +bAJF2jrtTXOZfABBloNkze7B6KlYPHRZOMezjpVk3L1k7GWXRbCqRLuKKT2pSRcj5EeGMC9rX5 TbKaRv4SOfXaw3vUUDarw4Sc= X-Received: by 127.0.0.2 with SMTP id FVVFYY7687511xwCtrosLHXf; Fri, 04 Aug 2023 11:08:07 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.10419.1691055025904081279 for ; Thu, 03 Aug 2023 02:30:26 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="367279741" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="367279741" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 02:29:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="843519426" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="843519426" X-Received: from basfe006.gar.corp.intel.com ([10.66.244.178]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 02:29:11 -0700 From: chitralekha ck To: devel@edk2.groups.io Cc: chitralekha ck , Ray Ni , Zhichao Gao , Ashraf Ali S , Chinni B Duggapu Subject: [edk2-devel] [PATCH v3] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt Date: Thu, 3 Aug 2023 14:59:04 +0530 Message-Id: <88dd0aaaa5fa6f6750515fe1441c167c5501947a.1691054931.git.chitralekha.ck@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chitralekha.ck@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LT5cGWeTi2P9lJmuAWIogeFUx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="LP/0MW+P"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io https://bugzilla.tianocore.org/show_bug.cgi?id=4507 AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. AllocatePool() is being avoided due to its 64k allocation size limit when the library is incorporated into a PEI component. Cc: Ray Ni Cc: Zhichao Gao Cc: Ashraf Ali S Cc: Chinni B Duggapu Signed-off-by: chitralekha ck --- MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c index c5e885d7a6..a7ebcd1d65 100644 --- a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c +++ b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c @@ -52,7 +52,7 @@ const BMP_IMAGE_HEADER mBmpImageHeaderTemplate = { /** Translate a *.BMP graphics image to a GOP blt buffer. If a NULL Blt buffer is passed in a GopBlt buffer will be allocated by this routine using - EFI_BOOT_SERVICES.AllocatePool(). If a GopBlt buffer is passed in it will be + EFI_BOOT_SERVICES.AllocatePages(). If a GopBlt buffer is passed in it will be used if it is big enough. @param[in] BmpImage Pointer to BMP file. @@ -312,7 +312,7 @@ TranslateBmpToGopBlt ( // DEBUG ((DEBUG_INFO, "Bmp Support: Allocating 0x%X bytes of memory\n", BltBufferSize)); *GopBltSize = (UINTN)BltBufferSize; - *GopBlt = AllocatePool (*GopBltSize); + *GopBlt = AllocatePages (*GopBltSize); IsAllocated = TRUE; if (*GopBlt == NULL) { return RETURN_OUT_OF_RESOURCES; -- 2.38.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107576): https://edk2.groups.io/g/devel/message/107576 Mute This Topic: https://groups.io/mt/100551576/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-