public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Ting Ye <ting.ye@intel.com>,
	Siyuan Fu <siyuan.fu@intel.com>, Fan Wang <fan.wang@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	"Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
	Andrew Fish <afish@apple.com>, Leif Lindholm <leif@nuviainc.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams
Date: Tue, 13 Apr 2021 15:08:09 +0200	[thread overview]
Message-ID: <88ebe4b6-9c69-7e90-a0d2-9b91d180e23f@redhat.com> (raw)
In-Reply-To: <CS1PR8401MB1144EE1EAE4779E8E91A9B6DFF4F9@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM>

On 04/13/21 12:44, Chang, Abner (HPS SW/FW Technologist) wrote:
> 
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Tuesday, April 13, 2021 6:19 PM
>> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
>> devel@edk2.groups.io
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>; Ting Ye <ting.ye@intel.com>; Siyuan Fu
>> <siyuan.fu@intel.com>; Fan Wang <fan.wang@intel.com>; Jiewen Yao
>> <jiewen.yao@intel.com>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>;
>> Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>;
>> Michael D Kinney <michael.d.kinney@intel.com>
>> Subject: Re: [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams
>>
>> On 04/13/21 02:10, Abner Chang wrote:
>>> The Readme.md to delineate the EFK2 Redfish foundation driver
>>> stack.
>>>
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>>>
>>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>>> Cc: Ting Ye <ting.ye@intel.com>
>>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>>> Cc: Fan Wang <fan.wang@intel.com>
>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>>> Cc: Nickle Wang <nickle.wang@hpe.com>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> ---
>>>  RedfishPkg/Readme.md                          | 117 ++++++++++++++++++
>>>  .../Documents/Media/RedfishDriverStack.png    | Bin 0 -> 157408 bytes
>>>  2 files changed, 117 insertions(+)
>>>  create mode 100644 RedfishPkg/Readme.md
>>>  create mode 100644
>> RedfishPkg/Documents/Media/RedfishDriverStack.png
>>
>> Why am I expected to review this?
> I thought you are the steward and may give comments on the readme markdown with image of the diagrams under RedfishPkg. But you did have comments on the RFC so that's another reason to invite you for the review, not mandatory though :D
> Same message to Andrew, Leif and Mike.

Right... but my earlier comments suggested SVG, and Mike suggested
another plaintext-based graphics format (sorry the name eludes me at the
moment). So why is there a PNG in this patch?

Thanks
Laszlo


  reply	other threads:[~2021-04-13 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13  0:10 [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams Abner Chang
2021-04-13  1:26 ` Nickle Wang
2021-04-13 10:19 ` Laszlo Ersek
2021-04-13 10:44   ` Abner Chang
2021-04-13 13:08     ` Laszlo Ersek [this message]
2021-04-13 14:57       ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88ebe4b6-9c69-7e90-a0d2-9b91d180e23f@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox