From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.8833.1618319301185211535 for ; Tue, 13 Apr 2021 06:08:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OBJFgwRs; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618319300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M9y61l/nvZjr4+JeMxpyrygU79oyhBTUO7MMKTnHniU=; b=OBJFgwRsjmiqw0JKKcwLBTsneSiCFFtAC5TiRDGoD78dixZwhnDpUteNMbgdURQTLWTYV7 UPc5mhDi6D444VIngQfpY4KIepByMfnlkkzjb+Z1Y1Jm4DQinuE1ajb6jvP9w21Mn8Q4GT mPXoS8JV4apUMUUiDQSD1AuSQ3aSw3Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-Mf8uZeuxPGyhxvK2RwNtgA-1; Tue, 13 Apr 2021 09:08:14 -0400 X-MC-Unique: Mf8uZeuxPGyhxvK2RwNtgA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A631EC73A0; Tue, 13 Apr 2021 13:08:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-199.ams2.redhat.com [10.36.115.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30DC75C224; Tue, 13 Apr 2021 13:08:10 +0000 (UTC) Subject: Re: [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" Cc: Jiaxin Wu , Ting Ye , Siyuan Fu , Fan Wang , Jiewen Yao , "Wang, Nickle (HPS SW)" , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20210413001020.23471-1-abner.chang@hpe.com> <779eef25-03dd-e69e-11bc-013ef2dbbd0e@redhat.com> From: "Laszlo Ersek" Message-ID: <88ebe4b6-9c69-7e90-a0d2-9b91d180e23f@redhat.com> Date: Tue, 13 Apr 2021 15:08:09 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/13/21 12:44, Chang, Abner (HPS SW/FW Technologist) wrote: > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Tuesday, April 13, 2021 6:19 PM >> To: Chang, Abner (HPS SW/FW Technologist) ; >> devel@edk2.groups.io >> Cc: Jiaxin Wu ; Ting Ye ; Siyuan Fu >> ; Fan Wang ; Jiewen Yao >> ; Wang, Nickle (HPS SW) ; >> Andrew Fish ; Leif Lindholm ; >> Michael D Kinney >> Subject: Re: [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams >> >> On 04/13/21 02:10, Abner Chang wrote: >>> The Readme.md to delineate the EFK2 Redfish foundation driver >>> stack. >>> >>> Signed-off-by: Abner Chang >>> >>> Cc: Jiaxin Wu >>> Cc: Ting Ye >>> Cc: Siyuan Fu >>> Cc: Fan Wang >>> Cc: Jiewen Yao >>> Cc: Nickle Wang >>> Cc: Andrew Fish >>> Cc: Laszlo Ersek >>> Cc: Leif Lindholm >>> Cc: Michael D Kinney >>> --- >>> RedfishPkg/Readme.md | 117 ++++++++++++++++++ >>> .../Documents/Media/RedfishDriverStack.png | Bin 0 -> 157408 bytes >>> 2 files changed, 117 insertions(+) >>> create mode 100644 RedfishPkg/Readme.md >>> create mode 100644 >> RedfishPkg/Documents/Media/RedfishDriverStack.png >> >> Why am I expected to review this? > I thought you are the steward and may give comments on the readme markdown with image of the diagrams under RedfishPkg. But you did have comments on the RFC so that's another reason to invite you for the review, not mandatory though :D > Same message to Andrew, Leif and Mike. Right... but my earlier comments suggested SVG, and Mike suggested another plaintext-based graphics format (sorry the name eludes me at the moment). So why is there a PNG in this patch? Thanks Laszlo