From: "Daniel Schaefer" <daniel.schaefer@hpe.com>
To: Abner Chang <abner.chang@hpe.com>, <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Sunil V L <sunilvl@ventanamicro.com>
Subject: Re: [PATCH V2 3/9] ArmPkg: Use PcdPciIoTranslation PCD from MdePkg
Date: Wed, 29 Sep 2021 07:38:17 +0800 [thread overview]
Message-ID: <88f0cd6b-b48f-ad98-eb64-1e2823c103e5@hpe.com> (raw)
In-Reply-To: <20210928083107.7418-4-abner.chang@hpe.com>
Good so far.
Reviewed-By: Daniel Schaefer <daniel.schaefer@hpe.com>
But it needs an update to edk2-platforms, too. Lots of platform use this PCD.
On 9/28/21 16:31, Abner Chang wrote:
> PcdPciIoTranslation PCD is relocated to MdePkg and leveraged by
> both ARM and RISC-V arch. This patch removes the one from ArmPkg
> and address the corresponding changes required for other modules
> under ArmVirtPkg.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> ---
> ArmPkg/ArmPkg.dec | 5 ++---
> ArmVirtPkg/ArmVirtCloudHv.dsc | 2 +-
> ArmVirtPkg/ArmVirtKvmTool.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf | 2 +-
> .../Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 2 +-
> .../Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf | 2 +-
> 8 files changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index 6ed51edd03..12584fb319 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -337,7 +337,7 @@
> # UINT64 Mmio32CpuBase; // mapping target in 64-bit cpu-physical space
> # UINT64 Mmio64CpuBase; // mapping target in 64-bit cpu-physical space
> #
> - # PcdPciIoTranslation = IoCpuBase - PcdPciIoBase;
> + # gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation = IoCpuBase - PcdPciIoBase;
> # PcdPciMmio32Translation = Mmio32CpuBase - (UINT64)PcdPciMmio32Base;
> # PcdPciMmio64Translation = Mmio64CpuBase - PcdPciMmio64Base;
> #
> @@ -356,7 +356,7 @@
> # UINT64 TranslatedMmio64Address; // output parameter
> #
> # TranslatedIoAddress = UntranslatedIoAddress +
> - # PcdPciIoTranslation;
> + # gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation;
> # TranslatedMmio32Address = (UINT64)UntranslatedMmio32Address +
> # PcdPciMmio32Translation;
> # TranslatedMmio64Address = UntranslatedMmio64Address +
> @@ -369,7 +369,6 @@
> #
> gArmTokenSpaceGuid.PcdPciIoBase|0x0|UINT64|0x00000050
> gArmTokenSpaceGuid.PcdPciIoSize|0x0|UINT64|0x00000051
> - gArmTokenSpaceGuid.PcdPciIoTranslation|0x0|UINT64|0x00000052
> gArmTokenSpaceGuid.PcdPciMmio32Base|0x0|UINT32|0x00000053
> gArmTokenSpaceGuid.PcdPciMmio32Size|0x0|UINT32|0x00000054
> gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0|UINT64|0x00000055
> diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc
> index 07313e1e67..f159754bf4 100644
> --- a/ArmVirtPkg/ArmVirtCloudHv.dsc
> +++ b/ArmVirtPkg/ArmVirtCloudHv.dsc
> @@ -192,7 +192,7 @@
> # PCD and PcdPciDisableBusEnumeration above have not been assigned yet
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xFFFFFFFFFFFFFFFF
>
> - gArmTokenSpaceGuid.PcdPciIoTranslation|0
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0
>
> gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress|0x0
>
> diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
> index 745eae347b..ff70509542 100644
> --- a/ArmVirtPkg/ArmVirtKvmTool.dsc
> +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc
> @@ -184,7 +184,7 @@
> # PCD and PcdPciDisableBusEnumeration above have not been assigned yet
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xFFFFFFFFFFFFFFFF
>
> - gArmTokenSpaceGuid.PcdPciIoTranslation|0x0
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0
>
> #
> # Set video resolution for boot options and for text setup.
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 5030174fe3..f4bb14903f 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -247,7 +247,7 @@
> # PCD and PcdPciDisableBusEnumeration above have not been assigned yet
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xFFFFFFFFFFFFFFFF
>
> - gArmTokenSpaceGuid.PcdPciIoTranslation|0x0
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0
>
> #
> # Set video resolution for boot options and for text setup.
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 5e0a2ee0c6..eecef1a063 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -227,7 +227,7 @@
> # PCD and PcdPciDisableBusEnumeration above have not been assigned yet
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xFFFFFFFFFFFFFFFF
>
> - gArmTokenSpaceGuid.PcdPciIoTranslation|0x0
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0
>
> #
> # Set video resolution for boot options and for text setup.
> diff --git a/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf b/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
> index 2bc4571d06..9339c2b532 100644
> --- a/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
> +++ b/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
> @@ -38,7 +38,7 @@
> UefiBootServicesTableLib
>
> [Pcd]
> - gArmTokenSpaceGuid.PcdPciIoTranslation
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation
>
> [Protocols]
> gEfiCpuIo2ProtocolGuid ## PRODUCES
> diff --git a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> index 1549f9d884..f149693fa2 100644
> --- a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> +++ b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> @@ -48,7 +48,7 @@
> gArmTokenSpaceGuid.PcdPciMmio64Translation
>
> [Pcd]
> - gArmTokenSpaceGuid.PcdPciIoTranslation
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
>
> [Depex]
> diff --git a/ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf b/ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> index bb055a5beb..1dfe779f6c 100644
> --- a/ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> +++ b/ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> @@ -36,7 +36,7 @@
> gFdtClientProtocolGuid ## CONSUMES
>
> [Pcd]
> - gArmTokenSpaceGuid.PcdPciIoTranslation ## PRODUCES
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation ## PRODUCES
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress ## PRODUCES
> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration ## PRODUCES
>
>
next prev parent reply other threads:[~2021-09-28 23:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 8:30 [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg Abner Chang
2021-09-28 8:30 ` [PATCH V2 1/9] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg Abner Chang
2021-09-28 23:09 ` Daniel Schaefer
2021-09-28 8:31 ` [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD Abner Chang
2021-09-28 23:10 ` Daniel Schaefer
2021-09-29 0:51 ` Abner Chang
2021-09-29 1:10 ` 回复: [edk2-devel] " gaoliming
2021-09-28 8:31 ` [PATCH V2 3/9] ArmPkg: Use PcdPciIoTranslation PCD from MdePkg Abner Chang
2021-09-28 23:38 ` Daniel Schaefer [this message]
2021-09-28 8:31 ` [PATCH V2 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg Abner Chang
2021-09-28 23:16 ` Daniel Schaefer
[not found] ` <16A91FA9AD0B84BA.7073@groups.io>
2021-09-28 23:41 ` [edk2-devel] " Daniel Schaefer
2021-09-29 0:42 ` Abner Chang
2021-09-28 8:31 ` [PATCH V2 5/9] ArmVirtPkg/HighMemDxe: Relocate HighMemDxe " Abner Chang
2021-09-28 23:34 ` Daniel Schaefer
2021-09-28 8:31 ` [PATCH V2 6/9] ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib " Abner Chang
2021-09-28 11:43 ` [edk2-devel] " Gerd Hoffmann
2021-09-29 9:45 ` Sami Mujawar
2021-09-29 10:04 ` Yao, Jiewen
2021-09-29 11:33 ` Sami Mujawar
2021-09-29 12:26 ` [edk2-devel] " Yao, Jiewen
2021-09-29 12:46 ` Abner Chang
2021-09-29 12:57 ` Yao, Jiewen
2021-09-28 8:31 ` [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs Abner Chang
2021-09-28 23:36 ` Daniel Schaefer
2021-09-29 0:54 ` Abner Chang
2021-09-28 8:31 ` [PATCH V2 8/9] ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt Abner Chang
2021-09-28 23:25 ` Daniel Schaefer
2021-09-28 8:31 ` [PATCH V2 9/9] ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe " Abner Chang
2021-09-28 23:36 ` Daniel Schaefer
2021-09-28 23:11 ` [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg Daniel Schaefer
2021-09-29 0:53 ` Abner Chang
2021-09-29 1:30 ` 回复: [edk2-devel] " gaoliming
2021-09-29 1:43 ` Abner Chang
2021-09-29 3:31 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f0cd6b-b48f-ad98-eb64-1e2823c103e5@hpe.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox