From: Laszlo Ersek <lersek@redhat.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Qian, Yi" <yi.qian@intel.com>, "Ye, Ting" <ting.ye@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Ni, Ray" <ray.ni@intel.com>,
Anthony Perard <anthony.perard@citrix.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 00/26] remove the GCC44 through GCC47 toolchains
Date: Tue, 8 Jan 2019 02:54:23 +0100 [thread overview]
Message-ID: <8903ff0b-b822-13d1-6a17-52e18e915ba7@redhat.com> (raw)
In-Reply-To: <020b38a7-cb17-aa75-1054-a91e7adee32a@redhat.com>
On 01/07/19 19:08, Laszlo Ersek wrote:
> On 01/07/19 13:15, Gao, Liming wrote:
>> Laszlo:
>> This patch set is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> Many thanks to everyone for the quick reviews!
>
>> Besides this patch set, I suggest to let GCC48/GCC49/GCC5 refer to the common GCC_ flags. After I remove ELFGCC/UNIXGCC/CYGGCC tool chain, I will update GCC_ flags to be same to current GCC48_ flags, then remove GCC48_ flag definition.
>
> Sounds good to me, thanks. IIRC I actually looked into calling that
> stuff just GCC_, but I seem to remember that the subject macros were
> already defined for other purposes. Once you eliminate
> ELFGCC/UNIXGCC/CYGGCC, hopefully all those macros can be collapsed.
>
> For this series, I plan to go through the feedback tags in detail,
> shortly, and push the series if everything is sufficiently approved.
That appears to be the case, so I've pushed the series: commit range
46f4c9677c61..7423ba9d499b.
Thank you all again,
Laszlo
next prev parent reply other threads:[~2019-01-08 1:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 2:47 [PATCH 00/26] remove the GCC44 through GCC47 toolchains Laszlo Ersek
2019-01-03 2:47 ` [PATCH 01/26] EmulatorPkg: require GCC48 or later Laszlo Ersek
2019-01-03 2:47 ` [PATCH 02/26] OvmfPkg: " Laszlo Ersek
2019-01-03 9:33 ` Ard Biesheuvel
2019-01-03 2:47 ` [PATCH 03/26] Vlv2TbltDevicePkg: assume " Laszlo Ersek
2019-01-04 6:53 ` Sun, Zailiang
2019-01-03 2:47 ` [PATCH 04/26] BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46/GCC47 Laszlo Ersek
2019-01-03 2:47 ` [PATCH 05/26] BaseTools/tools_def.template: fix up LF-only line terminator Laszlo Ersek
2019-01-03 2:47 ` [PATCH 06/26] BaseTools/tools_def.template: strip trailing whitespace Laszlo Ersek
2019-01-03 2:47 ` [PATCH 07/26] BaseTools/tools_def.template: remove GCC48_IA32_X64_DLINK_COMMON dead-end Laszlo Ersek
2019-01-03 2:47 ` [PATCH 08/26] BaseTools/tools_def.template: remove GCC47 leaf definitions Laszlo Ersek
2019-01-03 2:47 ` [PATCH 09/26] BaseTools/tools_def.template: propagate loss of GCC47 references Laszlo Ersek
2019-01-03 2:48 ` [PATCH 10/26] BaseTools/tools_def.template: remove GCC47 documentation Laszlo Ersek
2019-01-03 2:48 ` [PATCH 11/26] BaseTools/tools_def.template: remove GCC46 leaf definitions Laszlo Ersek
2019-01-03 2:48 ` [PATCH 12/26] BaseTools/tools_def.template: propagate loss of GCC46 references Laszlo Ersek
2019-01-03 2:48 ` [PATCH 13/26] BaseTools/tools_def.template: remove GCC46 documentation Laszlo Ersek
2019-01-03 2:48 ` [PATCH 14/26] BaseTools/tools_def.template: remove GCC45 leaf definitions Laszlo Ersek
2019-01-03 2:48 ` [PATCH 15/26] BaseTools/tools_def.template: propagate loss of GCC45 references Laszlo Ersek
2019-01-03 2:48 ` [PATCH 16/26] BaseTools/tools_def.template: remove GCC45 documentation Laszlo Ersek
2019-01-03 2:48 ` [PATCH 17/26] BaseTools/tools_def.template: remove GCC44 leaf definitions Laszlo Ersek
2019-01-03 2:48 ` [PATCH 18/26] BaseTools/tools_def.template: propagate loss of GCC44 references Laszlo Ersek
2019-01-03 2:48 ` [PATCH 19/26] BaseTools/tools_def.template: rename GCC44_ALL_CC_FLAGS to GCC48_ALL_CC_FLAGS Laszlo Ersek
2019-01-03 2:48 ` [PATCH 20/26] BaseTools/tools_def.template: eliminate GCC44_IA32_X64_DLINK_FLAGS Laszlo Ersek
2019-01-03 2:48 ` [PATCH 21/26] BaseTools/tools_def.template: rename GCC44_IA32_X64_DLINK_COMMON to GCC48_IA32_X64_DLINK_COMMON Laszlo Ersek
2019-01-03 2:48 ` [PATCH 22/26] BaseTools/tools_def.template: remove comment about GCC44 + LzmaF86Compress Laszlo Ersek
2019-01-03 2:48 ` [PATCH 23/26] BaseTools/tools_def.template: remove GCC44 documentation Laszlo Ersek
2019-01-03 2:48 ` [PATCH 24/26] ArmPkg/ArmSoftFloatLib: drop build flags specific to GCC46/GCC47 Laszlo Ersek
2019-01-03 9:33 ` Ard Biesheuvel
2019-01-03 2:48 ` [PATCH 25/26] CryptoPkg/BaseCryptLib: drop build flags specific to GCC44 Laszlo Ersek
2019-01-03 5:02 ` Wang, Jian J
2019-01-03 2:48 ` [PATCH 26/26] Revert "MdePkg: avoid __builtin_unreachable() on GCC v4.4" Laszlo Ersek
2019-01-03 9:34 ` Ard Biesheuvel
2019-01-03 13:25 ` Marvin Häuser
2019-01-03 20:21 ` [PATCH 00/26] remove the GCC44 through GCC47 toolchains Jordan Justen
2019-01-07 9:44 ` Philippe Mathieu-Daudé
2019-01-07 12:15 ` Gao, Liming
2019-01-07 18:08 ` Laszlo Ersek
2019-01-08 1:54 ` Laszlo Ersek [this message]
2019-01-08 11:34 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8903ff0b-b822-13d1-6a17-52e18e915ba7@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox