Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

["Kun Qin" <kuqin12@gmail.com>]

Hi Michael/Yi/Zailiang,

Would you kindly review the patch below? We can also ignore this one if 
the package is no longer maintained. Please let me know how you would 
like to proceed.

Thanks in advance.

Regards,
Kun

On 03/18/2021 10:51, Kun Qin via groups.io wrote:
> Hi Michael,
> 
> Could you please review this change and provide feedback? Zailing would 
> prefer to have your vote before finalizing the change.
> 
> Any input is appreciated.
> 
> Regards,
> Kun
> 
> On 03/16/2021 11:10, Kun Qin via groups.io wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
>>
>> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
>> file to resolve new dependency by VariableSmmRuntimeDxe. The library
>> interface is consumed by variable module to better support variable
>> runtime cache feature.
>>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>
>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>> ---
>>
>> Notes:
>>      v2:
>>      - Added Michael K. to cc list [Zailiang]
>>
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc 
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> index 409f31c982d7..33e93b74800c 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
>>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>>     
>> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf 
>>
>>     
>> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf 
>>
>> +  
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf 
>>
>>   [LibraryClasses.IA32.DXE_DRIVER]
>>     
>> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc 
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> index 38bd825c8bdc..f7a876353649 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
>>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>>     
>> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf 
>>
>>     
>> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf 
>>
>> +  
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf 
>>
>>   [LibraryClasses.X64.DXE_DRIVER]
>>     
>> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>>
> 
> 
> 
> 
>