From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mx.groups.io with SMTP id smtpd.web08.461.1617082441655057040 for ; Mon, 29 Mar 2021 22:34:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FGjnqTna; spf=pass (domain: gmail.com, ip: 209.85.216.44, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f44.google.com with SMTP id a22-20020a17090aa516b02900c1215e9b33so8847354pjq.5 for ; Mon, 29 Mar 2021 22:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=S9riwNam+mHQsexYMRQMfb5H4HXf1Fnd88frELpu5sI=; b=FGjnqTnalHjhlI+s+DfKPy05EreYmViHsdDaCLPi7jfuqebsxx0D56JKA+ozW/kXTf cWdWk3j/aLR5S4nhTbV4RqauJcutCL43GV1YVonzLU9R7yPpT0ASX80P0rBCmcLWjxEQ ZcNyPQGyYL1KsOjGz3WlyzaJqsMtHacNbqqGp5MlmpnFUTinJASVkYcTBKxmo26W2HkW jfcNTkzfZmVA/9eJw+aca5tKe4HYqTbnKvJfTGpjdYiUrWXIf2guUpSb/kkyaCYESeBN Q1Sj/8pgXTkqJhUAxlL7MUtTAQQmu3MWNQchcggJErMWrKK4qnV86a8GrKC7woILiWSA OmmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S9riwNam+mHQsexYMRQMfb5H4HXf1Fnd88frELpu5sI=; b=WKjxHRNo7Ryh4khYFMCgo9gDn+EBIxNEtN4FEW+oHXRCvnJ4CTnec65CqIpzR6dhDb M6EiqizBM486ecNitiFjaSwO4gFmmlDYgvmupjX+7COrYGwl4fcBsbWd8EznLDbNgrVG lgOiAFFNsas0OyIkWDMwSwLKUImSwnYtfwon1PlshiYh5Q22ECEJuUWiJ5Ov9x0Z6kso DzgbXqqkcSLNdQ//Kb/yuxvzXGWanbG+y/Vcsjed98d9JxRJPN7awy3lAbesttQ+gMYy M7x/mQw/YtyqmCY7cVVAaMj5Hqws9BUaLw9WWUPPOergz+yR4cJ9XMC+Gm2IRUxINH7w /6LA== X-Gm-Message-State: AOAM53265m38dkrMP7yFB+0TN/yRKVi70qjnRhytl9yxX7LNmLoZ1S94 a0/LslcZY62SRUa8CJqw5KI= X-Google-Smtp-Source: ABdhPJz+cs2mMQumy1PNWOA5u9jlX0YHkqCZXkB//iJLEpN/BtCw9fn2178eHXbs+ml8dqJAg/1M4g== X-Received: by 2002:a17:90a:69c6:: with SMTP id s64mr2579024pjj.37.1617082441233; Mon, 29 Mar 2021 22:34:01 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id q19sm19474003pff.91.2021.03.29.22.34.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 22:34:00 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe To: devel@edk2.groups.io, Michael D Kinney , Yi Qian , Zailiang Sun References: <20210316181038.1413-1-kuqin12@gmail.com> <166CE5170DFC6296.20382@groups.io> <166D812F2F3DA6EF.24375@groups.io> From: "Kun Qin" Message-ID: <8911c0ce-d710-ed54-a9df-87d6edfb9807@gmail.com> Date: Mon, 29 Mar 2021 22:34:00 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <166D812F2F3DA6EF.24375@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Michael/Yi/Zailiang, Would you kindly review the patch below? We can also ignore this one if the package is no longer maintained. Please let me know how you would like to proceed. Thanks in advance. Regards, Kun On 03/18/2021 10:51, Kun Qin via groups.io wrote: > Hi Michael, > > Could you please review this change and provide feedback? Zailing would > prefer to have your vote before finalizing the change. > > Any input is appreciated. > > Regards, > Kun > > On 03/16/2021 11:10, Kun Qin via groups.io wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 >> >> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc >> file to resolve new dependency by VariableSmmRuntimeDxe. The library >> interface is consumed by variable module to better support variable >> runtime cache feature. >> >> Cc: Zailiang Sun >> Cc: Yi Qian >> Cc: Michael D Kinney >> >> Signed-off-by: Kun Qin >> --- >> >> Notes: >>      v2: >>      - Added Michael K. to cc list [Zailiang] >> >>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + >>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 + >>   2 files changed, 2 insertions(+) >> >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> index 409f31c982d7..33e93b74800c 100644 >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> @@ -311,6 +311,7 @@ [LibraryClasses.IA32] >>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf >> >> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf >> >> >> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf >> >> + >> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf >> >>   [LibraryClasses.IA32.DXE_DRIVER] >> >> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> index 38bd825c8bdc..f7a876353649 100644 >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> @@ -313,6 +313,7 @@ [LibraryClasses.X64] >>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf >> >> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf >> >> >> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf >> >> + >> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf >> >>   [LibraryClasses.X64.DXE_DRIVER] >> >> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf >> > > > > >