From: "Laszlo Ersek" <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>,
devel@edk2.groups.io
Cc: leif@nuviainc.com, Alexandru.Elisei@arm.com,
Andre.Przywara@arm.com, Matteo.Carlini@arm.com,
Laura.Moretta@arm.com, nd@arm.com
Subject: Re: [PATCH v3 12/15] ArmVirtPkg: Support for kvmtool virtual platform
Date: Fri, 26 Jun 2020 15:26:46 +0200 [thread overview]
Message-ID: <892079c7-d79b-aa68-4fb1-880abe3af995@redhat.com> (raw)
In-Reply-To: <055dc4c0-2d23-68c8-9ac7-41f08a6be182@arm.com>
On 06/25/20 16:08, Ard Biesheuvel wrote:
> On 6/24/20 3:34 PM, Sami Mujawar wrote:
>> +!if $(ENABLE_NETWORK) == TRUE
>> + #
>> + # Networking stack
>> + #
>> + NetworkPkg/SnpDxe/SnpDxe.inf
>
> I think we have special .inc files in NetworkPkg now for this, no?
>
>> + NetworkPkg/DpcDxe/DpcDxe.inf
>> + NetworkPkg/ArpDxe/ArpDxe.inf
>> + NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf
>> + NetworkPkg/Ip4Dxe/Ip4Dxe.inf
>> + NetworkPkg/MnpDxe/MnpDxe.inf
>> + NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf
>> + NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf
>> + NetworkPkg/Udp4Dxe/Udp4Dxe.inf
>> + NetworkPkg/TcpDxe/TcpDxe.inf
>> + NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
>> + NetworkPkg/IScsiDxe/IScsiDxe.inf
>> +!endif
Yes, we do:
$ git grep -F '!include NetworkPkg/' -- ArmVirtPkg
In particular, SnpDxe is not useful (we don't have UNDI drivers on
ARM/AARCH64, which SnpDxe wraps):
!if $(NETWORK_SNP_ENABLE) == TRUE
!error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
!endif
Thanks
Laszlo
next prev parent reply other threads:[~2020-06-26 13:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 13:34 [PATCH v3 00/15] Kvmtool guest firmware support for Arm Sami Mujawar
2020-06-24 13:34 ` [PATCH v3 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver Sami Mujawar
2020-06-25 11:24 ` Ard Biesheuvel
2020-06-29 2:36 ` [edk2-devel] " Guomin Jiang
2020-06-24 13:34 ` [PATCH v3 02/15] ArmVirtPkg: Add Kvmtool RTC Fdt Client Library Sami Mujawar
2020-06-25 11:31 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 03/15] ArmPlatformPkg: Dynamic flash variable base Sami Mujawar
2020-06-24 13:34 ` [PATCH v3 04/15] ArmVirtPkg: Add kvmtool platform driver Sami Mujawar
2020-06-25 11:35 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 05/15] ArmVirtPkg: kvmtool platform memory map Sami Mujawar
2020-06-24 13:34 ` [PATCH v3 06/15] ArmVirtPkg: Add Kvmtool NOR flash lib Sami Mujawar
2020-06-25 8:45 ` Philippe Mathieu-Daudé
2020-06-25 11:19 ` [edk2-devel] " Ard Biesheuvel
2020-06-25 11:41 ` Philippe Mathieu-Daudé
2020-06-25 11:38 ` Ard Biesheuvel
2020-06-25 17:33 ` Sami Mujawar
2020-06-24 13:34 ` [PATCH v3 07/15] ArmVirtPkg: Early serial port initialisation Sami Mujawar
2020-06-25 11:42 ` Ard Biesheuvel
2020-06-26 9:23 ` Julien Grall
2020-06-24 13:34 ` [PATCH v3 08/15] MdeModulePkg: Fix constructor invocation ordering Sami Mujawar
2020-06-25 13:51 ` Ard Biesheuvel
2020-06-26 13:22 ` Laszlo Ersek
2020-06-27 11:37 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 09/15] ArmVirtPkg: GUID Hob for 16550 UART base address Sami Mujawar
2020-06-25 13:52 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 10/15] ArmVirtPkg: 16550 UART Platform hook library Sami Mujawar
2020-06-25 13:56 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 11/15] ArmVirtPkg: Add Kvmtool Platform Pei Lib Sami Mujawar
2020-06-25 14:05 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 12/15] ArmVirtPkg: Support for kvmtool virtual platform Sami Mujawar
2020-06-25 14:08 ` Ard Biesheuvel
2020-06-26 13:26 ` Laszlo Ersek [this message]
2020-06-24 13:34 ` [PATCH v3 13/15] ArmVirtPkg: Package dependency for MC146818 RTC Sami Mujawar
2020-06-25 14:08 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 14/15] ArmVirtPkg: Add kvmtool to package dictionary Sami Mujawar
2020-06-25 14:09 ` Ard Biesheuvel
2020-06-24 13:34 ` [PATCH v3 15/15] Maintainer.txt: Add Kvmtool platform reviewer Sami Mujawar
2020-06-25 14:09 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=892079c7-d79b-aa68-4fb1-880abe3af995@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox