From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web11.7683.1593178015795092527
 for <devel@edk2.groups.io>;
 Fri, 26 Jun 2020 06:26:56 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WGrBx6Fn;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1593178014;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=H9/2Y9IKj09rIoocXFa+q3FYsIfuP7f25x1pwrkVevA=;
	b=WGrBx6FnK3EdrpTeVackyEInD0/SFtFkuFX/1X4LkHjZhXEcenchtYh3Ajcf7+vvujCAFD
	3e9otCGpLOkDCmzLbF6hfgjA0OwsnOPHAzKo031PM19dnr2z8alOjH0CL/v2+xMq8s5D4I
	8Z9fOYtYfpK69zsVkqyZKnRfw7lSQZ8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-441-ImplFb2qM269c86NKFOxPQ-1; Fri, 26 Jun 2020 09:26:51 -0400
X-MC-Unique: ImplFb2qM269c86NKFOxPQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78FA8800D5C;
	Fri, 26 Jun 2020 13:26:49 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-178.ams2.redhat.com [10.36.112.178])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 96D2D100164D;
	Fri, 26 Jun 2020 13:26:47 +0000 (UTC)
Subject: Re: [PATCH v3 12/15] ArmVirtPkg: Support for kvmtool virtual platform
To: Ard Biesheuvel <ard.biesheuvel@arm.com>,
 Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: leif@nuviainc.com, Alexandru.Elisei@arm.com, Andre.Przywara@arm.com,
 Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com
References: <20200624133458.61920-1-sami.mujawar@arm.com>
 <20200624133458.61920-13-sami.mujawar@arm.com>
 <055dc4c0-2d23-68c8-9ac7-41f08a6be182@arm.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <892079c7-d79b-aa68-4fb1-880abe3af995@redhat.com>
Date: Fri, 26 Jun 2020 15:26:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <055dc4c0-2d23-68c8-9ac7-41f08a6be182@arm.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

On 06/25/20 16:08, Ard Biesheuvel wrote:
> On 6/24/20 3:34 PM, Sami Mujawar wrote:

>> +!if $(ENABLE_NETWORK) == TRUE
>> +  #
>> +  # Networking stack
>> +  #
>> +  NetworkPkg/SnpDxe/SnpDxe.inf
> 
> I think we have special .inc files in NetworkPkg now for this, no?
> 
>> +  NetworkPkg/DpcDxe/DpcDxe.inf
>> +  NetworkPkg/ArpDxe/ArpDxe.inf
>> +  NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf
>> +  NetworkPkg/Ip4Dxe/Ip4Dxe.inf
>> +  NetworkPkg/MnpDxe/MnpDxe.inf
>> +  NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf
>> +  NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf
>> +  NetworkPkg/Udp4Dxe/Udp4Dxe.inf
>> +  NetworkPkg/TcpDxe/TcpDxe.inf
>> +  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
>> +  NetworkPkg/IScsiDxe/IScsiDxe.inf
>> +!endif

Yes, we do:

$ git grep -F '!include NetworkPkg/' -- ArmVirtPkg

In particular, SnpDxe is not useful (we don't have UNDI drivers on
ARM/AARCH64, which SnpDxe wraps):

!if $(NETWORK_SNP_ENABLE) == TRUE
  !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
!endif

Thanks
Laszlo