From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web11.5932.1682060270117353733
 for <devel@edk2.groups.io>;
 Thu, 20 Apr 2023 23:57:50 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=EY4HNoXS;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id 4000C240204
	for <devel@edk2.groups.io>; Fri, 21 Apr 2023 08:57:48 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1682060268; bh=SLyvjvPSZOu+T2NUNBPWX9srpYrqyUmxIj7UVsrbjZI=;
	h=From:Subject:Date:Cc:To:From;
	b=EY4HNoXSM41mZB8lMUGZkZ1GBWmJdLMX5XpwxRrS0Grl6oDUkbR9FrGDbT1RN5EtN
	 6hRiGDA7sSFTnnFr0f812xOAN3WG4v0u0ctUlIsIpZxZ2i8YzXcLhTWiMLVLu+J6M2
	 eB+IaZpeB+5K+OHcynREGmss+whI+0dgFcrUZLFRhJBCciMhubi9YpkjEhvApHSGLq
	 7stSfe4wB2IbPFjNtm/GbxNXSdz29YMS3oIW9K1tmJJCOFUdSKFcptlpgFXQqScbGO
	 bJWd6/zgyfbVtFl84unVLdw387ogjynJ6euVl4cMPMaJoQePC9CGyyfmi70fsEdIlT
	 Qh3Jx3JRCNo1A==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4Q2lhm5724z6twX;
	Fri, 21 Apr 2023 08:57:44 +0200 (CEST)
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v5 02/10] MdePkg: don't set visibility to hidden
Date: Fri, 21 Apr 2023 06:57:44 +0000
Message-Id: <892F3684-76F7-4143-B938-9AA7A2D6F168@posteo.de>
References: <zd6ghzbnlau3gjmmm6fmjrwhrpok42hw374r6j66hofbkxqqoc@6w6nbdejngyy>
Cc: devel@edk2.groups.io, Yuwei Chen <yuwei.chen@intel.com>,
 Oliver Steffen <osteffen@redhat.com>, Bob Feng <bob.c.feng@intel.com>,
 Daniel Schaefer <git@danielschaefer.me>, Chao Li <lichao@loongson.cn>,
 Dongyan Qian <qiandongyan@loongson.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, Baoqi Zhang <zhangbaoqi@loongson.cn>,
 Leif Lindholm <quic_llindhol@quicinc.com>,
 Rebecca Cran <rebecca@bsdio.com>, Zhiguang Liu <zhiguang.liu@intel.com>,
 Sunil V L <sunilvl@ventanamicro.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Liming Gao <gaoliming@byosoft.com.cn>
In-Reply-To: <zd6ghzbnlau3gjmmm6fmjrwhrpok42hw374r6j66hofbkxqqoc@6w6nbdejngyy>
To: Gerd Hoffmann <kraxel@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


> On 21. Apr 2023, at 08:49, Gerd Hoffmann <kraxel@redhat.com> wrote:
>=20
> =EF=BB=BFOn Fri, Apr 21, 2023 at 06:01:11AM +0000, Marvin H=C3=A4user wrot=
e:
>>=20
>>>> On 21. Apr 2023, at 06:45, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>>=20
>>> =EF=BB=BFNot needed any more on modern toolchains, they are better
>>> in not creating a GOT without this trick.
>>=20
>> Hi Gerd,
>>=20
>> Thanks! Just out of interest, how did you test this and what were the res=
ults?
>=20
> Patch #1, adding a linker script assert as suggested by ard, then:
>=20
> * compile + test on my local workstation (fedora 37, gcc 12).
> * run CI
> * compile on some older distros:
>   - rhel-8 (gcc 8)
>   - ubuntu-18.04 (gcc 7)

Did you include NOOPT? GCC5 specifies USING_LTO for DEBUG and RELEASE, thus t=
he visibility would not be changed anyway.

If this works, I hope the series makes it in time for the next stable tag. :=
)

Thanks!

Best regards,
Marvin

>=20
> take care,
>  Gerd
>=20