From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 12565AC1244 for ; Thu, 9 May 2024 13:02:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PZftB8iyEMRlKDL7wrXjT0aVVct1U9MyY7yKpl7JTpA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1715259768; v=1; b=vMjWJKbcmJAEPM2uGF+MAb3eMU3Nf1Ckbf4q0hTV3KT3J+e560DUcIMRNIbM9uMq25Drn8f+ LmxweCfJH2SDNkSXKtg7EZh1WtR3RoGh6irndXviBShxG8exrznHNul5fnE5m634cHWbyWQwFsG jMD5EiAwOroGHkzBkBNbo8eCVIdpMM7skvmy0lteEc7G8iFEqbclox6i7koVkMnbz31m8qSk8+J o4nZeYWAtRXkHAC3RDzac4DfTSv+1iS1wWIvBRhT1VRMTGHiJ9M0fa4bQlcWoOJY6PB6dzHRQVH KPUKkYzVPzxSKFLaS6EfpVjAv3Tl+Pt4rEgkH0Cda8ckA== X-Received: by 127.0.0.2 with SMTP id s9bsYY7687511xSfbXiFRBKA; Thu, 09 May 2024 06:02:48 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.81]) by mx.groups.io with SMTP id smtpd.web10.9895.1715259767409932516 for ; Thu, 09 May 2024 06:02:47 -0700 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by SJ2PR12MB8009.namprd12.prod.outlook.com (2603:10b6:a03:4c7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.47; Thu, 9 May 2024 13:02:34 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d%3]) with mapi id 15.20.7544.047; Thu, 9 May 2024 13:02:34 +0000 Message-ID: <8934fec2-fcf8-47de-a34e-6c5a77241ce0@amd.com> Date: Thu, 9 May 2024 18:32:27 +0530 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItc3RhYmxlMjAyNDA1IFJFU0VORCBQQVRDSCB2MiAxLzFdIER5bmFtaWNUYWJsZXNQa2c6IEFkZHMgaW50ZWdlciB0byB0aGUgQU1MIHBhY2thZ2Ugbm9kZQ==?= To: gaoliming , devel@edk2.groups.io, sami.mujawar@arm.com Cc: 'Pierre Gondois' , 'Leif Lindholm' , 'Andrew Fish' , 'Michael Kinney' References: <5A6ABFE2-1B83-46DD-B33F-68F3510FA421@arm.com> <000101daa20d$8ba8a1d0$a2f9e570$@byosoft.com.cn> From: "Abdul Lateef Attar via groups.io" In-Reply-To: <000101daa20d$8ba8a1d0$a2f9e570$@byosoft.com.cn> X-ClientProxiedBy: PN2PR01CA0208.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:e9::16) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|SJ2PR12MB8009:EE_ X-MS-Office365-Filtering-Correlation-Id: 515d12de-8a3e-4dfd-926c-08dc70284b16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?ejJ5Q0JGaXNBTlJjV2liZEhuZEYrbFhTWVNIRUpNeHlxNHNWVklhWmRXUnNo?= =?utf-8?B?OVRwOVRROGE2RzRGUFcrUXdjanpmalp2ZkpPSHNiMTNXV25YMkNUcEp6bkhB?= =?utf-8?B?dzRQdUYzdXUyblp3bXNCM0dYTUo3SS91VkZPZmlvSjF1c1g0QmhBbGxCSHdB?= =?utf-8?B?Q0V0UWxMOE96YmcrRElTL2luR3NGVWpoQXp4V0oxc3Z5MVMyakhLb2xNTG1X?= =?utf-8?B?NHo3NTZ6QlBTVkNwV0wyWkVkL05ONnZ3RDNVMnc0S3lObXFkSEdYLzdlL0NE?= =?utf-8?B?dktCdXFaSW5idERmK290djZMZEc5NlM4eWNCUWNtRFduQ2F1YlB6QmtwTG5l?= =?utf-8?B?SC9HKzMwRTdVSXdVNURWR1hyT0xtRURwZWMwUVY1T0V2WlEybWhmZzFGRENI?= =?utf-8?B?RnZvY1pYMkRzb1VIMmx2YS9maEEyTmtQeVJxWWx4eXhucVFrQW9HMEZQdnNZ?= =?utf-8?B?ekJpQ1ZEVk0wSU1EMVMyMTVvZFZBZ1h1anZzaXhWV2w0djFJRCtWNVJYMkhL?= =?utf-8?B?cGFpUDJOU1Z5TUxtdUVqWGx3Wmg0SUViZVRZOWxtZVRIQVpOSXQrVkxHYnhB?= =?utf-8?B?SzV5NFlOOUNtTm5JZi9IcmNvZ2M2WUg4RmNOUnZnYnkvenFxV28xZ3kxd1o3?= =?utf-8?B?TGxsN2tUWlFuRGxuMlN3Z25tRURINmlJcXFPRzJ5UTdIK0RVWjd6NlUrb3pz?= =?utf-8?B?YkFVSzgyQUNyQ1J4bTlObERHWmpQZUQ3bG5PVmxHSkhqelV0NjlhMS80ZzlL?= =?utf-8?B?VDJWeTErUXpXMTUxQ2Nnb2VKaFBzWVVxWU4yT0dNaENKMWFJVzdjdWlxVGlt?= =?utf-8?B?bmVJSXM5SE40QkdBZ1QxM2twVE1qRUhOd1RkM1lVMXhzemNsU3Y5bmUvWEFt?= =?utf-8?B?NGpxN0RnUFpLNEhSelp0Y2FaUEcydTNDdlQraFpGSnFKMGFlVmtzT0RWMFhl?= =?utf-8?B?WWIvVUdYUUtEbmppKzNQQzFZZGdzbGVYN0Z2YVZnVkE4VlEzdkFNaXBDTmRV?= =?utf-8?B?NjZNZGd5enJ3bDZHTnFSVmFoenpnUER6SG5oN3RxYlBGQStBNi9IVmhDaE5r?= =?utf-8?B?U3pJSytHdnNRSi9yWVNCcUFYWUYvWnFBTVl0T0dhd2xHL2FtNEtCRm5xNVlh?= =?utf-8?B?TWt6Yzd0WWtNTGkrVldmd1YrZktrSVFpSlJTM081a3FPOW1LTE82MTJmMisz?= =?utf-8?B?b2I5SHVnNTR4U1ZlT2RYQXNjMFdDVmRuT1VRNlNQRlRLT1RFeldLQVBjWW9M?= =?utf-8?B?akdqWUhOM2tmcVB4bjE5V1E2d2l2RnF4Q3RoU0ptemdKUzUrajJ0eGY1OWJC?= =?utf-8?B?MVhsWit3UjZubUF0SHc5V0dISVd6c041UGtMVmF4aU1WbkxVUkxNU0ZoK3B5?= =?utf-8?B?cTFhR1lVcVJRL3M1M2tXaERvWHVEQ1BsUTRGMjdqNklXUlc2MUlIcnB3SVNz?= =?utf-8?B?VVJzdTB3TUc5amRkdUdya1VLa05BQmwvL1JLQlE2NWJiZUhEamd3TDM0eHEx?= =?utf-8?B?QlV0UUpKSnk3NlVsWk1mNkp3eS9xT2prb2cwRzBwYWtOSnhBeWJ2M3ZzTmxF?= =?utf-8?B?ZmIyQ0RrQ3k4algrMnhxMmduekgzanpRQ045MjBDM2VHR213T0tHclVna0Vl?= =?utf-8?Q?eyjTjniEJnKK5Zoe7wwRNBQpp+QphKWZQ7MTqvu9T5FI=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3A5Z3k1UVVhWkg1aEY2QXFjSFdjSFc0N0g2OWxOdlVFVVV2OEdCMzJiNW9B?= =?utf-8?B?c3hLbDFQbGtsQ3NmWTE0S0ZPdENqQmh6WXRsMXdKc1dWY3ZqLzc1VGpwMk0r?= =?utf-8?B?aGUvcWhpVWNwdlJweVZJQTNXNzRDaVhobTN1dHh2Zm55ZWx1Y1d4T0ozWUZH?= =?utf-8?B?V2xFT09Ca3hROHc4NGJodURNZzQzNEZwQ0tPV1NYS2FTQnJpTHFvTVo0ZW9Y?= =?utf-8?B?OWNZOFcvOGdHNFlzbWc2a2R1ZlZ1cnZKeDRjWmN4RkdlMmZGbHhrUENTM2g5?= =?utf-8?B?NStYcGRZWVAyTHRxaTdLVitVSlZRbUJyeTRaU2pwSzVNZ012dTJtNHF6VzZZ?= =?utf-8?B?NTBhQW1CeEVsM04rdHJ3dC9EcWdYbml1eGpyWTJ5Rk9sSi8vZ2NxRHJUQlZI?= =?utf-8?B?ZEJhVGV0TnU2UWRoQkJrTDdzK3NDeXAzMXNHWmlvY0J2dmJqRHFCZjU3NzVD?= =?utf-8?B?alhsQXJSc1hiWjhlWVZiWFpjY05OalhzaG1PR01WY2RNNWZ0QVhVS3d2a3k0?= =?utf-8?B?ZURUcWNKcks5MmdvRGxWVXpWdFhVK3BXSkY3bmU0RFJvRmI2WS9JenNoeE5p?= =?utf-8?B?cVVOZlZQb00weDM0YkpmYnRLbnE0SHdlL3ltR29MZHFBRG52RFFVdmFZeTV0?= =?utf-8?B?QmFTQzBsd3NTSElIYmlRTThwYUQ1Q3VBM2pYSjljUElqMEhEaGNwT0NPRDRs?= =?utf-8?B?ZkZrRERpQi80cUJXLzJKNmhURlZ4T1I5SGpVbXh3NlpiVFBuTElWdWwwODkr?= =?utf-8?B?ayt5UHArc2FYbG1yelRpTkVqdkFQbzVGNWwwMW16aFpwSzlKWnpoMmdSUCsy?= =?utf-8?B?VnRveVVPdHZ4Ri9raWY4ZHo0VCtWYkZxSk4wTmo5Qk9QSUxmcjZRU1plTWVL?= =?utf-8?B?WUx1Y0ZBMmJQOE8xUVJPYWkzNFYvaEQvbFY2S1loVmhFRHpHTXZxTnlHUTk3?= =?utf-8?B?YjlpZmN5ZGhYb01kK3JuWnVzZVYzb2djRGNBdWRBaS85OVpuM3ppWSsvb3lT?= =?utf-8?B?ZjhISU5rU2I5WXlJVHZsZC9tNmZUbDBlNkhRVjFGWW5jWllaQ2R3Tmx2S3Vn?= =?utf-8?B?bys3d2hBZ3lCRDRyaUNaRUFEZkVybENkdWl3MzRhRGxERFhJRXUrVkthZ05t?= =?utf-8?B?a1h2TStnYmJHeXEvdXBoc2U3VERkYS9qUlNDaWF3ck1VdG9TUjZIdmsrOUNU?= =?utf-8?B?R0IxL1E5UTZyQlQxM0hiWEV3aFJHY3JOa1ZZRGQ4QWhhb3d3MXM3UGhqeGFU?= =?utf-8?B?UlJJUTRKSTB1S0RCMDNLZ1JlbGUrNytwVm9USi8ya3lubUVvYkhwUitCOVMx?= =?utf-8?B?bUxUK0pGMEN6ZGtlbnhKcjRzbnlrTnlFbDd6UGE4YUpTdTN6R1FXeDkrNmJr?= =?utf-8?B?ZEt1VEI2a0pCWnQ4aENVREtLTGc1Q2Zoc0t5dnNYaGZKMzRGV01xZkRVdTBP?= =?utf-8?B?bzcrdGxhTnhWblFkVUJnV2pTRHl6M0JyWGw4aWtKRnY4ajZnUTJpVzBocUFy?= =?utf-8?B?QlhDUXVzZkxsV3FRdGFKOFRaOTlBbkpOUDBZVXhIUFNGYVBuYUxKOElhVlVR?= =?utf-8?B?clVqZ0Q0Yk9pWkQ1UzFwa3hkQVRCVW5Fa2VQVDJhZGNsbnl4bEtUeU55YzZ1?= =?utf-8?B?U3JzbDlHbkFqRnROa2RNcUhnMk9YbnZobldtS0pxcXJjZ3BtSVhJRGZNMUsz?= =?utf-8?B?Z2hOa0NHT25JRC9ST3RQVTdoaEpqelNKRHFJVkhVbXl1ZmN5OHNoQ24xYnQ3?= =?utf-8?B?WUdkY2tIQjMzclNqVXZlL3dtR1J6Z3lSMkhlNElzaVIxaTN4Zml6ZCtrTjk5?= =?utf-8?B?MVlEbm5ETkZ2N3FqakxFeEZyV3ZHRG9EWTYrMkQ2VFdHbGNkZzYvQU1pZWxN?= =?utf-8?B?L3FrWmR6bkFOQU1iSGpibnBrbnp5d3VCa0h4U05nd0psMXAvdlJRckdOajYv?= =?utf-8?B?WFNETk5yYWRpMmgzemkzMEh6QklxazNaOWZCOFNLUW94QXE2UG5xcWpUS1pR?= =?utf-8?B?ODdZTS9QZWp4TWdJVEh4d0xFNHZSRTl1UGZjL2ZZd0NFblp3L2N3bWNCK0c4?= =?utf-8?B?SndtZ2ZHc2wzVVNocnRqNjZka1VzR1BXUVQ4TU1BQVZCenlhNEE3amhNc2h5?= =?utf-8?Q?GZP9IM6ITvSE5ua7F6lXdf3Mr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 515d12de-8a3e-4dfd-926c-08dc70284b16 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 13:02:34.4109 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ctkQg43T6jEJLOzn9ZXc8whOO+dKKVMqRC16DGwN8Crfl9NsPZQCXmto7YEew4PuuJpNwZAZe1LOkOUJnXg4BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8009 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 09 May 2024 06:02:47 -0700 Resent-From: AbdulLateef.Attar@amd.com Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Mo84mboj5hEkgG6re1o1KRyNx7686176AA= Content-Type: multipart/alternative; boundary="------------rW5FI3Cs043k322OrOIPG87K" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=vMjWJKbc; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --------------rW5FI3Cs043k322OrOIPG87K Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Thanks Sami and Liming for quick response and creating the PR. PR looks good : https://github.com/tianocore/edk2/pull/5647/ Thanks AbduL On 09-05-2024 18:06, gaoliming wrote: > > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Sami: > > Thanks for your update. I agree Pierre reviewed this patch before the > soft feature freeze. So, this patch can be merged for this stable tag > 202405. > > Thanks > > Liming > > *发件人:*devel@edk2.groups.io *代表 *Sami Mujawar > *发送时间:*2024年5月9日18:18 > *收件人:*devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Attar, > AbdulLateef (Abdul Lateef)' > *抄送:*Pierre Gondois ; 'Leif Lindholm' > ; 'Andrew Fish' ; 'Michael > Kinney' > *主题:*Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] > DynamicTablesPkg: Adds integer to the AML package node > > Hi Liming, > > >What’s your comments for this patch? > > The patch was reviewed by Pierre at > https://edk2.groups.io/g/devel/message/118589 before the feature > freeze email was sent out. > > Pierre had some minor recommendations that Abdul has addressed in the > V2 patch. Ideally Pierre’s the r-b tag could have been carried forward. > > >Is this a required bug fix or new feature? > > This is adding a new feature by introducing a new API, and I think it > should not impact the existing functionality as such. > > So, by merging this patch the risk of breaking existing functionality > seems to be low. > > This patch looks good to me. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > > *From: * on behalf of "gaoliming via groups.io" > > *Reply to: *"devel@edk2.groups.io" , > "gaoliming@byosoft.com.cn" > *Date: *Thursday 9 May 2024 at 10:01 > *To: *"'Attar, AbdulLateef (Abdul Lateef)'" > , "devel@edk2.groups.io" > *Cc: *Pierre Gondois , Sami Mujawar > , 'Leif Lindholm' , > 'Andrew Fish' , 'Michael Kinney' > > *Subject: *回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] > DynamicTablesPkg: Adds integer to the AML package node > *Resent from: * > *Resent date: *Thursday 9 May 2024 at 10:00 > > Sami and Pierre: > > What’s your comments for this patch? Is this a required bug fix or new > feature? > > Thanks > > Liming > > *发件人**:*Attar, AbdulLateef (Abdul Lateef) > *发送时间**:*2024年5月9日16:39 > *收件人**:*gaoliming ; devel@edk2.groups.io > *抄送**:*'Pierre Gondois' ; 'Sami Mujawar' > > *主题**:*Re: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] > DynamicTablesPkg: Adds integer to the AML package node > > [AMD Official Use Only - General] > > Hi Liming, > >     This patch provides an API to add integer value to AML package node. > > Using this API user can create CXL device with two PNPID. > > Without this API user has to rely on static ASL files. > > This patch is required for platform who uses DynamicTablesPkg to > generate ACPI tables based on this stable release. > > Thanks > > AbduL > > ------------------------------------------------------------------------ > > *From:*gaoliming > *Sent:* Thursday, May 9, 2024 1:10 PM > *To:* devel@edk2.groups.io ; Attar, AbdulLateef > (Abdul Lateef) > *Cc:* 'Pierre Gondois' ; 'Sami Mujawar' > > *Subject:* 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] > DynamicTablesPkg: Adds integer to the AML package node > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Abdul: >   Can you give more information why this change is required for this > stable > tag 202405? > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io 代表Abdul Lateef > > Attar via groups.io > > 发送时间: 2024年5月9日12:49 > > 收件人: devel@edk2.groups.io > > 抄送: Abdul Lateef Attar ; Pierre Gondois > > ; Sami Mujawar > > 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] > > DynamicTablesPkg: Adds integer to the AML package node > > > > Adds an AmlAddIntegerToNamedPackage() API to generate AML code, > > which adds an integer value to the package node. > > > > Cc: Pierre Gondois > > Cc: Sami Mujawar > > Signed-off-by: Abdul Lateef Attar > > --- > > .../Include/Library/AmlLib/AmlLib.h           | 41 +++++++++++- > > .../Common/AmlLib/CodeGen/AmlCodeGen.c        | 67 > > +++++++++++++++++++ > >  2 files changed, 107 insertions(+), 1 deletion(-) > > > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > index 82d5464084..4427ab68fa 100644 > > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > @@ -2,7 +2,7 @@ > >    AML Lib. > > > >    Copyright (c) 2019 - 2023, Arm Limited. All rights reserved.
> > -  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > reserved.
> > +  Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights > > reserved.
> > > >    SPDX-License-Identifier: BSD-2-Clause-Patent > >  **/ > > @@ -1743,6 +1743,45 @@ AmlAddNameStringToNamedPackage ( > >    IN AML_OBJECT_NODE_HANDLE  NamedNode > >    ); > > > > +/** Add an integer value to the named package node. > > + > > +  AmlCodeGenNamePackage ("_CID", NULL, &PackageNode); > > +  AmlGetEisaIdFromString ("PNP0A03", &EisaId); > > +  AmlAddIntegerToNamedPackage (EisaId, NameNode); > > +  AmlGetEisaIdFromString ("PNP0A08", &EisaId); > > +  AmlAddIntegerToNamedPackage (EisaId, NameNode); > > + > > +  equivalent of the following ASL code: > > +  Name (_CID, Package (0x02)  // _CID: Compatible ID > > +  { > > +      EisaId ("PNP0A03"), > > +      EisaId ("PNP0A08") > > +  }) > > + > > +  The package is added at the tail of the list of the input package > node > > +  name: > > +    Name ("NamePackageNode", Package () { > > +      [Pre-existing package entries], > > +      [Newly created integer entry] > > +    }) > > + > > + > > +  @ingroup CodeGenApis > > + > > +  @param [in]       Integer       Integer value that need to be > added to > > package node. > > +  @param [in, out]  NameNode      Package named node to add the object > > to. > > + > > +  @retval EFI_SUCCESS             Success. > > +  @retval EFI_INVALID_PARAMETER   Invalid parameter. > > +  @retval Others                  Error occurred during the operation. > > +**/ > > +EFI_STATUS > > +EFIAPI > > +AmlAddIntegerToNamedPackage ( > > +  IN        UINT32                  Integer, > > +  IN  OUT   AML_OBJECT_NODE_HANDLE  NameNode > > +  ); > > + > >  /** AML code generation to invoke/call another method. > > > >    This method is a subset implementation of MethodInvocation > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > > b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > > index 22c2d598d0..89fa4e06f8 100644 > > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > > @@ -3871,6 +3871,73 @@ exit_handler: > >    return Status; > >  } > > > > +/** Add an integer value to the named package node. > > + > > +  AmlCodeGenNamePackage ("_CID", NULL, &PackageNode); > > +  AmlGetEisaIdFromString ("PNP0A03", &EisaId); > > +  AmlAddIntegerToNamedPackage (EisaId, NameNode); > > +  AmlGetEisaIdFromString ("PNP0A08", &EisaId); > > +  AmlAddIntegerToNamedPackage (EisaId, NameNode); > > + > > +  equivalent of the following ASL code: > > +  Name (_CID, Package (0x02)  // _CID: Compatible ID > > +  { > > +      EisaId ("PNP0A03"), > > +      EisaId ("PNP0A08") > > +  }) > > + > > +  The package is added at the tail of the list of the input package > node > > +  name: > > +    Name ("NamePackageNode", Package () { > > +      [Pre-existing package entries], > > +      [Newly created integer entry] > > +    }) > > + > > + > > +  @ingroup CodeGenApis > > + > > +  @param [in]       Integer       Integer value that need to be > added to > > package node. > > +  @param [in, out]  NameNode      Package named node to add the object > > to. > > + > > +  @retval EFI_SUCCESS             Success. > > +  @retval EFI_INVALID_PARAMETER   Invalid parameter. > > +  @retval Others                  Error occurred during the operation. > > +**/ > > +EFI_STATUS > > +EFIAPI > > +AmlAddIntegerToNamedPackage ( > > +  IN        UINT32                  Integer, > > +  IN  OUT   AML_OBJECT_NODE_HANDLE  NameNode > > +  ) > > +{ > > +  EFI_STATUS       Status; > > +  AML_OBJECT_NODE  *PackageNode; > > + > > +  if (NameNode == NULL) { > > +    ASSERT_EFI_ERROR (FALSE); > > +    return EFI_INVALID_PARAMETER; > > +  } > > + > > +  PackageNode = (AML_OBJECT_NODE_HANDLE)AmlGetFixedArgument ( > > + NameNode, > > + EAmlParseIndexTerm1 > > +                                          ); > > +  if ((PackageNode == NULL) > > || > > +      (AmlGetNodeType ((AML_NODE_HANDLE)PackageNode) != > > EAmlNodeObject)  || > > +      (!AmlNodeHasOpCode (PackageNode, AML_PACKAGE_OP, 0))) > > +  { > > +    ASSERT_EFI_ERROR (FALSE); > > +    return EFI_INVALID_PARAMETER; > > +  } > > + > > +  Status = AmlAddRegisterOrIntegerToPackage (NULL, Integer, > PackageNode); > > +  if (EFI_ERROR (Status)) { > > +    ASSERT_EFI_ERROR (Status); > > +  } > > + > > +  return Status; > > +} > > + > >  /** AML code generation to invoke/call another method. > > > >    This method is a subset implementation of MethodInvocation > > -- > > 2.34.1 > > > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose > the contents to any other person, use it for any purpose, or store or > copy the information in any medium. Thank you. > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118766): https://edk2.groups.io/g/devel/message/118766 Mute This Topic: https://groups.io/mt/105999922/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------rW5FI3Cs043k322OrOIPG87K Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Thanks Sami and Liming for quick response and creating the PR.

PR looks good : https://github.com/tianocore/edk2/pull/5647/

Thanks

AbduL


On 09-05-2024 18:06, gaoliming wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

Sami:

  Thanks for your update. I agree Pierre reviewed this patch before the soft feature freeze. So, this patch can be merged for this stable tag 202405.

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sami Mujawar
发送时间: 2024年5月9日 18:18
收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Attar, AbdulLateef (Abdul Lateef)' <AbdulLateef.Attar@amd.com>
抄送: Pierre Gondois <Pierre.Gondois@arm.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>; 'Andrew Fish' <afish@apple.com>; 'Michael Kinney' <michael.d.kinney@intel.com>
主题: Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

 

Hi Liming,

 

> What’s your comments for this patch?

The patch was reviewed by Pierre at https://edk2.groups.io/g/devel/message/118589 before the feature freeze email was sent out.

Pierre had some minor recommendations that Abdul has addressed in the V2 patch. Ideally Pierre’s the r-b tag could have been carried forward.

 

> Is this a required bug fix or new feature?

This is adding a new feature by introducing a new API, and I think it should not impact the existing functionality as such.

So, by merging this patch the risk of breaking existing functionality seems to be low.

 

This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

 

Regards,

 

Sami Mujawar

 

 

 

From: <devel@edk2.groups.io> on behalf of "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
Reply to: "devel@edk2.groups.io" <devel@edk2.groups.io>, "gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>
Date: Thursday 9 May 2024 at 10:01
To: "'Attar, AbdulLateef (Abdul Lateef)'" <AbdulLateef.Attar@amd.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>, Sami Mujawar <Sami.Mujawar@arm.com>, 'Leif Lindholm' <quic_llindhol@quicinc.com>, 'Andrew Fish' <afish@apple.com>, 'Michael Kinney' <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node
Resent from: <gaoliming@byosoft.com.cn>
Resent date: Thursday 9 May 2024 at 10:00

 

Sami and Pierre:

  What’s your comments for this patch? Is this a required bug fix or new feature?

 

Thanks

Liming

发件人: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
发送时间: 2024年5月9日 16:39
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
抄送: 'Pierre Gondois' <pierre.gondois@arm.com>; 'Sami Mujawar' <sami.mujawar@arm.com>
主题: Re: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

 

[AMD Official Use Only - General]

 

Hi Liming,

    This patch provides an API to add integer value to AML package node.

Using this API user can create CXL device with two PNPID.

Without this API user has to rely on static ASL files.

 

This patch is required for platform who uses DynamicTablesPkg to generate ACPI tables based on this stable release.

 

Thanks

AbduL

From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Thursday, May 9, 2024 1:10 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: 'Pierre Gondois' <pierre.gondois@arm.com>; 'Sami Mujawar' <sami.mujawar@arm.com>
Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

 

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Abdul:
  Can you give more information why this change is required for this stable
tag 202405?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abdul Lateef
> Attar via groups.io
> 发送时间: 2024年5月9日 12:49
> 收件人: devel@edk2.groups.io
> 抄送: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Pierre Gondois
> <pierre.gondois@arm.com>; Sami Mujawar <sami.mujawar@arm.com>
> 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1]
> DynamicTablesPkg: Adds integer to the AML package node
>
> Adds an AmlAddIntegerToNamedPackage() API to generate AML code,
> which adds an integer value to the package node.
>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
>  .../Include/Library/AmlLib/AmlLib.h           | 41 +++++++++++-
>  .../Common/AmlLib/CodeGen/AmlCodeGen.c        | 67
> +++++++++++++++++++
>  2 files changed, 107 insertions(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> index 82d5464084..4427ab68fa 100644
> --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> @@ -2,7 +2,7 @@
>    AML Lib.
>
>    Copyright (c) 2019 - 2023, Arm Limited. All rights reserved.<BR>
> -  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.<BR>
> +  Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights
> reserved.<BR>
>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>  **/
> @@ -1743,6 +1743,45 @@ AmlAddNameStringToNamedPackage (
>    IN AML_OBJECT_NODE_HANDLE  NamedNode
>    );
>
> +/** Add an integer value to the named package node.
> +
> +  AmlCodeGenNamePackage ("_CID", NULL, &PackageNode);
> +  AmlGetEisaIdFromString ("PNP0A03", &EisaId);
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +  AmlGetEisaIdFromString ("PNP0A08", &EisaId);
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +
> +  equivalent of the following ASL code:
> +  Name (_CID, Package (0x02)  // _CID: Compatible ID
> +  {
> +      EisaId ("PNP0A03"),
> +      EisaId ("PNP0A08")
> +  })
> +
> +  The package is added at the tail of the list of the input package node
> +  name:
> +    Name ("NamePackageNode", Package () {
> +      [Pre-existing package entries],
> +      [Newly created integer entry]
> +    })
> +
> +
> +  @ingroup CodeGenApis
> +
> +  @param [in]       Integer       Integer value that need to be added to
> package node.
> +  @param [in, out]  NameNode      Package named node to add the object
> to.
> +
> +  @retval EFI_SUCCESS             Success.
> +  @retval EFI_INVALID_PARAMETER   Invalid parameter.
> +  @retval Others                  Error occurred during the operation.
> +**/
> +EFI_STATUS
> +EFIAPI
> +AmlAddIntegerToNamedPackage (
> +  IN        UINT32                  Integer,
> +  IN  OUT   AML_OBJECT_NODE_HANDLE  NameNode
> +  );
> +
>  /** AML code generation to invoke/call another method.
>
>    This method is a subset implementation of MethodInvocation
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> index 22c2d598d0..89fa4e06f8 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> @@ -3871,6 +3871,73 @@ exit_handler:
>    return Status;
>  }
>
> +/** Add an integer value to the named package node.
> +
> +  AmlCodeGenNamePackage ("_CID", NULL, &PackageNode);
> +  AmlGetEisaIdFromString ("PNP0A03", &EisaId);
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +  AmlGetEisaIdFromString ("PNP0A08", &EisaId);
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +
> +  equivalent of the following ASL code:
> +  Name (_CID, Package (0x02)  // _CID: Compatible ID
> +  {
> +      EisaId ("PNP0A03"),
> +      EisaId ("PNP0A08")
> +  })
> +
> +  The package is added at the tail of the list of the input package node
> +  name:
> +    Name ("NamePackageNode", Package () {
> +      [Pre-existing package entries],
> +      [Newly created integer entry]
> +    })
> +
> +
> +  @ingroup CodeGenApis
> +
> +  @param [in]       Integer       Integer value that need to be added to
> package node.
> +  @param [in, out]  NameNode      Package named node to add the object
> to.
> +
> +  @retval EFI_SUCCESS             Success.
> +  @retval EFI_INVALID_PARAMETER   Invalid parameter.
> +  @retval Others                  Error occurred during the operation.
> +**/
> +EFI_STATUS
> +EFIAPI
> +AmlAddIntegerToNamedPackage (
> +  IN        UINT32                  Integer,
> +  IN  OUT   AML_OBJECT_NODE_HANDLE  NameNode
> +  )
> +{
> +  EFI_STATUS       Status;
> +  AML_OBJECT_NODE  *PackageNode;
> +
> +  if (NameNode == NULL) {
> +    ASSERT_EFI_ERROR (FALSE);
> +    return EFI_INVALID_PARAMETER;
> +  }
> +
> +  PackageNode = (AML_OBJECT_NODE_HANDLE)AmlGetFixedArgument (
> +                                          NameNode,
> +                                          EAmlParseIndexTerm1
> +                                          );
> +  if ((PackageNode == NULL)
> ||
> +      (AmlGetNodeType ((AML_NODE_HANDLE)PackageNode) !=
> EAmlNodeObject)  ||
> +      (!AmlNodeHasOpCode (PackageNode, AML_PACKAGE_OP, 0)))
> +  {
> +    ASSERT_EFI_ERROR (FALSE);
> +    return EFI_INVALID_PARAMETER;
> +  }
> +
> +  Status = AmlAddRegisterOrIntegerToPackage (NULL, Integer, PackageNode);
> +  if (EFI_ERROR (Status)) {
> +    ASSERT_EFI_ERROR (Status);
> +  }
> +
> +  return Status;
> +}
> +
>  /** AML code generation to invoke/call another method.
>
>    This method is a subset implementation of MethodInvocation
> --
> 2.34.1
>
>
>
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#118766) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------rW5FI3Cs043k322OrOIPG87K--