From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.12886.1605806946989788492 for ; Thu, 19 Nov 2020 09:29:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YJcMuOPq; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605806946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ktqTO1dg9P7HT5dXIHTMl6e77p83jW0+Q3GpqgogYf8=; b=YJcMuOPqZm7RUS+oNAhgKhqMiXcWZyk4qMl7UwxTBCbBlmb+bfmBgcCq3jphnKACyZEba+ HiShHOtdi4Brp7Omf3EGB9Okmn0XfNWoJHLYAhg1vOzSp388QTxzRv3aODtfwVNRWZc+hj fLD8uibnoEToMB9CCwpjchpNIek79IQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-Cv06OFq8M5aIOFjV_OuaKg-1; Thu, 19 Nov 2020 12:29:01 -0500 X-MC-Unique: Cv06OFq8M5aIOFjV_OuaKg-1 Received: by mail-wm1-f70.google.com with SMTP id g3so2538560wmh.9 for ; Thu, 19 Nov 2020 09:29:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ktqTO1dg9P7HT5dXIHTMl6e77p83jW0+Q3GpqgogYf8=; b=MDClwIAtUHuKHnpY29eRlM8OMByg726oVCS2XeQ20UZ2O5BRGYMTtq9q4wGKTs7/JY PI3YPlB4HJkQ2USfuOSRtC36+r0o6m0TzUH6Bd6nPQzg/70lGeorRvneXAiVVDg76HU2 ArP7D1XLzBd5gdftU3How55zI3qxNBTDhFeY0fnr2PUKVlMZ3udhSRmvUBmREF/rfOXK p9TDO3oH838vyISWu1B+CifltOV3dT62LM8EEgr4o01GnaUmPJRccl/d6h2hxCRfl947 KpFcYf/7nULzrnXg2TpbTpGhU0JdLP7AfpLXbqyLZofUW2X7qfcLE4ZtH3Q54hptqw/7 XjYg== X-Gm-Message-State: AOAM531ChMAQ0GWAAZnqlON7zDyjKU2l7F4SXE4VGgJ6f2ESs64+VUAn xGcbW7AEBTlo4ZGrKd3PBC4wZx6mGK0RMeWIePy2xKOiB8RALJUAc81f0Q6fPbgxjuntA3bOPh7 h90fLKEsKyd/RXw== X-Received: by 2002:a5d:4690:: with SMTP id u16mr11920452wrq.263.1605806940328; Thu, 19 Nov 2020 09:29:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwfRlInNhjVpgwhBM3UoexoNXLVDt3x8CwUSa1JLONt3v51u6qT1gWeuKx654uFPVZ4sQJjPw== X-Received: by 2002:a5d:4690:: with SMTP id u16mr11920423wrq.263.1605806940097; Thu, 19 Nov 2020 09:29:00 -0800 (PST) Return-Path: Received: from [192.168.1.36] (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id p19sm793626wrg.18.2020.11.19.09.28.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 09:28:59 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. To: Pete Batard , Andrei Warkentin , devel@edk2.groups.io, Bret Barkelew , Dandan Bi , Jian J Wang Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, Liming Gao References: <20201119000145.1234-1-andrey.warkentin@gmail.com> <7947adcb-e711-f52e-087a-096f52d40686@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <894fb881-eb07-8a91-d7f0-7fe372c87359@redhat.com> Date: Thu, 19 Nov 2020 18:28:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <7947adcb-e711-f52e-087a-096f52d40686@akeo.ie> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/19/20 6:14 PM, Pete Batard wrote: > For reference, this breakage was introduced with edk2 commit > https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a > (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). It is better if Andrei Cc the developers involved (Cc'ed them now). > > It'll probably be worth adding a reference to it in the commit message > during integration. This can be added before the S-o-b: Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") > > With this: > > On 2020.11.19 00:01, Andrei Warkentin wrote: >> Add VariablePolicyLib and its dependency. >> >> Testing: Pi 4 boot. >> >> Signed-off-by: Andrei Warkentin >> --- >>   Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >>   Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >>   2 files changed, 6 insertions(+) >> >> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >> b/Platform/RaspberryPi/RPi3/RPi3.dsc >> index 325d7bdb..9408138d 100644 >> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >> @@ -169,6 +169,8 @@ >>     >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> >>   !endif >>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> +  >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >> >> +  >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >> >>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>     [LibraryClasses.common.SEC] >> @@ -218,6 +220,7 @@ >>     >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>     EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>     ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >> +  >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >> >>     !if $(SECURE_BOOT_ENABLE) == TRUE >>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >> b/Platform/RaspberryPi/RPi4/RPi4.dsc >> index c994f56d..4e5a36ed 100644 >> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >> @@ -169,6 +169,8 @@ >>     >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> >>   !endif >>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> +  >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >> >> +  >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >> >>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>       # >> @@ -226,6 +228,7 @@ >>     >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>     EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>     ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >> +  >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >> >>     !if $(SECURE_BOOT_ENABLE) == TRUE >>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >> > > Reviewed-by: Pete Batard >