From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.11734.1612883513204447122 for ; Tue, 09 Feb 2021 07:11:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=K5rFdUt6; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0674d93a3b=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 119F3SBo012057; Tue, 9 Feb 2021 15:11:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=y89q+azYN0nGc7ObB4jsUuSEi3QtZCeEulDG3cmE31s=; b=K5rFdUt6InTUO6TgPNEBh8GxSGRV52NQTp1exvrEFXstlEhEvuUn3rsWprgm22e0zmBz TPhA6ihYo+aDC9r0guIBni5EWkj52HjhUlwlW+yVbADNiMi/Q5pgaZQnzkM687jY2Ef6 PguXudfF6hEMOfzcDAe4PBBG/CKFinS8nO5GhnsJX9jInSQ3jI4EXIz8vvhAEAupHUVN jtxxvRd0rWRR7lhoiT9C0OD3qg/hLpwqiS6D2+ERm7Na6/36Sdzz6RvWCF5MULknaPtz Kf+o5ZGi1gDsv6xTCg1JfF674UKdPgs4fXObFiGHgTEhnqvkQcgDysGEjsNsKY9Wcp64 og== Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0a-002e3701.pphosted.com with ESMTP id 36kv6h0ccp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Feb 2021 15:11:33 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id 19563AA; Tue, 9 Feb 2021 15:11:32 +0000 (UTC) Received: from G4W9333.americas.hpqcorp.net (16.208.32.119) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Feb 2021 15:11:31 +0000 Received: from G1W8106.americas.hpqcorp.net (16.193.72.61) by G4W9333.americas.hpqcorp.net (16.208.32.119) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Feb 2021 15:11:31 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (15.241.52.13) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 9 Feb 2021 15:11:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RCq3IYnI6QBwsXVETfgOX/Kas/73KjnUnYIfIDygjLzCbtFx+bM5QiRkrXYKD60KQsWyzsJfN2jcVWvY8mjNUrhDz45RDyK/+09VI3c5gnw9Sj/LzY/nW+Z9GmAjJglOdqWwIw3U2s6AzHwvCsNV3FzOkLp33i0hjhOePSL8Exa5o53GvqHif/2bMVBZ7GEnb9urA0NZFnxgzmqlJvRt3ZoHeCzQw3rv6Ws1NtNUOBQyiFskxz9q2nSZ7lTSdZ469aR38J1mQXauaXQMzV3XQG8mW47lGN1UzpZjn1JTiBvQCcMHdozy5afpQLLr54DbNlgTlZQyDCtTr09pHUkRcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y89q+azYN0nGc7ObB4jsUuSEi3QtZCeEulDG3cmE31s=; b=ADtxEo2ZDFmPMRmzYDDuwD6m4LC8lRDi8blBrOlmX1tmBkBdh44chw338zUl0BDVkcVUl9Cxqka0ZVGjO0/cQNFcZkxApNC2KKv+jp2U8/ahJzgv5p2pWcVyluqp5VS7s5dRWVzKP3m9z+87YlMi37uP/equNgrSGGCQ0SpCrG+miIJeuqd1BlySZ36kvv8QRacGbue0diYBuHt74nmCUcumd5ftXl/hcpNuPGh8IsdvMLCUn1mDfS6dLiQ5Zc+6SD2Xf1LWkpmJ4iq4cHHX9q/onXf2T30b8bY6KtuPUfSKHCRm+1orebKfRtEb2zSfqzeGZKg2WHwWJliroJGq7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB0396.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7607::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25; Tue, 9 Feb 2021 15:11:29 +0000 Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::45f0:20e7:1e33:e2a0]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::45f0:20e7:1e33:e2a0%9]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 15:11:29 +0000 Subject: Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources To: Leif Lindholm , Heinrich Schuchardt CC: , Abner Chang , Gilbert Chen , Eric Jin , G Edhaya Chandran , Barton Gao , "Samer El-Haj-Mahmoud" References: <20201201161752.23734-1-daniel.schaefer@hpe.com> <20201201161752.23734-3-daniel.schaefer@hpe.com> <20201202120436.GE1664@vanye> <7741f08d-efeb-e959-7118-fb74474e3424@gmx.de> <20210209124219.GG1664@vanye> <5e8de9b9-17cc-65c5-1b47-e3f087f8ce85@gmx.de> <20210209145813.GI1664@vanye> From: "Daniel Schaefer" Message-ID: <895280c7-4172-a936-f091-bf1a0fb852d3@hpe.com> Date: Tue, 9 Feb 2021 23:11:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <20210209145813.GI1664@vanye> X-Originating-IP: [123.193.51.23] X-ClientProxiedBy: HK2PR04CA0044.apcprd04.prod.outlook.com (2603:1096:202:14::12) To DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.21] (123.193.51.23) by HK2PR04CA0044.apcprd04.prod.outlook.com (2603:1096:202:14::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20 via Frontend Transport; Tue, 9 Feb 2021 15:11:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 382c337a-2aea-4f15-0261-08d8cd0cfa4f X-MS-TrafficTypeDiagnostic: DF4PR8401MB0396: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2J87afbEgIlecvQEns4ZUGUsvpGlGYNLc/HokmsUDZJhK5r1WJltzWhe+IoXn9EqPw6aq4o1aWl+stOnrUegaKWxNWmr8NoBeoHCwIpsMElLgLjE4J2wyDbzAZWJgMt8NTpz9VKcnmyasDwNzoz3sU1rFlkmjjQquJFyHQHE1/pNk+uk8SNPbxwXY2YmJzA3lEg2VQg3R1oaGa4+PLctpaDQBycDwRt3lQDxGOapv8exGPrY+JNiMIABdxhaV0Pti9xkhQuyX9ZKUehkT09orgpg8Kq8HDrQJKJAhVjGosKGP7+kCoX8rMlbxY/OjjL9Hv+U+h4QvRHLnJz0OdTj46O/IKrXZFoejLElNmngwR/cC+egZoF3hx3q4Un9G8943EzabtV4KYt6gCqQdhpA4ezARz9QsQA8gevUdLW0eTC0Z+6H8iU/d5beMMt+pEXScVw8MBQAjSaHuuOyPZAKPf0zh6c7JWr/3BARjuh9R44iLI+Vnfr14lyL/dQ3pE5BwHGG18PguIAl0EEinMZawvb99335fKuq4Gmh//Zab2ZDfaR21UchIeK1PsxA+goPUqgjAwTro6L5YuH0/T3JGVCgiNfHLGWCdGE5Fm60NEScMgdXPh2xLSUVLaCqR/iPvJdMiqWlZAv2dIcMm/9Bog== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(376002)(366004)(136003)(39860400002)(346002)(6666004)(66946007)(66476007)(53546011)(5660300002)(66556008)(316002)(31686004)(44832011)(478600001)(16526019)(110136005)(54906003)(52116002)(8936002)(8676002)(16576012)(36756003)(86362001)(26005)(6486002)(186003)(2906002)(2616005)(31696002)(956004)(4326008)(43740500002)(45980500001)(6606295002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?c2NBOFlyV0E5WmFtZDBRa2w0TlU5eFlFeDJvaUw0Y2ZiU00yVE5PM0VpK21x?= =?utf-8?B?SFhZT1pkcFZDanAwQzNFT0NkREtLTEMvcGwrUm1VUExaWlBYOG0zdlk5alJT?= =?utf-8?B?S0loZ0kyR0VOek5TWnlMZTZzVTdia1BZTkVzRnUreGxPNmJGSjFUektVNStt?= =?utf-8?B?QzRlK1RlaEZFL2tCcU5Rdy9rczZoUGkxOFcxTWRtUENFS2oxU1V3Ui9oNHp5?= =?utf-8?B?RjBmdkVSSURsbStOemZHaUJTYUZuejlmRSt6aUwzWDNUVEFkRTJmUUVtdWpB?= =?utf-8?B?S0RNUVB3bXpsL2VFcGprUjQ2Y3cxaCs0LzkwZGFIUDcxT3JpbUZoaFNTVVQx?= =?utf-8?B?SEkxRXl3cmZ2QmtkRlhYUTBGSll2RGd0NDVxVVFsbk9SaTNpUldYT1ppS2xQ?= =?utf-8?B?bCt0T3FWMEJINXJON3paZU85UDhFdCsraGw1YWkzaFJvVnlhZFRlT2hCZERV?= =?utf-8?B?a3VvTkZoKzJUUzUzU3FCSHNDcktJTWhPQlFuY2RhdHF1dFBURVNYb3RybW04?= =?utf-8?B?b2E0QWZHZWJCTUt2RTlwM0lSU09YTHhDdTVCeDRHUkxuSjhDV0lYMERHaXhu?= =?utf-8?B?QUYzd1ZLNks4dlpoTmFUNnd2MzYzcDV6c3gyRzVBaWhEUWhiZEJ0MmVDamwz?= =?utf-8?B?WkhjK21LU3NoUHJ0OEJoejBMdnVqS0xzS21HbFVHTXZpcjJqZ1pXQlN1Tk1u?= =?utf-8?B?Sy9sYkxjN1ZaSkNEeFE5RndkUXkvd09GdTNVTjVkNHNNaFhxdExOV09NNVdC?= =?utf-8?B?Qy8vclozSStXbXdRQlpsZTMwUkxwM3BhLzRRYXEvZzM0Ry9EM0Q1U0FLQWov?= =?utf-8?B?endvR25KckYyc05tZ0UwZDVWWVFzUncvWWZBeWwwalBZNUw3WEhzT0RCRWRw?= =?utf-8?B?THZsWHJCdmJhZkhhaG9vaVVTcUNYVnVPMEpXaWVZUXUyMEthTHJmOHJJSU5B?= =?utf-8?B?Q2l5dlZHN2h1emFsd3A5NUxYRDR6L0dEcWlvUDJCajc1eHZOVFlEOEZSMVJJ?= =?utf-8?B?YmlhSW1HR1VNRmxMdWFMMHRhT3BCMmpJMCtndW5ITFQ4NjhvQTVSOUYybzdX?= =?utf-8?B?ZUpyVjdxdXJzYy9jOHlMUlRYRGNvME14ZDlxMUZSQ0k1a0dCd2NzUlBMZTV0?= =?utf-8?B?VlZXY3FDOVBuWHIrM2hnSmRjT2t4QndWekdTa2p1VzVOeStKZlJKZm5VblFK?= =?utf-8?B?WlY0cHVNYWtCYTd2RXlJZmVxWnJadEJNV20zNjE4TjczbEpORWVLbjlnOFdL?= =?utf-8?B?WkYzWUhXT3VReURTVkNiTEx4eG1oZjZpL2dSTm8zeWcyTFFrbFp4OGQwOVpv?= =?utf-8?B?MGxrRWJSSG05VGhacHYwcjVkalVENFBWejZSa1JqUWcrZ2hMQTkveTlMbm5q?= =?utf-8?B?c3RHbFlURDBDN01MLzNGbm9oWE84QUNZdWVtTVhMU3lOeGFITUtIUGxtQnhZ?= =?utf-8?B?Tmo4ZHhNVEVDRjNJd2VqRE1La0YvRGFBbml1TUhhVmZudnBoekZDM01wWHN0?= =?utf-8?B?bm90c3VzandpQlJmT2pOZDE2cWNBZEN0NUVyYkg4TFM3VlhFTndmai9PYXVv?= =?utf-8?B?U3ZuSWJvU0tCazQvRXIydzU4VWJDNnZWamwrMGRWaWxPektMMzZ1VFRnOHFK?= =?utf-8?B?SlJ5anhicmpzZHp4VkI3cWhublVzdlQzUDl6QVJqVkJHaEhFZjBERFR6cVBl?= =?utf-8?B?MVo4ZDh2UEdDdnREaXFOczE1SlJYQUZ0ell2S3lTenB4S0w1T0NKTG1aZ3BN?= =?utf-8?Q?vb+Wu7+r1qynPZkVrFGRkDo5V8/YIxXlZVkdlr3?= X-MS-Exchange-CrossTenant-Network-Message-Id: 382c337a-2aea-4f15-0261-08d8cd0cfa4f X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 15:11:29.8177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0BaUyZGwnbsm8bR9QuYQ66SazfHzSvgyff52KN13qWK9skD8wsHmSSFGf8w01OKJqUp3Za8FU/b3VTFYtaLxhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0396 X-OriginatorOrg: hpe.com X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-09_03:2021-02-09,2021-02-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 phishscore=0 impostorscore=0 mlxlogscore=817 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102090079 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/9/21 10:58 PM, Leif Lindholm wrote: > On Tue, Feb 09, 2021 at 14:47:46 +0100, Heinrich Schuchardt wrote: >>>>> I have no idea why the alignment would be 3 on other platforms, so I >>>>> don't know how to fix it. >>>>> If anyone knows more, please let me know. I'll just change the comment >>>>> to say Riscv64. >>>>> >>>>>>> +.align 3 >>>> >>>> Both on Aarch64 and on RISC-V an odd alignment value makes no sense. >>>> >>>> .align 8 should do no harm. But is it needed? No idea why it was added for Arm and Aarch64 copied it. It's not there for the other architectures. Let's remove it. >>> The glory of the GAS .align directive is that its meaning differs >>> between architectures and executable formats. On ARM/AArch64, as well >>> as on RISC-V (I think?) the alignment is described as a power of 2. >>> >>> So .align 3 on ARM and others are the same as .align 8 on x86 (ELF) >>> and others. >>> >>> (It might not be a bad idea to start replacing .align directives with >>> .baligh to reduce confusion.) >> >> Thanks for pointing out the different meanings of .align. They are >> documented in binutils-2.36/gas/doc/as.info chapter 7.3. >> >> .balign is GNU assembler specific. >> >> Do we have to consider other assemblers here? > > I don't think so. > The GNU family of toolchains are the only ones using .s/.S sources. > Unless there are GNU-compatible assemblers that don't support the > directive. > > Visual Studio uses .asm on ARM* and .nasm on x86. > > / > Leif >