Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

["Nhi Pham" <nhi@os.amperecomputing.com>]

Oops, sorry. I just realized :)

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,
-Nhi

On 14/07/2022 16:06, Sami Mujawar wrote:
> Hi Nhi,
>
> Looks like the file 
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not 
> in upstream edk2-platforms.
>
> See 
> https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/AmpereAltraPkg
>
> Regards,
>
> Sami Mujawar
>
> On 14/07/2022 08:40 am, Sami Mujawar via groups.io wrote:
>> Hi Nhi,
>>
>> I will do that no problem. However, we really need an edk2-platforms 
>> CI to catch such issues.
>>
>> Regards,
>>
>> Sami Mujawar
>>
>> On 14/07/2022 04:34 am, Nhi Pham wrote:
>>> Hi Sami,
>>>
>>> Could you help update for 
>>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well?
>>>
>>> Thanks,
>>> Nhi
>>>
>>> On 12/07/2022 21:40, Sami Mujawar wrote:
>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>>>
>>>> Add an instance for the library class VariableFlashInfoLib that
>>>> was recently introduced in MdeModulePkg. This allows the variable
>>>> driver to build successfully as it has a dependency on this
>>>> library class.
>>>>
>>>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>>> ---
>>>>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc 
>>>> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>>> index 
>>>> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 
>>>> 100644
>>>> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>>> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>>> @@ -154,6 +154,7 @@ [LibraryClasses.common]
>>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf 
>>>>
>>>>   !endif
>>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf 
>>>>
>>>> + 
>>>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf 
>>>>
>>>>       #
>>
>>
>> 
>>
>>