From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.130]) by mx.groups.io with SMTP id smtpd.web08.5459.1657789957959759014 for ; Thu, 14 Jul 2022 02:12:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@os.amperecomputing.com header.s=selector2 header.b=e3FNFnUv; spf=pass (domain: os.amperecomputing.com, ip: 40.107.94.130, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrSnc/02DWVYs4AdcVuiLEmBeu4/NqcbyxlY+7nkOLCP+hYPNe3tvuI5cvMScFhgATN6X1thHwRHrz1nH3UYrOvXHsWhRDvsqpLnIPap6WGo/4qNYLXeO9eovOW3lpa6VxWfMLSzf/vfzFcAZ3AsdW1cEAv4uh925nJm5+Ux03qgCvAMwq8qV38MKPmbnzLy/R2ZRhBT1UE4Y+X+ptUAB9ZC1UL+pAfv/XUs1ZWFyQF+6i7YHvTHAIQJ3kFk2AITQVkBwmdOWzx5IMx3lKWG2U5ZGjRc02ysMAS9xjAnJoK9CVF4spnYzv2ii1lfeUlKeNrdbXgs+v3YvSLu/S24eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2S4ggXsnaSxNjP/15ssZHzxO7w+SWvo25AY9Gui4+wM=; b=BFmnhD6thZZqJDHzZrh+9Gwi6yQHeFP6U7ZWmdKARTTf3K/3USggIZmGFwqHPECE8mFkUcS+SRV2JZPejk6MObY319IvA7OwuIxvH68mXLnOx1Q8oP7EX/K5UIhDaMMSMZ7+JpzWLLMhlRwhAqbawlr2G7hF772rmUj33tTPf87UjtrgkVGzpQAl6Uu6Gq2SiTrZP6/AzJKL4WacJKtu3po+YRJDfL1WlZ2tjEtE9TMktyblY98fhC+SdjflQFdt/aXAou2ulappc+gwpDFq0Xeimujk9dLr+r8Ola27HHoH+L96H2KyjWSWnvtvBj6/8qWYWttPCAc6oItsrVm+yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2S4ggXsnaSxNjP/15ssZHzxO7w+SWvo25AY9Gui4+wM=; b=e3FNFnUvVRG1BEuVeemVcbUCkhCXoQ0p48LWveNN8Dvqz0+ATWCPxTLszoXXqA0blgrdWZOGeS+r6CLF4Vliq88h4PRZCRVdXz15VYsYq43iwK8YHgPozq226MCp+tdqzTG5j2QpAkpoQfZSV0CVwuiu3EkY1hE5XJxjTAW0KwA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM5PR01MB2556.prod.exchangelabs.com (2603:10b6:3:3d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 09:12:35 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::b476:d1a1:cacb:d7fe]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::b476:d1a1:cacb:d7fe%9]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 09:12:35 +0000 Message-ID: <8952e54d-91c2-50d4-e669-e7ffd255770d@os.amperecomputing.com> Date: Thu, 14 Jul 2022 16:12:25 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib To: Sami Mujawar , devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Pierre Gondois CC: vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com, chuong@os.amperecomputing.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220712144047.3080-1-sami.mujawar@arm.com> <20220712144047.3080-9-sami.mujawar@arm.com> <1701A22D591971D9.31468@groups.io> <277daca6-2449-4a0d-3e96-205e730c36bc@arm.com> From: "Nhi Pham" In-Reply-To: <277daca6-2449-4a0d-3e96-205e730c36bc@arm.com> X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 759f3c46-9bc4-452f-319d-08da6578fd41 X-MS-TrafficTypeDiagnostic: DM5PR01MB2556:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9F8ZKQ4HV13ZrzWWt06/MTTyY3jEYT8qpuVp1koRZxmsR0eQY8b251IR0g0Sk7ackEgDXbLLbq0vltE9NrJXIiw43YjXNTD8YEyFh2B/XVnuVLQpHi5FuqNPd9AsxjTKM/vsXvuKo9bGwaN2DWdRv13SsKSmoOx9hunQFCrqGHiVlhMQ4FPqoI0MxS4jGIIIvNjc1nH35YN4tR1IzVkOO8fihrP6KKBQXWAm5P2Llf16WpcJqUCCqktdWhl0+/LLU7rtnk4sX0Rb80Ie8sGo/iddjBV8ACuGdWAtPLkXZ6Diwmh2gVX9efgn3T5NQlsa2D/YUVgmaen5ue80yLSlvqLtfodLuQ5PX6vORJXMYSXTKFY/sszv2EzDSDzmyBQWawYfRKNktHvuKp+6X+BaL44eEgdxJEno/FTYl/QnRIpHVi68WuIYHcnX8sowUI4wZiK2RcxLiVSi1rGWInyqoO/9fQd0kKq9XJ8pP7J946R1VOyI77/4xxVkEW9BVDPVzAg/+38fmy0M22VZMlMfARr5GSKahpE6RlezDXggZf1KbUHQZBNYr4lwBLqf42ojDDQwyNq1p1ZB3JfjMwh8IouvFtUmB8tFUMix7AdtliSV9Jh7etRCJr66b5m7YC2WO8qx+js6vnIKV279KA6itL10mKZFt+9sbFcPlL6I1/lqpETedvnTeiMUx2ydIvHydVxrN8WTUS5onlwRcvush7Kncx+OveFk/Rn/q1iphWmLHOIJ5QHtOCUAFObAaOEhKkRa7185RK0H8yqY5hOGgm1a0bnjaSSkfqfVMUydwWodnpfFjCNG+SshX7nrTHMmDNQ7zuECw+kbAgVUOYgQ3hFsjhW9sRDBRfkPrkHtwME+w42xgi6rpgpJu8LqYJaw X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(366004)(39850400004)(31696002)(83380400001)(2616005)(86362001)(38350700002)(478600001)(38100700002)(8936002)(5660300002)(2906002)(6666004)(41300700001)(53546011)(110136005)(6486002)(316002)(8676002)(966005)(186003)(31686004)(52116002)(66556008)(4326008)(6512007)(66946007)(66476007)(26005)(6506007)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hzWz5Quc0DA54Gaggz8MrXUg2loU7iV9Gpeate8Oh/l+NFzlCfWWP9YCqzzH?= =?us-ascii?Q?7svoDF+BD3MnzHQMBqCka9Wh6+CWuj53iqtXUJVTYmCEHIZFBKJED/2zK8nj?= =?us-ascii?Q?csb/qD1kBmsEF+VB0k0jLwDpWo2g493vxu6/MrpKye2VCRrFP6XvJKLLN95k?= =?us-ascii?Q?E/r+/7bZjJQ1mfx41usybPoCbwRsOVxO83U6UN78GZl9OvZp+SNNZmgE5ePi?= =?us-ascii?Q?zb2YmAtKrQ0DBtqqWzI/uHfax7SXLXo6t8PMnscXKjxWaX3otTUWcM04xBJd?= =?us-ascii?Q?6WXp6HsH93Z+XVQ38VyAym9KgtbECBsJXTfNUEJFiGomM+IwQ88FY7jeqH8f?= =?us-ascii?Q?TvxddT4B0oPabei5EFqYBNeuhWceVdHOx8ZMobx+6zbLYPiDnIb5KwYd+EXf?= =?us-ascii?Q?JDT3p/OTImJNuugHrImPXpwAHxmc2Lv0NFMK9XcnLK37BOGxZtCI+MqboI+B?= =?us-ascii?Q?QRYeZHF9E1OryTkC9nsmUEhjpVbMVthV0nI6ySiTyYWMo+THdIuHqvGGyCz1?= =?us-ascii?Q?g5N3E0U0dEezLIcOxqMmuS9ZGYHt8pHEZcKckA3LxXNjm2Vw1hvbKPwfgPQ9?= =?us-ascii?Q?KjUUcjEvtPKB1gTmZRNciXnEp+ST4kKCqZq/rWeiaDo67b94u2+3xAn2NdXl?= =?us-ascii?Q?MdSyQF5rDb98/Okfo7jmpW4NJk1iN/oaHZe9uUpSbRt14nmMe8/5aZPU5edQ?= =?us-ascii?Q?jkMCMKJu/agveirjTrBXoji6959DujFjbAhspIh/5SYwW7nsUr/zYhH3I3j1?= =?us-ascii?Q?bIVjPqPCra3U4nWyUkcfJCbS1u0+bw4dW7vJrNt8iyhxXRc2lwWRl1hI2/sV?= =?us-ascii?Q?PEWpqKfDpOSPfwhm8+H/3G4Z/nmZTPvcXrn2PFE9pn2BqfIVYQ3+4YuXqchS?= =?us-ascii?Q?MhrKgZydktRvfN5y3vs+BMRhWeouogIrbM8t19pUYA3ffRtyVVl/UaZE58ZJ?= =?us-ascii?Q?+c66RIcC2VVzwdAlRQ6uc3/O7xe8m6C1vWbLt72tPnD9xxz2pHAG6c7s3wFx?= =?us-ascii?Q?/vtRUGp5DW0RhMtm2Am02eKxdP3AgqqH4GVLWxAxBupIdO9cQytnEibPjw16?= =?us-ascii?Q?lM4SSUaKvpTOEfW9B29t6CRxyaR/1PbBGO4Sy1cOjsVd2QaVJZroONBSK9j2?= =?us-ascii?Q?NZfc40L164V4VFInCWaWpwGhXn0wdfObKUv3AuWLXVBpneEmkU7fquxypcLF?= =?us-ascii?Q?dOeoBuWSfnOB46BfVGOgKKlWe+nkhNk8E9obn6J80RWSQt6zlNNPcC69sLQq?= =?us-ascii?Q?fKPCZEF4cKAnEjOSSOg8m/056L/8P8LSP2bdFE843iiP1z0c32/hKY00XDHl?= =?us-ascii?Q?Lxckfk2XADwNubGvNGlpsrIiP6HeMBaRFx7yLV6e9l+pI1GyPA1M4sDFaZGN?= =?us-ascii?Q?xhWTevyybSCALrG+XSUkN/bmfDsGjX5NaxAYWyVdm6lBVG0ngphjBUb+7+TK?= =?us-ascii?Q?KI8FmAKHm146ykj2q+G55oRZmuAO0A79tvn++mYIZDHSbkVerKqa0FH5tqVt?= =?us-ascii?Q?vX/nGQZvsdD1nhFrrJqHWfGY7djweFER2FkG7A+yUnG1s1E1Atah69QuKNX4?= =?us-ascii?Q?bSyIoFkL9BQIcLBAR107ILnr1EY901NxIlQ6/arkQAyOLSmtLBNqnwGyhncY?= =?us-ascii?Q?CWbMrA/WCZgzcXwrolhJ0ys=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 759f3c46-9bc4-452f-319d-08da6578fd41 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:12:34.9328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: brn/t7Z03OBgVlx6f/m/Xtk0LHk96mhE5Ss343BZfErucSqKE6ocunZZ8pcPy+nQOyk7npaHZVis60AIrfjkC8eSDCMIcblrh+EkwZO2imQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR01MB2556 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Oops, sorry. I just realized :) Reviewed-by: Nhi Pham Thanks, -Nhi On 14/07/2022 16:06, Sami Mujawar wrote: > Hi Nhi, > > Looks like the file=20 > Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not=20 > in upstream edk2-platforms. > > See=20 > https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/Am= pereAltraPkg > > Regards, > > Sami Mujawar > > On 14/07/2022 08:40 am, Sami Mujawar via groups.io wrote: >> Hi Nhi, >> >> I will do that no problem. However, we really need an edk2-platforms=20 >> CI to catch such issues. >> >> Regards, >> >> Sami Mujawar >> >> On 14/07/2022 04:34 am, Nhi Pham wrote: >>> Hi Sami, >>> >>> Could you help update for=20 >>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? >>> >>> Thanks, >>> Nhi >>> >>> On 12/07/2022 21:40, Sami Mujawar wrote: >>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3479 >>>> >>>> Add an instance for the library class VariableFlashInfoLib that >>>> was recently introduced in MdeModulePkg. This allows the variable >>>> driver to build successfully as it has a dependency on this >>>> library class. >>>> >>>> Signed-off-by: Sami Mujawar >>>> --- >>>> =C2=A0 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + >>>> =C2=A0 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc=20 >>>> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >>>> index=20 >>>> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff1= 4d1727bd4fe4=20 >>>> 100644 >>>> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >>>> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >>>> @@ -154,6 +154,7 @@ [LibraryClasses.common] >>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL= ibNull.inf=20 >>>> >>>> =C2=A0 !endif >>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolic= yLib.inf=20 >>>> >>>> +=20 >>>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/Bas= eVariableFlashInfoLib.inf >>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/V= ariablePolicyHelperLib.inf=20 >>>> >>>> =C2=A0 =C2=A0=C2=A0=C2=A0 # >> >> >>=20 >> >>