From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ml01.01.org (Postfix) with ESMTP id 3328A1A1DF1 for ; Wed, 10 Aug 2016 22:59:43 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 10 Aug 2016 22:59:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,503,1464678000"; d="scan'208";a="1023493183" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 10 Aug 2016 22:59:44 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 22:59:42 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 22:59:41 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Thu, 11 Aug 2016 13:59:39 +0800 From: "Wu, Jiaxin" To: "Ye, Ting" , "Cohen, Eugene" , "edk2-devel@lists.01.org" Thread-Topic: DHCP Automatic Configure at Driver Connect Thread-Index: AdHzMrTK7bp7ndKxTJOq/Qc4XXghzQARlkIgAAQKA6A= Date: Thu, 11 Aug 2016 05:59:40 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274137C5EA3@SHSMSX103.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcxZjAzNzgtNTZkOS00MjFmLThlZmYtN2RlMGRjYjc5MzYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiIxemlJbDBzeFhhK1J6ZGw4eHBSMWZoS2dGQ1RTTGlMRFc2K3duczFWYXF3PSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: DHCP Automatic Configure at Driver Connect X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 05:59:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ting's more background clarification.=20 I assume the difference you mentioned is between "SHA-1: 3d0a49ad47619c30c8= 4bbee8a33f54b64dddbcec" and "SHA-1: 7648748e99eeeadec38fda7568adb260c4acc86= 1". The two commits does cause the different behavior as Ting said below. G= it version 3d0a49ad will only set the policy to dhcp but don't trigger D.O.= R.A while 7648748e always trigger D.O.R.A if policy is DHCP. Version 7648748e commit is also the current behavior of Ip4Config2: DHCP po= licy together with D.O.R.A process, which is similar to the old Ip4Config b= ehavior. The version 3d0a49ad did was trying to resolve the Ip4Dxe performa= nce but it's not workable for IPv6, so we reverted it.=20 Thanks, Jiaxin > -----Original Message----- > From: Ye, Ting > Sent: Thursday, August 11, 2016 11:03 AM > To: Cohen, Eugene ; edk2-devel@lists.01.org; Wu, Jiaxin > > Subject: RE: DHCP Automatic Configure at Driver Connect >=20 > Hi Eugene, >=20 > Actually this is exactly the problem Samer raised to the mailing list in = Aug 2015. > We ever fixed it with following patch: >=20 > SHA-1: 3d0a49ad47619c30c84bbee8a33f54b64dddbcec >=20 > * MdeModulePkg: Fix issue about current Ip4Dxe implementation for DHCP > DORA process >=20 > DHCP policy is applied as default at boot time on all NICs in the system,= which > results in all NIC ports attempting DHCP and trying to acquire IP address= es > during boot. > Ip4 driver should only set dhcp as default policy, and not trigger DORA a= t > driver binding start(). We should start DORA until one IP child is config= ured to > use default address. >=20 > Later HP raised the same performance impact in IPv6 stack. We realized we > couldn't use the same logic to defer DHCP6 SARR process. > Instead, we discussed the issue in spec group and we removed the > restriction from UEFI specification that the default policy should be > Ip4Config2PolicyDhcp or Ip6ConfigPolicyAutomatic. It's up to > implementation's choice. > The EDKII implementation was later updated that the default policy was > changed to Ip4Config2PolicyStatic and IP6ConfigPolicyManual. Also the > previous change was reverted, in order to keep IP4/IP6 solution consisten= t. > See patch (also reviewed by Samer): >=20 > SHA-1: 7648748e99eeeadec38fda7568adb260c4acc861 >=20 > * MdeModulePkg: Change the default IPv4 config policy >=20 > Git version '3d0a49ad' commit provided a scenario to resolve the > performance issue for IPv4, but it's not workable for IPv6. To avoid IPv4= and > IPv6 inconsistency, we decided to revert that version fix. >=20 > If so, the default policy for Ip4Config2 is Ip4Config2PolicyDhcp, which r= esults > in all NIC ports attempting DHCP. So, this patch is used to changes the t= he > default IPv4 config policy to Ip4Config2PolicyStatic and also defer the S= etData > operation after Ip4Config2Protocol installed. This update let the other > platform drivers have chance to change the default config data by consume > Ip4Config2Protocol. >=20 >=20 > Current implementation recommends that the system should stay in default > policy - static to not initialize DHCP process, unless the system needs t= o start > DHCP -- it should change the policy to IP4Config2PolicyDhcp. >=20 > Best Regards, > Ye Ting >=20 >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Cohen, Eugene > Sent: Thursday, August 11, 2016 2:17 AM > To: edk2-devel@lists.01.org; Wu, Jiaxin > Subject: [edk2] DHCP Automatic Configure at Driver Connect >=20 > With this commit: >=20 > Revision: 1f6729ffe98095107ce82e67a4a0209674601a90 > Author: jiaxinwu > Date: 7/7/2015 2:19:55 AM > Message: > MdeModulePkg: Update Ip4Dxe driver to support Ip4Config2 protocol, >=20 > a new behavior seemed to come in to the network stack that was not > present before: It appears now that as soon as the DHCP Service Binding > protocol is installed the DHCP process will be initiated (see > Ip4Config2OnDhcp4SbInstalled). This differs from past behavior where DHC= P > would only occur if a driver or application specifically did Configure() = on the > network interface. >=20 > For some systems this is problematic because they need to defer DHCP unti= l > it is certain that the network interface will be used for something. >=20 > Can you provide the reason for this change? Can we have a policy (PCD) t= o > disable this mode of operation? >=20 > Thanks, >=20 > Eugene >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel