From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ml01.01.org (Postfix) with ESMTP id 4917C1A1DFC for ; Wed, 17 Aug 2016 20:27:48 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 17 Aug 2016 20:27:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,537,1464678000"; d="scan'208";a="867336902" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 17 Aug 2016 20:27:45 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 17 Aug 2016 20:27:40 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 17 Aug 2016 20:27:40 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by shsmsx102.ccr.corp.intel.com ([169.254.2.147]) with mapi id 14.03.0248.002; Thu, 18 Aug 2016 11:27:38 +0800 From: "Wu, Jiaxin" To: "Fu, Siyuan" , Santhapur Naveen , "Ye, Ting" , "edk2-devel@lists.01.org" CC: Sivaraman Nainar , "Madhan B. Santharam" Thread-Topic: Classless IP support for IPv4 PXE boot Thread-Index: AdH4e2JhpVdKe1quTBqkAuTkO1R+hAAfzWUwAAAzKZAAADar8AAAo7ZwAABNKuA= Date: Thu, 18 Aug 2016 03:27:37 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274137C86B2@SHSMSX103.ccr.corp.intel.com> References: <625A2455CC232F40B0F38F05ACED6D976C4DA5CE@VENUS1.in.megatrends.com> <625A2455CC232F40B0F38F05ACED6D976C4DAC44@VENUS1.in.megatrends.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: Classless IP support for IPv4 PXE boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 03:27:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yeah, thanks for digging this out. Classless IP was not considered here.=20 Jiaxin=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu= , > Siyuan > Sent: Thursday, August 18, 2016 11:21 AM > To: Santhapur Naveen ; Ye, Ting > ; edk2-devel@lists.01.org > Cc: Sivaraman Nainar ; Madhan B. Santharam > > Subject: Re: [edk2] Classless IP support for IPv4 PXE boot >=20 > Naveen, >=20 > I see it, the corresponding GIT version is > ce964733292e31dce34e0be651f20a9d79884132. >=20 > I believe it's a regression bug, the change assume the IP address is alwa= ys > classful. I think it should check the option list to see if a subnet mas= k option is > present. >=20 > Could you please file a new bug in the Tianocore Bugzilla web site. In fu= ture > you can directly report issues to the Bugzilla also. Thanks > https://tianocore.acgmultimedia.com/ > https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues >=20 > Siyuan >=20 > From: Santhapur Naveen [mailto:naveens@amiindia.co.in] > Sent: Thursday, August 18, 2016 11:15 AM > To: Ye, Ting ; Fu, Siyuan ; edk2- > devel@lists.01.org > Cc: Sivaraman Nainar ; Madhan B. Santharam > > Subject: RE: Classless IP support for IPv4 PXE boot >=20 >=20 > Please find the below details and snapshot. >=20 >=20 >=20 > Revision: 21543 >=20 > Author: Wu.Jiaxin >=20 > Date: Thursday, June 18, 2015 6:13:15 AM >=20 > Message: MdeModulePkg: Remove DHCP4.TransmitReceive() and DORA > process dependency. >=20 > Modified: > /trunk/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c >=20 >=20 >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 >=20 > Signed-off-by: Wu Jiaxin = > >=20 > Reviewed-by: Ye Ting > >=20 > Reviewed-by: Fu Siyuan > >=20 >=20 >=20 > Please check if the below snapshot may help. >=20 > [cid:image001.jpg@01D1F92C.D1247640] >=20 >=20 >=20 > Thanks, >=20 > Naveen >=20 >=20 >=20 > -----Original Message----- > From: Ye, Ting [mailto:ting.ye@intel.com] > Sent: Thursday, August 18, 2016 8:23 AM > To: Fu, Siyuan; Santhapur Naveen; edk2-devel@lists.01.org devel@lists.01.org> > Cc: Sivaraman Nainar; Madhan B. Santharam > Subject: RE: Classless IP support for IPv4 PXE boot >=20 >=20 >=20 > I searched the log messages: >=20 >=20 >=20 > Revision: 21543 >=20 > Author: edk2buildsystem >=20 > Date: Friday, July 01, 2016 5:05:51 AM >=20 > Message: >=20 > MdeModulePkg VariableInfo: Fix GCC build failure >=20 >=20 >=20 > GCC build failure: 'RealCommSize' may be used uninitialized >=20 >=20 >=20 > Cc: Jiewen Yao > >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 >=20 > Signed-off-by: Star Zeng = > >=20 > Reviewed-by: Giri P Mudusuru > > (cherry > picked from commit 05b39efb669eaa173a76e58daf8e65bce2e0299e) >=20 > ---- >=20 > Modified : > /trunk/edk2/MdeModulePkg/Application/VariableInfo/VariableInfo.c >=20 >=20 >=20 >=20 >=20 > This looks irrelevant. Could you please confirm the revision? >=20 >=20 >=20 > Thanks, >=20 > Ting >=20 >=20 >=20 > -----Original Message----- >=20 > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu= , > Siyuan >=20 > Sent: Thursday, August 18, 2016 10:48 AM >=20 > To: Santhapur Naveen > >; edk2- > devel@lists.01.org >=20 > Cc: Sivaraman Nainar > >; Madhan > B. Santharam > >=20 > Subject: Re: [edk2] Classless IP support for IPv4 PXE boot >=20 >=20 >=20 > Hi, Naveen >=20 >=20 >=20 > May I know the GIT version of the 21543, or the subject of the commit > message? I can't see the svn revision number on my side. >=20 >=20 >=20 > Thanks >=20 > Siyuan >=20 >=20 >=20 > > -----Original Message----- >=20 > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >=20 > > Santhapur Naveen >=20 > > Sent: Wednesday, August 17, 2016 7:41 PM >=20 > > To: edk2-devel@lists.01.org >=20 > > Cc: Sivaraman Nainar > > >; > Madhan > > B. Santharam >=20 > > > >=20 > > Subject: [edk2] Classless IP support for IPv4 PXE boot >=20 > > >=20 > > Hello, >=20 > > >=20 > > We happened to observe that the IPv4 PXE boot was happening >=20 > > successfully for both classless and classful IPs until the EDKII >=20 > > revision 21542. It has been found that there are some changes made in >=20 > > the revision >=20 > > 21543 and the IPv4 PXE boot is failing for classless IP addresses. The >=20 > > failure scenario was debugged and is explained here. Let's assume the >=20 > > subnet range is 192.168.1.0/16. The DHCP server tries to allot an IP >=20 > > (let's say 192.168.1.0) but based on the first byte of the IP address >=20 > > to be assigned, the function NetGetIpClass() returns the IP class as >=20 > > Class-C and its respective subnet mask as 255.255.255.0 that should be >=20 > > for a classful IP address whereas 255.255.0.0 is the actual subnet in >=20 > > this scenario. The changes present in function >=20 > > Dhcp4InstanceConfigUdpIo() seems to be responsible for the failure. >=20 > > >=20 > > May we know the reason behind the changes present in the Dhcp4Impl.c >=20 > > of the revision 21543? Is there any plan to bring the classless IP >=20 > > support in NetworkPkg? >=20 > > >=20 > > >=20 > > Thanks, >=20 > > Naveen >=20 > > _______________________________________________ >=20 > > edk2-devel mailing list >=20 > > edk2-devel@lists.01.org >=20 > > https://lists.01.org/mailman/listinfo/edk2-devel >=20 > _______________________________________________ >=20 > edk2-devel mailing list >=20 > edk2-devel@lists.01.org >=20 > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel