Re: [PATCH 2/2] [edk2-staging/HTTPS-TLS][PATCH]: NetworkPkg/HttpDxe: Unrestrict TLSv

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

In TlsConfigureSession(), below piece of code should also be removed. Others is good to me.

  HttpInstance->TlsConfigData.Version.Major = TLS10_PROTOCOL_VERSION_MAJOR;
  HttpInstance->TlsConfigData.Version.Minor = TLS10_PROTOCOL_VERSION_MINOR;

Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>

Thanks,
Jiaxin


> -----Original Message-----
> From: Thomas Palmer [mailto:thomas.palmer@hpe.com]
> Sent: Saturday, August 27, 2016 3:09 AM
> To: edk2-devel@lists.01.org
> Cc: joseph.shifflett@hpe.com; Wu, Jiaxin <jiaxin.wu@intel.com>; Thomas
> Palmer <thomas.palmer@hpe.com>
> Subject: [PATCH 2/2] [edk2-staging/HTTPS-TLS][PATCH]:
> NetworkPkg/HttpDxe: Unrestrict TLSv
> 
> Demonstrate the TLS regotiation in this feature branch. Remove the code
> that calls EfiTlsVersion in the HttpDxe module.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
> ---
>  NetworkPkg/HttpDxe/HttpsSupport.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c
> b/NetworkPkg/HttpDxe/HttpsSupport.c
> index 9a68b45..4cfeab5 100644
> --- a/NetworkPkg/HttpDxe/HttpsSupport.c
> +++ b/NetworkPkg/HttpDxe/HttpsSupport.c
> @@ -2,6 +2,7 @@
>    Miscellaneous routines specific to Https for HttpDxe driver.
> 
>  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> +(C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>  This program and the accompanying materials  are licensed and made
> available under the terms and conditions of the BSD License  which
> accompanies this distribution.  The full text of the license may be found at
> @@ -487,23 +488,12 @@ TlsConfigureSession (
>    HttpInstance->TlsConfigData.SessionState = EfiTlsSessionNotStarted;
> 
>    //
> -  // EfiTlsVersion
>    // EfiTlsConnectionEnd,
>    // EfiTlsVerifyMethod
>    // EfiTlsSessionState
>    //
>    Status = HttpInstance->Tls->SetSessionData (
>                                  HttpInstance->Tls,
> -                                EfiTlsVersion,
> -                                &(HttpInstance->TlsConfigData.Version),
> -                                sizeof (EFI_TLS_VERSION)
> -                                );
> -  if (EFI_ERROR (Status)) {
> -    goto ERROR;
> -  }
> -
> -  Status = HttpInstance->Tls->SetSessionData (
> -                                HttpInstance->Tls,
>                                  EfiTlsConnectionEnd,
>                                  &(HttpInstance->TlsConfigData.ConnectionEnd),
>                                  sizeof (EFI_TLS_CONNECTION_END)
> --
> 2.7.4