From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AB8151A1E90 for ; Wed, 7 Sep 2016 01:23:43 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 07 Sep 2016 01:23:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,295,1470726000"; d="scan'208";a="1026190527" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 07 Sep 2016 01:23:43 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 01:23:42 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 01:23:42 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.102]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.91]) with mapi id 14.03.0248.002; Wed, 7 Sep 2016 16:23:40 +0800 From: "Wu, Jiaxin" To: Thomas Palmer , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 2/2] [edk2-staging/HTTPS-TLS][PATCH]: NetworkPkg/HttpDxe: Unrestrict TLSv Thread-Index: AQHR/81W2njhuee+jUWCIIvPbCepBqBtwjyQ Date: Wed, 7 Sep 2016 08:23:40 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274137FABC5@SHSMSX103.ccr.corp.intel.com> References: <1472238525-40024-1-git-send-email-thomas.palmer@hpe.com> <1472238525-40024-3-git-send-email-thomas.palmer@hpe.com> In-Reply-To: <1472238525-40024-3-git-send-email-thomas.palmer@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjMxZTM0MWQtZDhkMC00Mzc4LTk3OGItMTAxMzAwODUzYjk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZJait5UkU5alVyMFREWlA1a1J2MWFwZGJXbnZWVjhYM2RzWkp3VHdCK3c9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] [edk2-staging/HTTPS-TLS][PATCH]: NetworkPkg/HttpDxe: Unrestrict TLSv X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 08:23:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In TlsConfigureSession(), below piece of code should also be removed. Other= s is good to me. HttpInstance->TlsConfigData.Version.Major =3D TLS10_PROTOCOL_VERSION_MAJO= R; HttpInstance->TlsConfigData.Version.Minor =3D TLS10_PROTOCOL_VERSION_MINO= R; Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -----Original Message----- > From: Thomas Palmer [mailto:thomas.palmer@hpe.com] > Sent: Saturday, August 27, 2016 3:09 AM > To: edk2-devel@lists.01.org > Cc: joseph.shifflett@hpe.com; Wu, Jiaxin ; Thomas > Palmer > Subject: [PATCH 2/2] [edk2-staging/HTTPS-TLS][PATCH]: > NetworkPkg/HttpDxe: Unrestrict TLSv >=20 > Demonstrate the TLS regotiation in this feature branch. Remove the code > that calls EfiTlsVersion in the HttpDxe module. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Thomas Palmer > --- > NetworkPkg/HttpDxe/HttpsSupport.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) >=20 > diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c > b/NetworkPkg/HttpDxe/HttpsSupport.c > index 9a68b45..4cfeab5 100644 > --- a/NetworkPkg/HttpDxe/HttpsSupport.c > +++ b/NetworkPkg/HttpDxe/HttpsSupport.c > @@ -2,6 +2,7 @@ > Miscellaneous routines specific to Https for HttpDxe driver. >=20 > Copyright (c) 2016, Intel Corporation. All rights reserved.
> +(C) Copyright 2016 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License which > accompanies this distribution. The full text of the license may be found= at > @@ -487,23 +488,12 @@ TlsConfigureSession ( > HttpInstance->TlsConfigData.SessionState =3D EfiTlsSessionNotStarted; >=20 > // > - // EfiTlsVersion > // EfiTlsConnectionEnd, > // EfiTlsVerifyMethod > // EfiTlsSessionState > // > Status =3D HttpInstance->Tls->SetSessionData ( > HttpInstance->Tls, > - EfiTlsVersion, > - &(HttpInstance->TlsConfigData.Version), > - sizeof (EFI_TLS_VERSION) > - ); > - if (EFI_ERROR (Status)) { > - goto ERROR; > - } > - > - Status =3D HttpInstance->Tls->SetSessionData ( > - HttpInstance->Tls, > EfiTlsConnectionEnd, > &(HttpInstance->TlsConfigData.Connection= End), > sizeof (EFI_TLS_CONNECTION_END) > -- > 2.7.4