Re: [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Gary,

Can you make a detail description about the issue? Forgive my ignorance, I don't know 'RSOD' exactly mean here. 

> Avoid the Ip6NdFasterTimerTicking is executed again before the previous
> Ip6NdFasterTimerTicking is done.
> When user presses hotkey between the below line, it makes the

Here, you mentioned press POST hotkey between the below line, I'm also confused with such hotkey, what does the 'below line' mean? Is that your platform particular implementation for such a hotkey?

> Ip6NdFasterTimerTicking is dispatched again before the previous
> Ip6NdFasterTimerTicking is done.
> Therefore, the DelayNode node will be removed twice.
>

Looks so strange for the re-dispatch issue, are you sure it's the same DelayNode? More description/background for the system configuration or your analysis is appreciated.

Thanks,
Jiaxin

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Li,
> Gary (HPS SW)
> Sent: Friday, September 23, 2016 5:52 AM
> To: Ye, Ting <ting.ye@intel.com>; edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: Re: [edk2] [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe
> 
> Hi Ting,
> 
> This issue can be reproduce by switching POST hotkey quickly and  repeatedly.
> 
> Regards,
> 
> Gary Li
> Platform SW Engineering
> Servers
> Office: +886 (2) 8722 9977
> 
> -----Original Message-----
> From: Ye, Ting [mailto:ting.ye@intel.com]
> Sent: Thursday, September 22, 2016 4:48 PM
> To: Li, Gary (HPS SW) <garyli@hpe.com>; edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: RE: [edk2] [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe
> 
> Hi Gary,
> 
> Do you mind sharing more details about how to reproduce this issue? We are
> not clear why this would happen.
> It seems the code should continue executing the previous
> Ip6NdFasterTimerTicking function rather than dispatching the new timer event.
> 
> Thanks,
> Ye Ting
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gary
> Li
> Sent: Thursday, September 22, 2016 2:38 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe
> 
> Avoid the Ip6NdFasterTimerTicking is executed again before the previous
> Ip6NdFasterTimerTicking is done.
> When user presses hotkey between the below line, it makes the
> Ip6NdFasterTimerTicking is dispatched again before the previous
> Ip6NdFasterTimerTicking is done.
> Therefore, the DelayNode node will be removed twice.
> 
> DelayNode = NET_LIST_USER_STRUCT (Entry2, IP6_DELAY_JOIN_LIST, Link); ...
> RemoveEntryList (&DelayNode->Link);
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> 
> Signed-off-by: Gary Li <garyli@hpe.com>
> ---
>  NetworkPkg/Ip6Dxe/Ip6Nd.c | 31 +++++++++++++++++++++----------
>  1 file changed, 21 insertions(+), 10 deletions(-)
> 
> diff --git a/NetworkPkg/Ip6Dxe/Ip6Nd.c b/NetworkPkg/Ip6Dxe/Ip6Nd.c index
> a3f49bb..d400d7c 100644
> --- a/NetworkPkg/Ip6Dxe/Ip6Nd.c
> +++ b/NetworkPkg/Ip6Dxe/Ip6Nd.c
> @@ -2,6 +2,7 @@
>    Implementation of Neighbor Discovery support routines.
> 
>    Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
> +  (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> 
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License @@ -16,6 +17,7 @@  #include "Ip6Impl.h"
> 
>  EFI_MAC_ADDRESS mZeroMacAddress;
> +BOOLEAN mIsInIp6NdFasterTimerTicking = FALSE;
> 
>  /**
>    Update the ReachableTime in IP6 service binding instance data, in
> milliseconds.
> @@ -2774,6 +2776,12 @@ Ip6NdFasterTimerTicking (
>    IP6_SERVICE               *IpSb;
>    BOOLEAN                   Flag;
> 
> +  if (!mIsInIp6NdFasterTimerTicking) {
> +    mIsInIp6NdFasterTimerTicking = TRUE;  } else {
> +    return;
> +  }
> +
>    IpSb = (IP6_SERVICE *) Context;
>    NET_CHECK_SIGNATURE (IpSb, IP6_SERVICE_SIGNATURE);
> 
> @@ -2848,7 +2856,7 @@ Ip6NdFasterTimerTicking (
>                       NULL
>                       );
>            if (EFI_ERROR (Status)) {
> -            return;
> +            goto Exit;
>            }
> 
>            DupAddrDetect->Transmit++;
> @@ -2896,7 +2904,7 @@ Ip6NdFasterTimerTicking (
>            Ip6CreateSNMulticastAddr (&NeighborCache->Neighbor, &Destination);
>            Status = Ip6SelectSourceAddress (IpSb, &NeighborCache->Neighbor,
> &Source);
>            if (EFI_ERROR (Status)) {
> -            return;
> +            goto Exit;
>            }
> 
>            Status = Ip6SendNeighborSolicit ( @@ -2907,7 +2915,7 @@
> Ip6NdFasterTimerTicking (
>                       &IpSb->SnpMode.CurrentAddress
>                       );
>            if (EFI_ERROR (Status)) {
> -            return;
> +            goto Exit;
>            }
>          }
> 
> @@ -2934,7 +2942,7 @@ Ip6NdFasterTimerTicking (
>                     NULL
>                     );
>          if (EFI_ERROR (Status)) {
> -          return;
> +          goto Exit;
>          }
>        }
> 
> @@ -2965,7 +2973,7 @@ Ip6NdFasterTimerTicking (
>                       NULL
>                       );
>            if (EFI_ERROR (Status)) {
> -            return;
> +            goto Exit;
>            }
>          } else {
>            NeighborCache->State = EfiNeighborStale; @@ -2986,7 +2994,7 @@
> Ip6NdFasterTimerTicking (
>          //
>          Status = Ip6SelectSourceAddress (IpSb, &NeighborCache->Neighbor,
> &Source);
>          if (EFI_ERROR (Status)) {
> -          return;
> +          goto Exit;
>          }
> 
>          Status = Ip6SendNeighborSolicit ( @@ -2997,7 +3005,7 @@
> Ip6NdFasterTimerTicking (
>                     &IpSb->SnpMode.CurrentAddress
>                     );
>          if (EFI_ERROR (Status)) {
> -          return;
> +          goto Exit;
>          }
> 
>          NeighborCache->Transmit--;
> @@ -3023,7 +3031,7 @@ Ip6NdFasterTimerTicking (
>            //
>            Status = Ip6SelectSourceAddress (IpSb, &NeighborCache->Neighbor,
> &Source);
>            if (EFI_ERROR (Status)) {
> -            return;
> +            goto Exit;
>            }
> 
>            Status = Ip6SendNeighborSolicit ( @@ -3034,7 +3042,7 @@
> Ip6NdFasterTimerTicking (
>                       &IpSb->SnpMode.CurrentAddress
>                       );
>            if (EFI_ERROR (Status)) {
> -            return;
> +            goto Exit;
>            }
>          }
> 
> @@ -3061,7 +3069,7 @@ Ip6NdFasterTimerTicking (
>                     NULL
>                     );
>          if (EFI_ERROR (Status)) {
> -          return;
> +          goto Exit;
>          }
>        }
> 
> @@ -3071,6 +3079,9 @@ Ip6NdFasterTimerTicking (
>        break;
>      }
>    }
> +
> +Exit:
> +  mIsInIp6NdFasterTimerTicking = FALSE;
>  }
> 
>  /**
> --
> 2.7.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel