From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1872181DBC for ; Mon, 7 Nov 2016 16:25:53 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 07 Nov 2016 16:25:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,459,1473145200"; d="scan'208";a="28636302" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 07 Nov 2016 16:25:55 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 7 Nov 2016 16:25:55 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Tue, 8 Nov 2016 08:25:52 +0800 From: "Wu, Jiaxin" To: hegdenag , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" , "Ni, Ruiyu" Thread-Topic: [edk2] [PATCH v1 1/1] ShellPkg/Ping6: Add a note in help for TargetIp Thread-Index: AQHSONK98FW7N0kLu0mAMSqYphy5BqDOO4TA Date: Tue, 8 Nov 2016 00:25:51 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274138A3723@SHSMSX103.ccr.corp.intel.com> References: <20161107084048.19992-1-nagaraj-p.hegde@hpe.com> In-Reply-To: <20161107084048.19992-1-nagaraj-p.hegde@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWQwMzdhYTgtZjNhNS00MjJjLWI2YzYtNDVhOTJjN2Q5NjQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5kMytwYmI5TVhPa0JhMjYzZUUzNHpuWDhkNFdYeDd0eU5xTGZ1Q2JicU09In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/1] ShellPkg/Ping6: Add a note in help for TargetIp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2016 00:25:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > hegdenag > Sent: Monday, November 7, 2016 4:41 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu ; > Wu, Jiaxin > Subject: [edk2] [PATCH v1 1/1] ShellPkg/Ping6: Add a note in help for Tar= getIp >=20 > 'Ping6 TargetIp' is a valid command input but we bail out when TargetIp i= s a > link local address because we would want the user to specify the NIC (via > SourceIp) through which he/she would want to ping to TargetIp. This patch > updates the help text to mention the same. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Hegde Nagaraj P > --- >=20 > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Command > sLib.uni | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comma > ndsLib.uni > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comma > ndsLib.uni > index 8f27e27..5adc5b5 100644 > --- > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comma > ndsLib.uni > +++ > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > +++ mandsLib.uni > @@ -99,6 +99,8 @@ > " -n count Send request count, (default=3D10, min=3D1, max=3D10000).= \r\n" > " -s SourceIp Source IPv6 address.\r\n" > " TargetIp Target IPv6 address.\r\n" > +"NOTES:\r\n" > +" 1. When TargetIp is a link local address, SourceIp needs to be specif= ied.\r\n" > ".SH EXAMPLES\r\n" > " \r\n" > "Examples:\r\n" > -- > 2.8.3.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel