public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Palmer, Thomas" <thomas.palmer@hpe.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	edk2-devel-01 <edk2-devel@ml01.01.org>,
	"Zimmer, Vincent" <vincent.zimmer@intel.com>,
	"Li, Ruth" <ruth.li@intel.com>,  "Ye, Ting" <ting.ye@intel.com>,
	"Long, Qin" <qin.long@intel.com>,
	"Fu, Siyuan" <siyuan.fu@intel.com>
Subject: Re: Sync staging/HTTPS-TLS feature into edk2 master!
Date: Tue, 6 Dec 2016 00:40:59 +0000	[thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B7274138B7A0C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <CS1PR84MB015128E424112B630A3BFA7DED830@CS1PR84MB0151.NAMPRD84.PROD.OUTLOOK.COM>

Thanks Thomas and Mike,

I will refine the code first according your feedback, then following the EDK2 process by sending the series patches for the whole feature.

Best Regards!
Jiaxin


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Palmer, Thomas
> Sent: Tuesday, December 6, 2016 6:23 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; edk2-devel-01 <edk2-devel@ml01.01.org>; Zimmer,
> Vincent <vincent.zimmer@intel.com>; Li, Ruth <ruth.li@intel.com>; Ye, Ting
> <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>
> Subject: Re: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
> 
> 
> Besides formal EDK2 process, there are a couple more things to fix up for
> Linux/GCC compiles:
> 
> 1)      Need to remove  no-pqueue  from process_files.sh
> 
> 2)      In OpensslTlsLib.inf, GCC:*_*_*_CC_FLAGS     = -Wno-unused-but-set-
> variable
> 
> I'm wondering also if the SSL library compilation in general needs more
> scrutiny ... EDK2 has a couple of files of scripts/patches for libcrypto ...
> 
> 
> Regards,
> 
> Thomas Palmer
> 
> "I have only made this letter longer because I have not had the time to make
> it shorter" - Blaise Pascal
> 
> From: Kinney, Michael D [mailto:michael.d.kinney@intel.com]
> Sent: Sunday, December 4, 2016 1:36 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel-01 <edk2-
> devel@ml01.01.org>; Zimmer, Vincent <vincent.zimmer@intel.com>; Palmer,
> Thomas <thomas.palmer@hpe.com>; Li, Ruth <ruth.li@intel.com>; Ye, Ting
> <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
> 
> Wu, Jiaxin,
> 
> You still need to go through the standard EDK II patch review process.  I know
> this may be a large feature that may not support the standard email patch
> review, but please, at a minimum, send a patch review email with a link to
> the edk2-staging branch and the summary of the changes, so everyone
> knows what packages/modules are impacted by this new feature.  Will the
> actually commit to edk2/master be a single patch or is it broken up into a
> patch series?  That should be in the summary as well.
> 
> Please Cc the developers that are required to do the review and response
> with Reviewed-by before Dec 16th so the feature can be added to
> edk2/master.
> 
> Thanks,
> 
> Mike
> 
> From: Wu, Jiaxin
> Sent: Saturday, December 3, 2016 10:47 PM
> To: edk2-devel-01 <edk2-devel@ml01.01.org<mailto:edk2-
> devel@ml01.01.org>>; Zimmer, Vincent
> <vincent.zimmer@intel.com<mailto:vincent.zimmer@intel.com>>; Kinney,
> Michael D
> <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>;
> Palmer Thomas
> <thomas.palmer@hpe.com<mailto:thomas.palmer@hpe.com>>; Li, Ruth
> <ruth.li@intel.com<mailto:ruth.li@intel.com>>; Ye, Ting
> <ting.ye@intel.com<mailto:ting.ye@intel.com>>; Long, Qin
> <qin.long@intel.com<mailto:qin.long@intel.com>>; Fu, Siyuan
> <siyuan.fu@intel.com<mailto:siyuan.fu@intel.com>>
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>
> Subject: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
> 
> 
> Hi All,
> 
> 
> 
> I propose to sync the edk2-staging/HTTPS-TLS feature into edk2 master.
> Detailed feature description can be found @
> https://github.com/tianocore/edk2-staging/tree/HTTPS-TLS, including
> feature timeline, support scope and verifications.
> 
> 
> 
> If there is no objection, I will check in the patch before 5PM on Dec 16th,
> (UTC+08:00) Beijing Time. Please let me know if you have any concern about
> that.
> 
> 
> 
> Thanks and Best Regards!
> 
> Wu, Jiaxin
> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2016-12-06  0:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-04  6:46 Sync staging/HTTPS-TLS feature into edk2 master! Wu, Jiaxin
2016-12-04 19:36 ` Kinney, Michael D
2016-12-05 22:22   ` Palmer, Thomas
2016-12-06  0:40     ` Wu, Jiaxin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895558F6EA4E3B41AC93A00D163B7274138B7A0C@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox