Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>


> -----Original Message-----
> From: Gary Lin [mailto:glin@suse.com]
> Sent: Wednesday, December 7, 2016 11:41 AM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Lubo <lubo.zhang@intel.com>; Ye, Ting <ting.ye@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH] ShellPkg: Assign the correct value to ShellStatus
> 
> Since the type of ShellStatus is SHELL_STATUS, we should use
> SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> Cc: Zhang Lubo <lubo.zhang@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> index fb308cc3b6..d71688ed66 100644
> --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo (
> 
>        if (StrCmp (VarArg->Arg, L"host") == 0) {
>          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle,
> Status);
> -        ShellStatus = EFI_INVALID_PARAMETER;
> +        ShellStatus = SHELL_INVALID_PARAMETER;
>          goto ON_EXIT;
>        } else if (StrCmp (VarArg->Arg, L"gw") == 0) {
>          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle,
> Status);
> -        ShellStatus = EFI_INVALID_PARAMETER;
> +        ShellStatus = SHELL_INVALID_PARAMETER;
>          goto ON_EXIT;
>        } else if (StrCmp (VarArg->Arg, L"dns") == 0) {
>          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle,
> Status);
> -        ShellStatus = EFI_INVALID_PARAMETER;
> +        ShellStatus = SHELL_INVALID_PARAMETER;
>          goto ON_EXIT;
>        }
> 
> --
> 2.11.0