From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D594481D66 for ; Wed, 7 Dec 2016 16:56:13 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 07 Dec 2016 16:56:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,316,1477983600"; d="scan'208";a="15163620" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 07 Dec 2016 16:56:12 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 16:56:12 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 16:56:12 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.17]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.11]) with mapi id 14.03.0248.002; Thu, 8 Dec 2016 08:56:10 +0800 From: "Wu, Jiaxin" To: Gary Lin , "edk2-devel@lists.01.org" CC: "Zhang, Lubo" , "Ye, Ting" , "Fu, Siyuan" Thread-Topic: [PATCH] ShellPkg: Assign the correct value to ShellStatus Thread-Index: AQHSUDvPRt13M/7XV0uZtPkNiUbP9KD9Oysw Date: Thu, 8 Dec 2016 00:56:10 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274138BE21E@SHSMSX103.ccr.corp.intel.com> References: <20161207034051.12723-1-glin@suse.com> In-Reply-To: <20161207034051.12723-1-glin@suse.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTc1Njk4YWMtNDQ5Ny00NTYzLWJmYTQtYTk4ZWQ0ZGQ2YTAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjRneWV0MnBMcndhdHArVVV2RndydDk1MEJcL1czbUFsUFlBa1NrN0tXQnM0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 00:56:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Wu Jiaxin > -----Original Message----- > From: Gary Lin [mailto:glin@suse.com] > Sent: Wednesday, December 7, 2016 11:41 AM > To: edk2-devel@lists.01.org > Cc: Zhang, Lubo ; Ye, Ting ; Fu, > Siyuan ; Wu, Jiaxin > Subject: [PATCH] ShellPkg: Assign the correct value to ShellStatus >=20 > Since the type of ShellStatus is SHELL_STATUS, we should use > SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin > Cc: Zhang Lubo > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Wu Jiaxin > --- > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > index fb308cc3b6..d71688ed66 100644 > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo ( >=20 > if (StrCmp (VarArg->Arg, L"host") =3D=3D 0) { > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle, > Status); > - ShellStatus =3D EFI_INVALID_PARAMETER; > + ShellStatus =3D SHELL_INVALID_PARAMETER; > goto ON_EXIT; > } else if (StrCmp (VarArg->Arg, L"gw") =3D=3D 0) { > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle, > Status); > - ShellStatus =3D EFI_INVALID_PARAMETER; > + ShellStatus =3D SHELL_INVALID_PARAMETER; > goto ON_EXIT; > } else if (StrCmp (VarArg->Arg, L"dns") =3D=3D 0) { > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle, > Status); > - ShellStatus =3D EFI_INVALID_PARAMETER; > + ShellStatus =3D SHELL_INVALID_PARAMETER; > goto ON_EXIT; > } >=20 > -- > 2.11.0