Re: [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for Nt32 platform

From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "Ye, Ting" <ting.ye@intel.com>,
	"Zhang,  Lubo" <lubo.zhang@intel.com>,
	"Long, Qin" <qin.long@intel.com>,
	"Fu, Siyuan" <siyuan.fu@intel.com>
Subject: Re: [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for Nt32 platform
Date: Wed, 14 Dec 2016 07:46:47 +0000	[thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B72741627EE39@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A8BD069@SHSMSX104.ccr.corp.intel.com>

Thanks Jiewen, I'm fine with the flag rename:). 

Best Regards!
Jiaxin

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Wednesday, December 14, 2016 3:45 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>; Zhang,
> Lubo <lubo.zhang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Long, Qin
> <qin.long@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: RE: [edk2] [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for
> Nt32 platform
> 
> Hi Jiaxin
> Thanks to contribute this.
> 
> I found below update is NOT related to HTTPS.
> 
> Can we use a better name, such as TLS_ENABLE ?
> 
> +!if $(HTTPS_BOOT_ENABLE) == TRUE
> +  NetworkPkg/TlsDxe/TlsDxe.inf
> +  NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> +!endif
> 
> Thank you
> Yao Jiewen
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Jiaxin Wu
> > Sent: Wednesday, December 14, 2016 3:34 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>;
> > Zhang, Lubo <lubo.zhang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>;
> > Long, Qin <qin.long@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> > Subject: [edk2] [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for
> > Nt32 platform
> >
> > This path is used to enable HTTPS boot feature for Nt32 platform.
> >
> > Cc: Long Qin <qin.long@intel.com>
> > Cc: Ni Ruiyu <ruiyu.ni@intel.com>
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Zhang Lubo <lubo.zhang@intel.com>
> > Cc: Thomas Palmer <thomas.palmer@hpe.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > ---
> >  Nt32Pkg/Nt32Pkg.dsc | 15 ++++++++++++++-  Nt32Pkg/Nt32Pkg.fdf |  4
> > ++++
> >  2 files changed, 18 insertions(+), 1 deletion(-)
> >
> > diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index
> > 79ab2f7..07703a3 100644
> > --- a/Nt32Pkg/Nt32Pkg.dsc
> > +++ b/Nt32Pkg/Nt32Pkg.dsc
> > @@ -43,10 +43,17 @@
> >    #
> >    # Defines for default states.  These can be changed on the command line.
> >    # -D FLAG=VALUE
> >    #
> >    DEFINE SECURE_BOOT_ENABLE      = FALSE
> > +
> > +  #
> > +  # This flag is to enable or disable HTTPS boot feature.
> > +  # These can be changed on the command line.
> > +  # -D FLAG=VALUE
> > +  #
> > +  DEFINE HTTPS_BOOT_ENABLE      = TRUE
> >
> >
> >
> ##########################################################
> ###
> > ###################
> >  #
> >  # SKU Identification section - list of all SKU IDs supported by this
> >  #                              Platform.
> > @@ -189,10 +196,11 @@
> >
> >
> OemHookStatusCodeLib|Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/
> Dxe
> > Nt32OemHookStatusCodeLib.inf
> >
> >
> PeCoffExtraActionLib|Nt32Pkg/Library/DxeNt32PeCoffExtraActionLib/DxeNt
> > PeCoffExtraActionLib|32P
> > eCoffExtraActionLib.inf
> >
> >
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeE
> > ExtractGuidedSectionLib|xtra
> > ctGuidedSectionLib.inf
> >    WinNtLib|Nt32Pkg/Library/DxeWinNtLib/DxeWinNtLib.inf
> >    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> > +  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> >
> >  [LibraryClasses.common.DXE_CORE]
> >    HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
> >
> >
> MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLi
> b/Dx
> > eCoreMemoryAllocationLib.inf
> >    PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > @@ -232,11 +240,11 @@
> >    gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x1f
> >
> gEfiNt32PkgTokenSpaceGuid.PcdWinNtFirmwareVolume|L"..\\Fv\\Nt32.fd"
> >    gEfiNt32PkgTokenSpaceGuid.PcdWinNtFirmwareBlockSize|0x10000
> >    gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x0f
> >
> >
> gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC
> hang
> > e|FALSE
> > -!if $(SECURE_BOOT_ENABLE) == TRUE
> > +!if $(SECURE_BOOT_ENABLE) == TRUE || $(HTTPS_BOOT_ENABLE) ==
> TRUE
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> >  !endif
> >
> >  !ifndef $(USE_OLD_SHELL)
> >    gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83,
> > 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52,
> > 0x68, 0xD0, 0xB4,
> > 0xD1 }
> > @@ -437,10 +445,15 @@
> >
> >    NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> >    NetworkPkg/DnsDxe/DnsDxe.inf
> >    NetworkPkg/HttpDxe/HttpDxe.inf
> >    NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > +
> > +!if $(HTTPS_BOOT_ENABLE) == TRUE
> > +  NetworkPkg/TlsDxe/TlsDxe.inf
> > +  NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> > +!endif
> >
> >    MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> >    MdeModulePkg/Application/UiApp/UiApp.inf{
> >      <LibraryClasses>
> >
> >
> NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> > diff --git a/Nt32Pkg/Nt32Pkg.fdf b/Nt32Pkg/Nt32Pkg.fdf index
> > cf00a13..094ed91 100644
> > --- a/Nt32Pkg/Nt32Pkg.fdf
> > +++ b/Nt32Pkg/Nt32Pkg.fdf
> > @@ -260,10 +260,14 @@ INF
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> >  INF  MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> >  INF  NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> >  INF  NetworkPkg/DnsDxe/DnsDxe.inf
> >  INF  NetworkPkg/HttpDxe/HttpDxe.inf
> >  INF  NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > +!if $(HTTPS_BOOT_ENABLE) == TRUE
> > +INF  NetworkPkg/TlsDxe/TlsDxe.inf
> > +INF  NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> > +!endif
> >  INF
> >
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp
> p.in
> > f
> >
> >
> ##########################################################
> ###
> > ###################
> >  #
> >  # FILE statements are provided so that a platform integrator can
> > include  # complete EFI FFS files, as well as a method for
> > constructing FFS files
> > --
> > 1.9.5.msysgit.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel