From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA05581A33 for ; Tue, 13 Dec 2016 23:46:50 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 13 Dec 2016 23:46:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="42415234" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 13 Dec 2016 23:46:50 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 23:46:50 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.97]) with mapi id 14.03.0248.002; Wed, 14 Dec 2016 15:46:47 +0800 From: "Wu, Jiaxin" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Ye, Ting" , "Zhang, Lubo" , "Long, Qin" , "Fu, Siyuan" Thread-Topic: [edk2] [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for Nt32 platform Thread-Index: AQHSVdyUgF6Xj8qUHkegz9gSAdts7aEGihcAgACGNCA= Date: Wed, 14 Dec 2016 07:46:47 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B72741627EE39@SHSMSX103.ccr.corp.intel.com> References: <1481700859-76060-1-git-send-email-jiaxin.wu@intel.com> <1481700859-76060-11-git-send-email-jiaxin.wu@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A8BD069@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A8BD069@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTdjMjgzM2YtZGI5NC00ZDI4LTgyZTUtMGEyMTRlNzZiNWFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5RODhSNHlXOTlxZjF0ek1PeVMyVFg5SEV0VGVnNm5Ob2IzQ3B5Zm43cHM9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for Nt32 platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 07:46:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Jiewen, I'm fine with the flag rename:).=20 Best Regards! Jiaxin > -----Original Message----- > From: Yao, Jiewen > Sent: Wednesday, December 14, 2016 3:45 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Ye, Ting ; Zhang, > Lubo ; Wu, Jiaxin ; Long, Qin > ; Fu, Siyuan > Subject: RE: [edk2] [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for > Nt32 platform >=20 > Hi Jiaxin > Thanks to contribute this. >=20 > I found below update is NOT related to HTTPS. >=20 > Can we use a better name, such as TLS_ENABLE ? >=20 > +!if $(HTTPS_BOOT_ENABLE) =3D=3D TRUE > + NetworkPkg/TlsDxe/TlsDxe.inf > + NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > +!endif >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Jiaxin Wu > > Sent: Wednesday, December 14, 2016 3:34 PM > > To: edk2-devel@lists.01.org > > Cc: Ni, Ruiyu ; Ye, Ting ; > > Zhang, Lubo ; Wu, Jiaxin ; > > Long, Qin ; Fu, Siyuan > > Subject: [edk2] [Patch 10/10] Nt32Pkg: Enable HTTPS boot feature for > > Nt32 platform > > > > This path is used to enable HTTPS boot feature for Nt32 platform. > > > > Cc: Long Qin > > Cc: Ni Ruiyu > > Cc: Ye Ting > > Cc: Fu Siyuan > > Cc: Zhang Lubo > > Cc: Thomas Palmer > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Wu Jiaxin > > --- > > Nt32Pkg/Nt32Pkg.dsc | 15 ++++++++++++++- Nt32Pkg/Nt32Pkg.fdf | 4 > > ++++ > > 2 files changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index > > 79ab2f7..07703a3 100644 > > --- a/Nt32Pkg/Nt32Pkg.dsc > > +++ b/Nt32Pkg/Nt32Pkg.dsc > > @@ -43,10 +43,17 @@ > > # > > # Defines for default states. These can be changed on the command l= ine. > > # -D FLAG=3DVALUE > > # > > DEFINE SECURE_BOOT_ENABLE =3D FALSE > > + > > + # > > + # This flag is to enable or disable HTTPS boot feature. > > + # These can be changed on the command line. > > + # -D FLAG=3DVALUE > > + # > > + DEFINE HTTPS_BOOT_ENABLE =3D TRUE > > > > > > > ########################################################## > ### > > ################### > > # > > # SKU Identification section - list of all SKU IDs supported by this > > # Platform. > > @@ -189,10 +196,11 @@ > > > > > OemHookStatusCodeLib|Nt32Pkg/Library/DxeNt32OemHookStatusCodeLib/ > Dxe > > Nt32OemHookStatusCodeLib.inf > > > > > PeCoffExtraActionLib|Nt32Pkg/Library/DxeNt32PeCoffExtraActionLib/DxeNt > > PeCoffExtraActionLib|32P > > eCoffExtraActionLib.inf > > > > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeE > > ExtractGuidedSectionLib|xtra > > ctGuidedSectionLib.inf > > WinNtLib|Nt32Pkg/Library/DxeWinNtLib/DxeWinNtLib.inf > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > + TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > > > > [LibraryClasses.common.DXE_CORE] > > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > > > > > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLi > b/Dx > > eCoreMemoryAllocationLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > @@ -232,11 +240,11 @@ > > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x1f > > > gEfiNt32PkgTokenSpaceGuid.PcdWinNtFirmwareVolume|L"..\\Fv\\Nt32.fd" > > gEfiNt32PkgTokenSpaceGuid.PcdWinNtFirmwareBlockSize|0x10000 > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x0f > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC > hang > > e|FALSE > > -!if $(SECURE_BOOT_ENABLE) =3D=3D TRUE > > +!if $(SECURE_BOOT_ENABLE) =3D=3D TRUE || $(HTTPS_BOOT_ENABLE) =3D=3D > TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > > !endif > > > > !ifndef $(USE_OLD_SHELL) > > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, > > 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, > > 0x68, 0xD0, 0xB4, > > 0xD1 } > > @@ -437,10 +445,15 @@ > > > > NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > NetworkPkg/DnsDxe/DnsDxe.inf > > NetworkPkg/HttpDxe/HttpDxe.inf > > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > + > > +!if $(HTTPS_BOOT_ENABLE) =3D=3D TRUE > > + NetworkPkg/TlsDxe/TlsDxe.inf > > + NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > > +!endif > > > > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > MdeModulePkg/Application/UiApp/UiApp.inf{ > > > > > > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > > diff --git a/Nt32Pkg/Nt32Pkg.fdf b/Nt32Pkg/Nt32Pkg.fdf index > > cf00a13..094ed91 100644 > > --- a/Nt32Pkg/Nt32Pkg.fdf > > +++ b/Nt32Pkg/Nt32Pkg.fdf > > @@ -260,10 +260,14 @@ INF > > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > INF NetworkPkg/DnsDxe/DnsDxe.inf > > INF NetworkPkg/HttpDxe/HttpDxe.inf > > INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > +!if $(HTTPS_BOOT_ENABLE) =3D=3D TRUE > > +INF NetworkPkg/TlsDxe/TlsDxe.inf > > +INF NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > > +!endif > > INF > > > MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp > p.in > > f > > > > > ########################################################## > ### > > ################### > > # > > # FILE statements are provided so that a platform integrator can > > include # complete EFI FFS files, as well as a method for > > constructing FFS files > > -- > > 1.9.5.msysgit.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel