Re: [PATCH 6/6] NetworkPkg: Refine UintnToAscDecWithFormat functions logic

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>


> -----Original Message-----
> From: Wu, Hao A
> Sent: Wednesday, December 14, 2016 7:27 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Ye,
> Ting <ting.ye@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH 6/6] NetworkPkg: Refine UintnToAscDecWithFormat
> functions logic
> 
> This commit refines the logic for HttpBootUintnToAscDecWithFormat and
> PxeBcUintnToAscDecWithFormat. It avoids using the decrement operator '--'
> for array index to prevent possible mis-reports by static code checkers.
> 
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  NetworkPkg/HttpBootDxe/HttpBootSupport.c | 5 ++---
>  NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c   | 5 ++---
>  2 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> index 9410bf9..bdb29ae 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> @@ -86,11 +86,10 @@ HttpBootUintnToAscDecWithFormat (  {
>    UINTN                          Remainder;
> 
> -  while (Length > 0) {
> -    Length--;
> +  for (; Length > 0; Length--) {
>      Remainder      = Number % 10;
>      Number        /= 10;
> -    Buffer[Length] = (UINT8) ('0' + Remainder);
> +    Buffer[Length - 1] = (UINT8) ('0' + Remainder);
>    }
>  }
> 
> diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
> b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
> index 00c652d..568360d 100644
> --- a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
> +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
> @@ -1383,11 +1383,10 @@ PxeBcUintnToAscDecWithFormat (  {
>    UINTN                          Remainder;
> 
> -  while (Length > 0) {
> -    Length--;
> +  for (; Length > 0; Length--) {
>      Remainder      = Number % 10;
>      Number        /= 10;
> -    Buffer[Length] = (UINT8) ('0' + Remainder);
> +    Buffer[Length - 1] = (UINT8) ('0' + Remainder);
>    }
>  }
> 
> --
> 1.9.5.msysgit.0